Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-19 Thread Kevin Risden
Thanks to all those who tested RC 1. Triaged issues in RC 1: - CALCITE-2918 - JdbcTest / JdbcAdapterTest - Postgres - existing issue with operator precedence - thanks Stamatis Zampetakis and Zoltan Haindrich for helping track down root cause - no PR - tagged for 1.20.0

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-19 Thread Zoltan Haindrich
On 3/19/19 8:33 AM, Zoltan Haindrich wrote: * I've been using some jenkins jobs to run calcite tests - and in yesterday's  builds TpchTest started hanging (and timeouted after 10h) even in master branch  builds   I've run all tests locally on my machine - they passed; I right now doubt  that it 

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-19 Thread Zoltan Haindrich
Hello, I have run Hive tests - and it looks good. I right now know about 2 things which might worth mentioning: * CALCITE-2929 is about an issue which was noticed in Hive recently, namely: The expression CAST(col as integer) IS NULL is reduced to (col IS NULL) which might discard errors/etc

Re: Druid/MongoDB Integration test failures was: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Michael Mior
Thanks Kevin! Given that it seems like these failures existed in the 1.18.0 release and they do not appear to be bugs in Calcite, but rather stale tests, I would be inclined to go ahead with the release. -- Michael Mior mm...@apache.org Le lun. 18 mars 2019 à 17:58, Kevin Risden a écrit : > >

Re: Druid/MongoDB Integration test failures was: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Kevin Risden
Was able to get the VM build and reproduces the errors: https://issues.apache.org/jira/browse/CALCITE-2932 Planning to add more commentary there. Kevin Risden On Mon, Mar 18, 2019 at 5:45 PM Andrei Sereda wrote: > Sure. Let me know if you need help with Druid adapter. > > On Mon, Mar 18,

Re: Druid/MongoDB Integration test failures was: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Andrei Sereda
Sure. Let me know if you need help with Druid adapter. On Mon, Mar 18, 2019 at 5:36 PM Kevin Risden wrote: > Rebuilding the VM for just druid found that there is an issue with > zookeeper version - 3.4.10 doesn't exist on the release mirrors anymore for > when installing druid. Fixing to point

Re: Druid/MongoDB Integration test failures was: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Kevin Risden
Rebuilding the VM for just druid found that there is an issue with zookeeper version - 3.4.10 doesn't exist on the release mirrors anymore for when installing druid. Fixing to point to 3.4.13 and see if that will let me build the test vm correctly. Kevin Risden On Mon, Mar 18, 2019 at 5:32 PM

Re: Druid/MongoDB Integration test failures was: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Kevin Risden
Andrei - Thanks I just checked the results and see the same thing for MongoDB. I see you opened CALCITE-2931 as well with a PR. Since this is test only don't think this blocks the 1.19.0 release. As for Druid, looks like I'm still getting connection reset errors after rebuilding the test dataset

Re: Druid/MongoDB Integration test failures was: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Andrei Sereda
I just run Mongo tests using docker image. Failures seem to be related to key order in Bson document. Example: Expected {$project: {POP: '$pop', STATE: '$state'}} Actual {$project: {STATE: '$state', POP: '$pop'}} Those queries don't run as part of unit tests because they only work in mongo

Re: Druid/MongoDB Integration test failures was: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Kevin Risden
For the calcite-test-dataset vm, the docs say you can halt/up the VM. It turns out that Druid doesn't restart on up and MongoDB fails to start due to /var/run/mongodb missing. /var/run is symlinked to /run and /run is mounted as tmpfs so the folders are cleared on a restart. I don't know if this

Druid/MongoDB Integration test failures was: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Kevin Risden
Stamatis - Can you open JIRA cases for the Druid and MongoDB integration test failures with details? It would be good to track them down not sure if they would block the release depending on the errors. I seem to have an issue with my calcite-test-dataset vm currently since getting timeout errors

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-18 Thread Stamatis Zampetakis
System A: MacOS 10.13.6, jdk9, maven 3.5.2 System B: Ubuntu 18.04LTS, jdk1.8.0_192, maven 3.5.3 -run unit tests (mvn clean install) on staged sources and git repo OK -checked signatures and checksums OK -went quickly over release note OK -run integration tests (mvn -Dtest=foo

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-15 Thread Michael Mior
+1 (binding) checked hashes and signature, compiled and ran tests and a RAT check. -- Michael Mior mm...@apache.org Le ven. 15 mars 2019 à 10:38, Kevin Risden a écrit : > > Hi all, > > I have created a build for Apache Calcite 1.19.0, release candidate 1. > > Thanks to everyone who has

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-15 Thread Julian Hyde
+1 (binding) Checked hashes, KEYS, LICENSE, NOTICE, README; checked that contents of tar match git; compiled and ran tests using JDK 11 on Ubuntu linux. Verified that maven-wrapper.jar has gone. Julian On Fri, Mar 15, 2019 at 7:38 AM Kevin Risden wrote: > > Hi all, > > I have created a build

[VOTE] Release apache-calcite-1.19.0 (release candidate 1)

2019-03-15 Thread Kevin Risden
Hi all, I have created a build for Apache Calcite 1.19.0, release candidate 1. Thanks to everyone who has contributed to this release. Since RC 0, we have fixed the following issues: * [CALCITE-2925] Exclude maven-wrapper.jar from source distribution You can read the release notes here: