[VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Francis Chuang
Hi all, I have created a release for Apache Calcite Avatica Go 3.0.0, release candidate 1. The release notes are available here: https://github.com/apache/calcite-avatica-go/blob/master/site/go_history.md The commit to be voted on: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Kevin Risden
* Ran tests at git hash * Ran tests from tar.gz * Checked hashes and GPG key of tar.gz * Reviewed source for missing Apache headers * Reviewed history and documentation Few comments: * Dockerfile - think CMD ["python", "app.py"]" is not needed? line could be removed * go_development.md - docker-co

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Francis Chuang
Thanks for the review, Kevin! Please see my response in line. On 23/04/2018 11:18 AM, Kevin Risden wrote: * Ran tests at git hash * Ran tests from tar.gz * Checked hashes and GPG key of tar.gz * Reviewed source for missing Apache headers * Reviewed history and documentation Few comments: * Dock

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Kevin Risden
Thanks for the quick cleanup response. > I will add Go 1.9 to the travis file, but maybe we should just remove the note that Go 1.7+ is supported to reduce confusion. +1 for removing 1.7+ since it seems like a promise we can't easily keep. Kevin Risden On Sun, Apr 22, 2018 at 8:42 PM, Francis C

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Francis Chuang
Thanks, Kevin! Removed the statement regarding Go 1.7+ and updated the release date to be 3 days from today. On 23/04/2018 12:22 PM, Kevin Risden wrote: Thanks for the quick cleanup response. I will add Go 1.9 to the travis file, but maybe we should just remove the note that Go 1.7+ is sup

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-23 Thread Josh Elser
+1 (binding) * xsums+sigs OK * KEYS updated and signing key is published * No binary files in src release * License headers on relevant files * LICENSE is OK * NOTICE is OK Good work, Francis! On 4/22/18 8:05 PM, Francis Chuang wrote: Hi all, I have created a release for Apache Calcite Avatic

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-23 Thread Julian Hyde
+1 (binding) Downloaded, checked checksums (could not check signatures due to gpg problems on my machine), checked headers, LICENSE, NOTICE, README.md. Julian On Mon, Apr 23, 2018 at 7:04 PM, Josh Elser wrote: > +1 (binding) > > * xsums+sigs OK > * KEYS updated and signing key is published > *

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-24 Thread Michael Mior
+1 (binding) Compiled and ran tests and checked hashes and signature. Thanks Francis! -- Michael Mior mm...@uwaterloo.ca 2018-04-22 20:05 GMT-04:00 Francis Chuang : > Hi all, > > I have created a release for Apache Calcite Avatica Go 3.0.0, release > candidate 1. > > The release notes are availa

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-24 Thread Julian Hyde
One more thing. The new release policy[1] says "SHOULD NOT provide a MD5-file”. My vote on this RC is still +1. But let’s remove the .md5 file next release. .sha256 and .asc are all we need. [1] http://www.apache.org/dev/release-distribution#sigs-and-sums

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-24 Thread Francis Chuang
Thanks for the heads up, Julian! I will update the make-release-artifacts script and the documentation. On 25/04/2018 9:01 AM, Julian Hyde wrote: One more thing. The new release policy[1] says "SHOULD NOT provide a MD5-file”. My vote on this RC is still +1. But let’s remove the .md5 file next

[RESULT] [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-26 Thread Francis Chuang
Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 4 binding +1s: Francis Chuang Josh Elser Julian Hyde Michael Mior 1 non-binding +1s: Kevin Risden No 0s or -1s. Therefore I am delighted to announce that the proposal to relea