Re: Automatic maven snapshot releases

2021-12-13 Thread Jacques Nadeau
Josh, I've enabled the basic integration tests in my updated patch: https://github.com/apache/calcite/runs/4513702440?check_suite_focus=true LMK if you think that is sufficient. Thanks On Mon, Dec 13, 2021 at 4:05 PM Jacques Nadeau wrote: > I added a blurb about snapshot releases in the howto

Re: Automatic maven snapshot releases

2021-12-13 Thread Jacques Nadeau
I added a blurb about snapshot releases in the howto in the updated PR. LMK your thoughts. https://github.com/apache/calcite/pull/2641/files# On Mon, Dec 13, 2021 at 11:34 AM Julian Hyde wrote: > Jacques, > > Your 4 points are convincing. Snapshots (used in CI) will help people > stay on the ma

Re: Automatic maven snapshot releases

2021-12-13 Thread Julian Hyde
Jacques, Your 4 points are convincing. Snapshots (used in CI) will help people stay on the main branch, and therefore will increase engagement. It would be useful if there were some guidance in the HOWTO on using snapshots. (Don't release based on snapshots; snapshots may change or disappear with

Re: Automatic maven snapshot releases

2021-12-13 Thread Jacques Nadeau
I could add a basic build & test. Right now it is just a build and publish. Basic unit test suite seems like it would cover most common cases (where a rebase after pre-commit test causes a problem). Do you think it should be more thorough? Less? On Mon, Dec 13, 2021 at 9:52 AM Josh Elser wrote:

Re: Automatic maven snapshot releases

2021-12-13 Thread Josh Elser
(top-posting to avoid extending the "how" divergence) Looks great and thanks for your care to avoid advertising them as "releases". Only thing I was going to mention was about whether or not there's a minimally "acceptable" test suite which can reliably run against master before the new job

Re: Automatic maven snapshot releases

2021-12-13 Thread Vladimir Sitnikov
>Where is -Pasf defined/documented? https://calcite.apache.org/docs/howto.html#making-a-snapshot Vladimir

Re: Automatic maven snapshot releases

2021-12-13 Thread Jacques Nadeau
Let's keep the "should" conversation separate from the "how" conversation. *On should: * I understand that it worked in the past and then stopped working. I still think it is appropriate to confirm people are comfortable with enabling it again. *On how:* Vladimir, the github workflow job is confi

Re: Automatic maven snapshot releases

2021-12-12 Thread Vladimir Sitnikov
Jacques, which credentials are you going to supply to publish the snapshots to the ASF repository from GitHub? While I agree with moving towards GitHub actions, I would like to minimize the use of ASF credentials in non-ASF environments. Luckily, ASF infra supplies the relevant credentials for pu

Re: Automatic maven snapshot releases

2021-12-12 Thread Jacques Nadeau
Good questions, Julian. Some thoughts, in random order. I think snapshot releases have the ability to: 1. Reduce the likelihood of long-lived forks Right now, the easiest way one has to produce snapshot artifacts is to set up a separate process around a forked repo. Once this process exists, it i

Re: Automatic maven snapshot releases

2021-12-12 Thread Stamatis Zampetakis
In the past we used to have Jenkins jobs doing this but I guess when Jenkins "died" all of these were lost. I am just seeing this as restoring the old behavior so it's fine with me. Personally, I never used them in the past but if those are helpful to other people then why not. Best, Stamatis O

Re: Automatic maven snapshot releases

2021-12-12 Thread Julian Hyde
I have no problems with the technical side of this. And I am supportive of one-off snapshots, e.g. a snapshot for testing made a week or two ahead of a release. But there are some downsides with regular, automated snapshots, and I am concerned that projects and companies will become dependent o

Automatic maven snapshot releases

2021-12-12 Thread Jacques Nadeau
Hey All, I've been wanting to do more testing against master for integration purposes and right now that requires private builds. As such, I opened CALCITE-4934 [1] to add support for automatic snapshot builds deployed to the Apache snapshot Maven repository on master merges. As noted in the ticke