Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-04-11 Thread Raghav Sharma
Thanks Julian! It would really help us in moving forward. On Tue, 12 Apr 2022 at 12:01 AM Julian Hyde wrote: > I’ll add comments in the JIRA case. > > > > On Apr 9, 2022, at 11:32 PM, Raghav Sharma > wrote: > > > > Hi Julian/ Stamatis! > > > > We have raised a PR and logged a JIRA ticket for

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-04-11 Thread Julian Hyde
I’ll add comments in the JIRA case. > On Apr 9, 2022, at 11:32 PM, Raghav Sharma > wrote: > > Hi Julian/ Stamatis! > > We have raised a PR and logged a JIRA ticket for the contribution of the > dialect file of Firebolt in Calcite. PFB the links for the same: > > 1. JIRA ticket link:

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-04-10 Thread Raghav Sharma
Hi Julian/ Stamatis! We have raised a PR and logged a JIRA ticket for the contribution of the dialect file of Firebolt in Calcite. PFB the links for the same: 1. JIRA ticket link: https://issues.apache.org/jira/browse/CALCITE-5085 2. PR link: https://github.com/apache/calcite/pull/2764 Please

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-04-04 Thread Stamatis Zampetakis
Hi Raghav, Some tests which make use of the TEST_DB property assume that the database has the foodmart dataset (possibly others as well) loaded [1]. If you need to run tests with Firebolt, Postgres, etc., you have to manually load the dataset there. To do that you can take some inspiration from

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-04-04 Thread Raghav Sharma
Thankyou for the update. We will file a JIRA case with the link of the PR raised for the Calcite team to look into the code of the 'FireboltSqlDialect.java' file. Also, like it was mentioned before we did add a value 'FIREBOLT' to the list of allowable values for the 'TEST_DB' inside

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-04-01 Thread Julian Hyde
Sorry I was slow to respond to your earlier message. (No need to add me to the thread - I am on the list, just backlogged. By the way, I am on vacation for the next ten days, so don’t expect responses from me. Other project members may or may not be able to help.) Please log a JIRA case, as I

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-04-01 Thread Raghav Sharma
Adding Julian to the thread. Thanks & Regards, Raghav Sharma | SDE 1 | Data Engineering M: +91 7087637086 I Mail: ragh...@sigmoidanalytics.com On Thu, Mar 31, 2022 at 2:39 PM Raghav Sharma wrote: > Hey Julian! > I followed your suggestions related to the

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-03-31 Thread Raghav Sharma
Hey Julian! I followed your suggestions related to the dialect/plugin we want to contribute to Calcite for Firebolt. Some of the issues that we faced so far: 1. Tests are failing in the RelToSqlConverterTest.java file for Firebolt reason being the fact the actual parsed query does not contain the

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-03-28 Thread Raghav Sharma
Thank you for the clarification Julian. I will send a mail to dev-subscr...@calcite.apache.org for subscribing. On Tue, 29 Mar 2022 at 1:45 AM Julian Hyde wrote: > You did receive a response[1]. But you didn't receive it because you > are not subscribed to this list. Please subscribe[2]. > >

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-03-28 Thread Julian Hyde
You did receive a response[1]. But you didn't receive it because you are not subscribed to this list. Please subscribe[2]. Julian [1] https://lists.apache.org/thread/39obrhwpd95bvhc9sb2n4z6zrrwbc21x [2] https://calcite.apache.org/community/#mailing-lists On Mon, Mar 28, 2022 at 1:11 PM Raghav

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-03-28 Thread Raghav Sharma
Gentle reminder! We are expecting a response so that we can move ahead with this potential contribution. Thanks & Regards, Raghav Sharma | SDE 1 | Data Engineering M: +91 7087637086 I Mail: ragh...@sigmoidanalytics.com On Thu, Mar 24, 2022 at 3:47 PM Raghav Sharma

Re: Contributing a custom SQL dialect of Firebolt to Calcite

2022-03-24 Thread Julian Hyde
Raghav, Thanks for considering making a contribution. We should be able to resolve most questions on this list (if you haven’t already, please subscribe, so that your emails don’t need to go through moderation). Yes, we require a JIRA case for contributions except for cosmetic changes (e.g.

Contributing a custom SQL dialect of Firebolt to Calcite

2022-03-24 Thread Raghav Sharma
Greetings from Sigmoid and Firebolt! This mail is in reference towards contributing a custom sql dialect to Calcite. PFB some queries that we have regarding testing the dialect and further for contributing: 1. We have developed a SQL dialect for Firebolt. Need to test it against the database