[REVIEW REQUEST] CALCITE-5230 PERCENTILE_DISC return type derivation

2022-10-03 Thread Itiel Sadeh
Hello, I would like to request review for CALCITE-5230, which fixes the return type derivation of PERCENTILE_DISC. PR: https://github.com/apache/calcite/pull/2868 Ticket: https://issues.apache.org/jira/browse/CALCITE-5230 Thanks!

Re: Percentile_Disc return type

2022-08-07 Thread Julian Hyde
https://issues.apache.org/jira/browse/CALCITE-4670 < >>>> https://issues.apache.org/jira/browse/CALCITE-4670> ] and also to >> change >>>> the implementation strategy [ >>>> https://issues.apache.org/jira/browse/CALCITE-4666 < >>>> htt

Re: Percentile_Disc return type

2022-08-07 Thread Itiel Sadeh
Is PERCENTILE_DISC able to deduce return types from its arguments today? > >> If so, how does it do it? > >> > >> Julian > >> > >> > >>> On Aug 3, 2022, at 1:40 PM, Itiel Sadeh > > >> wrote: > >>> > >>> H

[jira] [Created] (CALCITE-5230) PERCENTILE_DISC return type derivation

2022-08-07 Thread Itiel Sadeh (Jira)
Itiel Sadeh created CALCITE-5230: Summary: PERCENTILE_DISC return type derivation Key: CALCITE-5230 URL: https://issues.apache.org/jira/browse/CALCITE-5230 Project: Calcite Issue Type: Bug

Re: Percentile_Disc return type

2022-08-05 Thread Julian Hyde
oday? >> If so, how does it do it? >> >> Julian >> >> >>> On Aug 3, 2022, at 1:40 PM, Itiel Sadeh >> wrote: >>> >>> Hello, >>> >>> First of all I just wanted to thank all of you for the work you are doing >>>

Re: Percentile_Disc return type

2022-08-05 Thread Itiel Sadeh
types from its arguments today? > If so, how does it do it? > > Julian > > > > On Aug 3, 2022, at 1:40 PM, Itiel Sadeh > wrote: > > > > Hello, > > > > First of all I just wanted to thank all of you for the work you are doing > > on Calcite. &g

Re: Percentile_Disc return type

2022-08-04 Thread Julian Hyde
ction, but we > encounter a problem. > Our percentile_disc return type is dependent on the column of the "order > by" clause (just like postgresql > <https://www.postgresql.org/docs/current/functions-aggregate.html>). > However, I don't see how to achieve th

Percentile_Disc return type

2022-08-03 Thread Itiel Sadeh
Hello, First of all I just wanted to thank all of you for the work you are doing on Calcite. We want to add support for the percentile_disc aggregate function, but we encounter a problem. Our percentile_disc return type is dependent on the column of the "order by" clause (just like