+1, thanks Julian for proposing this. From my observation, there are many
pending PRs in Calcite and only a few active committers, this puts a lot of
pressure on these committers. For example Julian have reviewed 34 PR in 2023
Q1, it is an unimaginable number. I am very supportive of achieving a
I for one would very much like to help with reviews. I don't have a lot of
time this month, but next month should have more time.
Best,
-- C
> On Apr 10, 2023, at 10:56 PM, Dan Zou wrote:
>
> +1, thanks Julian for proposing this. From my observation, there are many
> pending PRs in Calcite an
Thanks Julian for starting the discussion!
I'm spending my spare time to contribute to Calcite, usually at weekends,
and sometimes in the break of weekdays, hence my time would be limited
because the spare time may varies. Review work is not that simple for me
because Calcite has many complicated
Thank Julian for your idea.
Your plan helps to motivate new contributors.
“If there is no response to my PR,
I will be disappointed or even give up on continuing to contribute.”
I hope that every contributor will be encouraged,
and I also hope that the Calcite community will become stronger and
Thanks Julian for sharing the proposal. I am +1 for it. I have been busy in
the past few months, so I have only had a quick look at the new JIRA.
However, I will have more time in the coming months, and I would be more
than happy to review any pull requests.
Best,
Chunwei
On Tue, Apr 11, 2023
Hello,
I understand Julian's frustration. We all know that reviewing PRs is a
recurring problem, and it is not the first time we discuss potential
solutions, see e.g. the discussion a year ago [1] (also started by Julian)
where several ideas were mentioned: automatic assignment, emulate the RM
pro
For a long time this has been one of the main issues of the project
and I am happy to see discussions to address this issue.
I would like to mention that as a contributor, I am, and always have
been very grateful to people reviewing my work.
The fact that I became a committer of this project is ma
+1
I will likely participate in the effort of reviewing PRs when my schedule
allows it.
As pointed out in previous comments, some of us have a limited amount of time
available and few experience with certain areas of the codebase. One thing we
may experiment with is a shadow review process, si
Here are some stats around PRs merged in the calcite main branch in
the last quarter [2023-04-01, 2023-07-01). The stats are not 100%
accurate to cover reviews done under PRs/jira etc but clearly show
that we are quite far from what we have been discussing here.
+---+-+
Hi hongyu guo, The current Code reviews and feedback from the community are
a bit slow,we really need ways to encourage non-Commtier code review,faster
Code reviews and feedback enable others to participate more actively in the
community. Maybe the community could give some contributors permission
Sorry, the above email format is a little wrong. The current Code reviews
and feedback from the community are a bit slow,we really need ways to
encourage non-Commtier code review,faster Code reviews and feedback enable
others to participate more actively in the community. Maybe the community
could
Hello,
everybody is free to review PRs, it's in general a good way to become more
familiar with the codebase and gain "merit" for committership (like code
contributions, helping in the ML/Jira, etc.).
Even if a non committer review doesn't lead directly to code merge (you
still need a committer),
As a non-committer, I feel extremely glad and excited when my pull
request is merged into the main branch. I am not afraid of receiving
sharp feedback pointing out my mistakes, but I truly do not want to
see no one review my code.
Perhaps introducing a new tag, such as 'non-committer-review-accept
13 matches
Mail list logo
