[GitHub] camel pull request #2035: Fix the problem of instanceof test always return t...

2017-10-14 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2035 ---

[GitHub] camel pull request #2029: Fix the problem of instanceof test always return t...

2017-10-14 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2029 ---

[GitHub] camel pull request #2038: Replace the Number.valueOf method with the Number....

2017-10-13 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2038 Replace the Number.valueOf method with the Number.parseXXX method. It is more efficient to use the static parseXXX method to extract unboxed primitive value from a String. http

[GitHub] camel pull request #2035: Fix the problem of instanceof test always return t...

2017-10-13 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2035 Fix the problem of instanceof test always return true. This instanceof test will always return true because AbstractSObjectBase is the return type of method node.getObject(). The return

[GitHub] camel pull request #2031: Add the "final" modifier to a public static field.

2017-10-13 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2031 ---

[GitHub] camel pull request #2032: Remove the useless condition.

2017-10-13 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2032 ---

[GitHub] camel pull request #2032: Remove the useless condition.

2017-10-12 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2032 Remove the useless condition. The two conditional expressions always return true in their current control flow. They are useless. You can merge this pull request into a Git repository by

[GitHub] camel pull request #2031: Add the "final" modifier to a public static field.

2017-10-12 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2031 Add the "final" modifier to a public static field. This static field public but not final, and could be changed by malicious code or by accident from another package. The field cou

[GitHub] camel pull request #2029: Fix the problem of instanceof test always return t...

2017-10-12 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2029 Fix the problem of instanceof test always return true. If these variables are not null, their instanceof test always return true. They may be failed to be initialized, it would be better to

[GitHub] camel pull request #2025: Fix the problem of using '+' and '+=' operators to...

2017-10-12 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2025 ---

[GitHub] camel pull request #2025: Fix the problem of using '+' and '+=' operators to...

2017-10-11 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2025 Fix the problem of using '+' and '+=' operators to concatenate strings a in a loop. The method is building a String using concatenation in a loop. In each iteration, the

[GitHub] camel pull request #2016: Fix the problem of using '+' and '+=' operators to...

2017-10-11 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2016 ---

[GitHub] camel pull request #2023: Replace the inefficient Double constructor with st...

2017-10-11 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2023 ---

[GitHub] camel pull request #2024: Replace the keySet iterator with an entrySet itera...

2017-10-11 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2024 ---

[GitHub] camel pull request #2024: Replace the keySet iterator with an entrySet itera...

2017-10-11 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2024 Replace the keySet iterator with an entrySet iterator. The current source code accesses the value of a Map entry of methodMap, using a key that is retrieved from a keySet iterator. It is

[GitHub] camel pull request #2023: Replace the inefficient Double constructor with st...

2017-10-11 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2023 Replace the inefficient Double constructor with static Double.valueOf() method. Using new Double(double) is guaranteed to always result in a new object whereas Double.valueOf(double

[GitHub] camel pull request #2016: Fix the problem of using '+' and '+=' operators to...

2017-10-11 Thread BruceKuiLiu
GitHub user BruceKuiLiu reopened a pull request: https://github.com/apache/camel/pull/2016 Fix the problem of using '+' and '+=' operators to concatenate strings in a loop. The method is building a String using concatenation in a loop. In each iter

[GitHub] camel pull request #2017: Add an IfStatement to check the return value of ex...

2017-10-11 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2017 ---

[GitHub] camel pull request #2016: Fix the problem of using '+' and '+=' operators to...

2017-10-11 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2016 ---

[GitHub] camel pull request #2017: Add an IfStatement to check the return value of ex...

2017-10-09 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2017 Add an IfStatement to check the return value of executor.submit(task). This statement returns a value that is not checked. The return value should be checked since it can indicate an unusual

[GitHub] camel pull request #2016: Fix the problem of using '+' and '+=' operators to...

2017-10-09 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2016 Fix the problem of using '+' and '+=' operators to concatenate strings in a loop. …s in a loop. The method is building a String using concatenation in a loop.

[GitHub] camel pull request #2015: Fix the problem of concatenating strings using + i...

2017-10-09 Thread BruceKuiLiu
Github user BruceKuiLiu closed the pull request at: https://github.com/apache/camel/pull/2015 ---

[GitHub] camel pull request #2015: Fix the problem of concatenating strings using + i...

2017-10-09 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2015 Fix the problem of concatenating strings using + in a loop. The method is building a String using concatenation in a loop. In each iteration, the String is converted to a StringBuilder