Re: [HEADS UP] - File component changes in Camel 2.0

2009-02-02 Thread Aaron Crickenberger
On a slightly related tangent, I'm partly responsible for the hackish code in FileConsumer's (old) isUnchanged() method ( https://issues.apache.org/activemq/browse/CAMEL-250). Camel 1.5's exclusiveReadLock feature is unfortunately still picking up files too early, so I have to fall back to the

Re: [HEADS UP] - File component changes in Camel 2.0

2009-02-02 Thread Claus Ibsen
Hi Yeah please take a look at the GenericFileExclusiveReadLockStrategy and see if you can implement it as a implementation of this interface? Then it can be added into camel 2.0 as an other option to choose. But beware that the code in trunk is currently have 2 file components. FileComponent is

Re: [HEADS UP] - File component changes in Camel 2.0

2009-02-02 Thread Claus Ibsen
On Fri, Jan 30, 2009 at 5:40 PM, Aaron Crickenberger aaron.crickenber...@intalgent.com wrote: I would hesitate if only because requiring a particular header seems off, are there other components that do the same? I haven't looked much at Camel 2.0's code, but it looks like camel-1.x's file

Re: [HEADS UP] - File component changes in Camel 2.0

2009-01-30 Thread Jon Anstey
Yeah, great work on all the improvements to the file component Claus. I think it will warrant a blog post of its own when Camel 2.0 comes out :) Not sure about this suggestion though... I kinda like having defaults in place so you don't always have to provide configuration. Like, having a default

Re: [HEADS UP] - File component changes in Camel 2.0

2009-01-30 Thread James Strachan
So long as files are written in some directory and they are unique and preserve order - does it matter if they are generated (from the message ID say) or the user explicitly gives some name? Like Jon I'd be tempted ot leave the default behaviour? 2009/1/30 Claus Ibsen claus.ib...@gmail.com: Hi

Re: [HEADS UP] - File component changes in Camel 2.0

2009-01-30 Thread Aaron Crickenberger
I would hesitate if only because requiring a particular header seems off, are there other components that do the same? I haven't looked much at Camel 2.0's code, but it looks like camel-1.x's file component's expression property could support both scenarios. Use a default ${id} expression, but

[HEADS UP] - File component changes in Camel 2.0

2009-01-29 Thread Claus Ibsen
Hi As some of you know the file component have had a major refactor ... actually you can nearly consider it as a rewrite in Camel 2.0. This mail is about a few remaining issues I want to give a heads up upon and feedback: Force a filename to be provided when wring a file