Re: Health Check API

2017-09-19 Thread Luca Burgazzoli
Good catch, will change it --- Luca Burgazzoli On Tue, Sep 19, 2017 at 3:07 PM, Claus Ibsen wrote: > Hi > > Thanks the health mbean looks good. > > However I wonder if using a date is the right type for "interval" > https://github.com/lburgazzoli/apache-camel/blob/CAMEL-10026-hc/camel-core/src/

Re: Health Check API

2017-09-19 Thread Claus Ibsen
Hi Thanks the health mbean looks good. However I wonder if using a date is the right type for "interval" https://github.com/lburgazzoli/apache-camel/blob/CAMEL-10026-hc/camel-core/src/main/java/org/apache/camel/api/management/mbean/CamelOpenMBeanTypes.java#L251 Is interval a specific date, eg 20

Re: Health Check API

2017-09-19 Thread Luca Burgazzoli
Hi Claus, the branch is still [1] and the management parts is in api/management [2]. [1] https://github.com/lburgazzoli/apache-camel/tree/CAMEL-10026-hc [2] https://github.com/lburgazzoli/apache-camel/tree/CAMEL-10026-hc/camel-core/src/main/java/org/apache/camel/api/management --- Luca Burgazzol

Re: Health Check API

2017-09-19 Thread Claus Ibsen
On Tue, Sep 19, 2017 at 2:22 PM, Luca Burgazzoli wrote: > Hello, > > I've added some info through JMX, would you mind review it before merging ? > Can you post the link to the branch where those latest code changes are > Regards, > Luca > > > --- > Luca Burgazzoli > > > On Fri, Sep 8, 2017 at 4:

Re: Health Check API

2017-09-19 Thread Luca Burgazzoli
Hello, I've added some info through JMX, would you mind review it before merging ? Regards, Luca --- Luca Burgazzoli On Fri, Sep 8, 2017 at 4:20 PM, Luca Burgazzoli wrote: > Hello, > > I've just pushed some bits to my fork to cleanup the implementation > and implement some basic checks for r

Re: Health Check API

2017-09-08 Thread Luca Burgazzoli
Hello, I've just pushed some bits to my fork to cleanup the implementation and implement some basic checks for routes status. In addition, to make it suitable to be included in camel 2.20, I've reduced the scope of the implementation to be almost limited to core/internal health checks and to provi

Re: Health Check API

2017-09-05 Thread Luca Burgazzoli
--- Luca Burgazzoli On Tue, Sep 5, 2017 at 2:17 PM, Claus Ibsen wrote: > Hi Luca > > Looks really good. > > There is a few typo's and the likes in the source code I looked at. > Will try to do a github comment so you can see them as well later, or > when the code is merged later. > > 1) > For th

Re: Health Check API

2017-09-05 Thread Claus Ibsen
On Mon, Sep 4, 2017 at 4:01 PM, Luca Burgazzoli wrote: > Hello, > > I've been working a little on the Health Check API [1] implementation an > the code is available in my Apache Camel fork [2]. There is now a a new > package [3] that defines the following concepts: > > - HealthCheck > > this rep

Re: Health Check API

2017-09-05 Thread Claus Ibsen
Hi Luca Looks really good. There is a few typo's and the likes in the source code I looked at. Will try to do a github comment so you can see them as well later, or when the code is merged later. 1) For the doCall implementation when you implement a health check, then what would happen if that m

Re: Health Check API

2017-09-04 Thread Luca Burgazzoli
Correct spring boot here is used for demonstration purpose only to make it easy to configure health checks and to consume them using i.e. curl but the core check is pure camel :) --- Luca Burgazzoli On Mon, Sep 4, 2017 at 5:16 PM, Claus Ibsen wrote: > Hi Luca > > I will take a closer look tomor

Re: Health Check API

2017-09-04 Thread Claus Ibsen
Hi Luca I will take a closer look tomorrow, I just peaked a bit today. Just to be sure, the implementation of the logic that performs the actual health check is agnostic? i.e. its not tied to must be using Spring Boot. And that logic is if possible reusing the "ping check" (i.e. verifier extensio