Okay a bit weird it does that, as there is no instructions in the
pom.xml about that for it.
I would assume we should have
provided
For the spi-annotations in the pom.xml so its not on the transitive
list as its embedded and not needed.
On Wed, Aug 28, 2013 at 8:09 AM, Willem jiang wrote:
> Al
All the tests except the ones in camel-core were failed.
We don't need to install the spi-annotations bundle as the classes are shade
into camel-core by the bnd plugin.
--
Willem Jiang
Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.
Which tests is failing? That seems odd as the .class is just added to
camel-core?
We need to find a solution as the JAR must be on the classpath. And
for OSGi its not possible as its not an OSGi bundle.
On Wed, Aug 28, 2013 at 3:01 AM, Willem jiang wrote:
> spi-annotations is already shaded into
spi-annotations is already shaded into camel-core by bnd plugin, we don't need
to use the shaded plugin to do this kind of job.
So I just revert the change for camel-2.12.0 release.
--
Willem Jiang
Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemji
Lots of tests failed with this change, I'm trying to figure a solution for it
now.
BTW, it is not the good practice to shade the jars with the same package.
--
Willem Jiang
Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/)
(Engl
cool, it sounds good.
I will double check the change later today.
--
Willem Jiang
Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/)
(English)
http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Hi
The shading seems to work fine. I have committed a change to master.
On Tue, Aug 27, 2013 at 12:34 PM, Claus Ibsen wrote:
> Hi
>
> Logged a ticket
> https://issues.apache.org/jira/browse/CAMEL-6673
>
> Looks like shading works nicely. I will give it a test spin before
> committing any changes
Hi
Logged a ticket
https://issues.apache.org/jira/browse/CAMEL-6673
Looks like shading works nicely. I will give it a test spin before
committing any changes. But the .class files get included in
camel-core and available for everybody now.
On Tue, Aug 27, 2013 at 12:26 PM, Claus Ibsen wrote:
>
Hi
I wonder if we can shade spi-annotations into the camel-core module,
so its included out of the box?
As they are needed at runtime, for example by components extending
UriEndpointComponent etc.
If not we should IMHO have it as required dependency and would need
for it to be an OSGi bundle, and
Sounds good. I will give it another try with Java 7 and make sure
appropriate profiles get enabled.
Thanks Babak!
On Saturday, August 17, 2013, Babak Vahdat wrote:
> Aha now I see, well if you make use of Java 7 and IntelliJ can't handle
> this
> then that sounds like a IntelliJ bug to me becaus
Aha now I see, well if you make use of Java 7 and IntelliJ can't handle this
then that sounds like a IntelliJ bug to me because in that case the apt
profile IS enabled and IntelliJ should take the apt module dependency into
account like any other POM dependencies. There was also a user reporting th
Very interesting. That sounds like lots of headaches, so keeping optional
is fine if it solves that.
I was just noticing in Intellij that it couldn't compile camel-sql because
it didn't bring in that dependency since it was marked optional. But that's
an easy headache to fix compared to the ones yo
Hi Christian,
I think having the optional flag set to true is indeed good as we used to
have problems to build & run the tests using Java 6 profile on the
CI-Server, e.g. the profile "Camel.trunk.fulltest". See also here:
https://github.com/apache/camel/blob/master/components/pom.xml#L221
Also n
Apply this for the fix :)
diff --git a/camel-core/pom.xml b/camel-core/pom.xml
index cd2f201..7409c90 100755
--- a/camel-core/pom.xml
+++ b/camel-core/pom.xml
@@ -99,7 +99,6 @@
org.apache.camel
spi-annotations
${project.version}
- true
On Fri, Aug 16, 201
14 matches
Mail list logo
