Re: Spring and Spring Boot upgrades

Hi Cameleers, the release notes mention that the deprecated methods were removed in 2.1[1], I don't recall seeing that we use any of those. So other than the change when loading configurations via @SpringBootTest I haven't found any other differences, zoran [1] https://github.com/spring-projects/

Re: Spring and Spring Boot upgrades

FWIW I'm currently using camel 2.22.1 with boot 2.1 without any problems Den man. 5. nov. 2018, 16:04 skrev Claus Ibsen : > Hi > > Thanks the PR has been merged so Camel 2.23 supports Spring Boot 2.1. > I wonder if on top of your head / anyone else knows if that upgrade > means Spring Boot 2.0.x

Re: Spring and Spring Boot upgrades

Hi Thanks the PR has been merged so Camel 2.23 supports Spring Boot 2.1. I wonder if on top of your head / anyone else knows if that upgrade means Spring Boot 2.0.x is not supported / incompatible. Just in case someone tries to use Camel 2.23 with Spring Boot 2.0.x. And if we know this ahead of t

Re: Spring and Spring Boot upgrades

spring-cloud is actually at 2.0.2.RELEASE where possible. -- Andrea Cosentino  -- Apache Camel PMC Chair Apache Karaf Committer Apache Servicemix PMC Member Email: ancosen1...@yahoo.com Twitter: @oscerd2 Github: oscerd On Friday, November 2, 2018, 11:52:30 AM

Re: Spring and Spring Boot upgrades

Is the spring-cloud dep up to date ? there may be incompatibility --- Luca Burgazzoli On Fri, Nov 2, 2018 at 11:31 AM Zoran Regvart wrote: > > Hi Claus, > both are defined in `spring-cloud-consul`[1][2], looks like they > should both have @ConditionalOnMissingBean. What puzzles me is that it > w

Re: Spring and Spring Boot upgrades

Hi Claus, both are defined in `spring-cloud-consul`[1][2], looks like they should both have @ConditionalOnMissingBean. What puzzles me is that it worked before the upgrade, perhaps the order of beans changed? I think this needs to be fixed in `spring-cloud-consul`, though it could point to a incom

Re: Spring and Spring Boot upgrades

Hi This seems like a bit weird error. Is that heartbeatProperties something that is inherited from spring-boot itself or where does it come from? And would a fix be to add @ConditionalOnMissingBean on both of them? On Wed, Oct 31, 2018 at 3:54 PM Zoran Regvart wrote: > > Hi Cameleers, > there a

Re: Spring and Spring Boot upgrades

Hi Cameleers, there are test failures in the `camel-spring-cloud-consul`[1], to me it seems like an issue with Spring Boot auto-configuration: `ConsulDiscoveryClientConfiguration::heartbeatProperties` and `ConsulServiceRegistryAutoConfiguration::heartbeatProperties` try to define the same bean, whe

Re: Spring and Spring Boot upgrades

Hi Cameleers, looks like the build succeeded, but is hanging for some reason (could be infrastructure related, not sure): https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/spring-upgrades/1/console zoran On Tue, Oct 30, 2018 at 4:19 PM, Zoran Regvart wrote: > Hi Cameleers, > I'

Re: Spring and Spring Boot upgrades

Hi David, you can see it here: https://gist.github.com/zregvart/0581388eb6021c0b22eaeb5e19150579 I fiddled with configuration classes loaded, but that test really made no sense to me, it seemed to me that it was exercising ApplicationContextRunner not something Camel related at all... zoran On

Re: Spring and Spring Boot upgrades

Do you remember which error message you got with the test? Den tir. 30. okt. 2018 kl. 16:19 skrev Zoran Regvart : > Hi Cameleers, > I've tinkered with Spring (5.1.2) and Spring Boot (2.1.0) upgrades, > any comments welcome: > > https://github.com/apache/camel/pull/2584 > > zoran > -- > Zoran Regv

Spring and Spring Boot upgrades

Hi Cameleers, I've tinkered with Spring (5.1.2) and Spring Boot (2.1.0) upgrades, any comments welcome: https://github.com/apache/camel/pull/2584 zoran -- Zoran Regvart