Re: The Maven sourcecheck Profile not breaking the build anymore...

+1 for formatter-maven-plugin. That's the most painless source formatting approach I have seen so far. There is no need to do anything, it just works. They have it in Quarkus [1] and I like it very much. The drawback of the present non-enforcing approach is that people forget (my case) about c

Re: The Maven sourcecheck Profile not breaking the build anymore...

Thanks John. Babak > Am 10.10.2019 um 09:26 schrieb John Poth : > > 'mvn clean install -Psourcecheck -Dcheckstyle.failOnViolation=true' will > make the build fail on checkstyle errors > >> On Wed, Oct 9, 2019 at 5:23 PM Andrea Cosentino wrote: >> >> Yeah. It would be helpful Guillaume. >> >>

Re: The Maven sourcecheck Profile not breaking the build anymore...

'mvn clean install -Psourcecheck -Dcheckstyle.failOnViolation=true' will make the build fail on checkstyle errors On Wed, Oct 9, 2019 at 5:23 PM Andrea Cosentino wrote: > Yeah. It would be helpful Guillaume. > > Il mer 9 ott 2019, 17:21 Guillaume Nodet ha scritto: > > > IIRC, I've seen some pro

Re: The Maven sourcecheck Profile not breaking the build anymore...

Yeah. It would be helpful Guillaume. Il mer 9 ott 2019, 17:21 Guillaume Nodet ha scritto: > IIRC, I've seen some projects where a plugin would automatically reformat > the source code if needed, see > https://github.com/revelc/formatter-maven-plugin > That could be a way to help easily / transpa

Re: The Maven sourcecheck Profile not breaking the build anymore...

IIRC, I've seen some projects where a plugin would automatically reformat the source code if needed, see https://github.com/revelc/formatter-maven-plugin That could be a way to help easily / transparently enforcing the rules ... Le mer. 9 oct. 2019 à 16:55, Andrea Cosentino a écrit : > This was

Re: The Maven sourcecheck Profile not breaking the build anymore...

For the moment I set the corresponding flag locally to true in order to achieve what I’m after: https://github.com/apache/camel/blob/master/parent/pom.xml#L5372 Maybe we can also define another profile which would do strict sour

Re: The Maven sourcecheck Profile not breaking the build anymore...

To be honest, I am not a fan of breaking the build due to a failing sourcecheck, especially is not something related to tests or whatever as Andrea mentioned that can be very strict to break. On Wed, 9 Oct 2019 at 16:55, Andrea Cosentino wrote: > This was deliberately done if I remember correctl

Re: The Maven sourcecheck Profile not breaking the build anymore...

This was deliberately done if I remember correctly. It is too strict to break the build for checkstyle. I don't know what others think about it Il mer 9 ott 2019, 16:51 Babak Vahdat ha scritto: > Hi > > AFAIR building Camel source using the sourcecheck Profile enabled used to > break the build i

The Maven sourcecheck Profile not breaking the build anymore...

Hi AFAIR building Camel source using the sourcecheck Profile enabled used to break the build if there was any Checkstyle issue: mvn clean install -Psourcecheck However currently when there’s a Checkstyle issue the build doesn’t seem to break for me, instead I see [INFO] Starting audit... [ERR