Re: spi-annotations

2013-08-27 Thread Claus Ibsen
Okay a bit weird it does that, as there is no instructions in the pom.xml about that for it. I would assume we should have provided For the spi-annotations in the pom.xml so its not on the transitive list as its embedded and not needed. On Wed, Aug 28, 2013 at 8:09 AM, Willem jiang wrote

Re: spi-annotations

2013-08-27 Thread Willem jiang
All the tests except the ones in camel-core were failed. We don't need to install the spi-annotations bundle as the classes are shade into camel-core by the bnd plugin. -- Willem Jiang Red Hat, Inc. Web: http://www.redhat.com Blog: http://willemjiang.blogspot.com

Re: spi-annotations

2013-08-27 Thread Claus Ibsen
Which tests is failing? That seems odd as the .class is just added to camel-core? We need to find a solution as the JAR must be on the classpath. And for OSGi its not possible as its not an OSGi bundle. On Wed, Aug 28, 2013 at 3:01 AM, Willem jiang wrote: > spi-annotations is already sha

Re: spi-annotations

2013-08-27 Thread Willem jiang
spi-annotations is already shaded into camel-core by bnd plugin, we don't need to use the shaded plugin to do this kind of job. So I just revert the change for camel-2.12.0 release. -- Willem Jiang Red Hat, Inc. Web: http://www.redhat.com Blog: http://willemjiang.blogspot.com

Re: spi-annotations

2013-08-27 Thread Willem jiang
changes. But the .class files get included in > > camel-core and available for everybody now. > > > > On Tue, Aug 27, 2013 at 12:26 PM, Claus Ibsen > (mailto:claus.ib...@gmail.com)> wrote: > > > Hi > > > > > > I wonder if we can shade spi-an

Re: spi-annotations

2013-08-27 Thread Willem jiang
ybody now. > > > > On Tue, Aug 27, 2013 at 12:26 PM, Claus Ibsen > (mailto:claus.ib...@gmail.com)> wrote: > > > Hi > > > > > > I wonder if we can shade spi-annotations into the camel-core module, > > > so its included out of the box? > > >

Re: spi-annotations

2013-08-27 Thread Claus Ibsen
e > committing any changes. But the .class files get included in > camel-core and available for everybody now. > > On Tue, Aug 27, 2013 at 12:26 PM, Claus Ibsen wrote: >> Hi >> >> I wonder if we can shade spi-annotations into the camel-core module, >> so its included

Re: spi-annotations

2013-08-27 Thread Claus Ibsen
: > Hi > > I wonder if we can shade spi-annotations into the camel-core module, > so its included out of the box? > As they are needed at runtime, for example by components extending > UriEndpointComponent etc. > > If not we should IMHO have it as required dependency and woul

Re: spi-annotations

2013-08-27 Thread Claus Ibsen
Hi I wonder if we can shade spi-annotations into the camel-core module, so its included out of the box? As they are needed at runtime, for example by components extending UriEndpointComponent etc. If not we should IMHO have it as required dependency and would need for it to be an OSGi bundle

Re: spi-annotations

2013-08-17 Thread Christian Posta
own "import" functionality solved the problem for him: > > > http://camel.465427.n5.nabble.com/About-the-spi-annotations-dependency-tp5736873p5737084.html > > And that's also what we've got on the Wiki as well: > > http://camel.apache.org/building.html#Building

Re: spi-annotations

2013-08-17 Thread Babak Vahdat
rting the same problem with IntelliJ. Using the maven-idea-plugin instead of IntelliJ's own "import" functionality solved the problem for him: http://camel.465427.n5.nabble.com/About-the-spi-annotations-dependency-tp5736873p5737084.html And that's also what we've

Re: spi-annotations

2013-08-17 Thread Christian Posta
ot;Camel.trunk.fulltest". See also here: > > https://github.com/apache/camel/blob/master/components/pom.xml#L221 > > Also note that the apt module by itself brings a transitive dependency to > spi-annotations: > > https://github.com/apache/camel/blob/master/tooling/apt/p

Re: spi-annotations

2013-08-17 Thread Babak Vahdat
xml#L221 Also note that the apt module by itself brings a transitive dependency to spi-annotations: https://github.com/apache/camel/blob/master/tooling/apt/pom.xml#L43 So I guess removing that optional flag would cause the same problems again, see also this thread: http://camel.465427.n5.nabble.

Re: spi-annotations

2013-08-16 Thread Christian Posta
Apply this for the fix :) diff --git a/camel-core/pom.xml b/camel-core/pom.xml index cd2f201..7409c90 100755 --- a/camel-core/pom.xml +++ b/camel-core/pom.xml @@ -99,7 +99,6 @@ org.apache.camel spi-annotations ${project.version} - true On Fri, Aug 16

spi-annotations

2013-08-16 Thread Christian Posta
So in camel-core, the spi-annotations dependency is marked "optional" in the pom. org.apache.camel spi-annotations ${project.version} true But is it optional? Seems to be used in some of the core components, so should be there, right? -- *Chris

Re: About the spi-annotations dependency

2013-08-10 Thread Zemian Deng
t; check. > >> > > >> > > >> > > >> > On Sat, Aug 10, 2013 at 3:08 AM, Willem jiang < > > > willem.jiang@ > > > > >wrote: > >> > > >> >> > >> >> How about add the spi-annotation dep

Re: About the spi-annotations dependency

2013-08-10 Thread Babak Vahdat
>> >> Red Hat, Inc. >> >> FuseSource is now part of Red Hat >> >> Web: http://www.fusesource.com | http://www.redhat.com >> >> Blog: http://willemjiang.blogspot.com >> (http://willemjiang.blogspot.com/ >> ) >> >> (Englis

Re: About the spi-annotations dependency

2013-08-10 Thread Zemian Deng
gt; Willem Jiang > >> > >> Red Hat, Inc. > >> FuseSource is now part of Red Hat > >> Web: http://www.fusesource.com | http://www.redhat.com > >> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/ > ) > >> (English) > >&

Re: About the spi-annotations dependency

2013-08-10 Thread Babak Vahdat
http://www.redhat.com >> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) >> (English) >> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese) >> Twitter: willemjiang >> Weibo: 姜宁willem >> >> >> >> >

Re: About the spi-annotations dependency

2013-08-10 Thread Zemian Deng
st 7, 2013 at 9:01 AM, saltnlight5 wrote: > > > Hi, > > > > I have a question on camel pom usage. > > > > In camel-core/pom.xml, the spi-annotations dependency is added as > > true, however other modules such as > camel-jms/pom.xml > > do not include t

Re: About the spi-annotations dependency

2013-08-10 Thread Willem jiang
) http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Wednesday, August 7, 2013 at 9:01 AM, saltnlight5 wrote: > Hi, > > I have a question on camel pom usage. > > In camel-core/pom.xml, the spi-annotations dependency is

Re: About the spi-annotations dependency

2013-08-08 Thread Zemian Deng
Proper pom.xm should let IDE automatically do that without manually adding classpath. Either add spi-annotations to camel-core as non-optional, or have any other modules declare it explicitly. I think more puzzling to me is how come running maven on command line works fine? On Thu, Aug 8, 2013

Re: About the spi-annotations dependency

2013-08-08 Thread Devendra Khanolkar
Do you have the latest build? I had a similar problem but a quick way to get around this is just to add the spi-annotations.jar manually in the project classpath. And yes the UriParam annotation is derived from that spi-annotations jar. Thanks. Dev. Sent from my iPad On 07/08/2013, at 11

About the spi-annotations dependency

2013-08-06 Thread saltnlight5
Hi, I have a question on camel pom usage. In camel-core/pom.xml, the spi-annotations dependency is added as true, however other modules such as camel-jms/pom.xml do not include this dependency explicitly. Is that intentional? How does camel-jms resolve this spi-annotations jar if it's