Re: [VOTE] Apache CarbonData 1.5.1(RC2) release

2018-12-02 Thread kanaka
+1 I think CARBONDATA-3116 is not introduced in 1.5.1 & As Ravindra mentioned, If currently it is not intended for end users, we can discuss and optimize configuration in next version About the apache commons logging in TableDataMap.java#L78, as we verified our local cluster required messages st

Re: [VOTE] Apache CarbonData 1.5.1(RC2) release

2018-12-02 Thread Kumar Vishal
+1 Regards Kumar Vishal On Mon, 3 Dec 2018 at 12:59, ravipesala wrote: > Hi, > > @Xubo Regarding your PR, the property is used only for internal test > purpose > not to expose outside. I don't see any impact on any feature or on the > current release. We have given enough time between RC1 and RC

Re: [VOTE] Apache CarbonData 1.5.1(RC2) release

2018-12-02 Thread ravipesala
Hi, @Xubo Regarding your PR, the property is used only for internal test purpose not to expose outside. I don't see any impact on any feature or on the current release. We have given enough time between RC1 and RC2 releases to consider and merge all necessary PRs. Please consult the release manage

RE: [Discussion] Bloom memory and pruning optimisation using hierarchical pruning.

2018-12-02 Thread ravipesala
Hi xuchuanyin, 1. There is no need to maintain separate bloom configurations for task level bloom as we use same configuration (size and fpp) provided by user. We just create task level bloom with the same configuration along with blocklet bloom. 2. Size of bloom is much smaller compared to block

Re: [VOTE] Apache CarbonData 1.5.1(RC2) release

2018-12-02 Thread manish gupta
+1 Regards Manish Gupta On Mon, 3 Dec 2018 at 12:22 PM, Jacky Li wrote: > I think there are other places that are using apache-common-log, like > https://github.com/apache/carbondata/blob/382ce430a18ca3d7d0b444777c66591e2c2e705f/hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputF

Re: [VOTE] Apache CarbonData 1.5.1(RC2) release

2018-12-02 Thread Jacky Li
I think there are other places that are using apache-common-log, like https://github.com/apache/carbondata/blob/382ce430a18ca3d7d0b444777c66591e2c2e705f/hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java#L103 Since this is not introduced in this version, I think it is OK

Re: [VOTE] Apache CarbonData 1.5.1(RC2) release

2018-12-02 Thread xubo245
@jackylk @ravipesala @KanakaKumar @kunal642 https://github.com/apache/carbondata/pull/2940 is a bug, please check it. -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: Is HDFS is mandatory for Carbon Data while creating table?

2018-12-02 Thread xubo245
not mandatory。 CarbonData support local file system,HDFS and S3(Huawei OBS) There are some examples, for example:./carbondata/examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nab