[GitHub] incubator-carbondata pull request #207: [CARBONDATA-283] VT enhancement for ...

2016-11-03 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/207#discussion_r86347851 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonTableStatusUtil.java --- @@ -0,0 +1,92

[GitHub] incubator-carbondata pull request #241: [CARBONDATA-319] Bad Records logging...

2016-10-16 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/241#discussion_r83584798 --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java

[GitHub] incubator-carbondata pull request #237: [CARBONDATA-317] - CSV having only s...

2016-10-16 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/237#discussion_r83584249 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/csv/CarbonCsvRelation.scala --- @@ -148,6 +150,10 @@ case class

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-10-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81474992 --- Diff: format/src/main/thrift/schema.thrift --- @@ -124,6 +124,7 @@ struct TableSchema{ 1: required string table_id; // ID used to

[GitHub] incubator-carbondata pull request #190: [CARBONDATA-268]Improve carbonoptimi...

2016-09-23 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/190#discussion_r80220071 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala --- @@ -68,9 +70,50 @@ object CarbonOptimizer

[GitHub] incubator-carbondata pull request #190: [CARBONDATA-268]Improve carbonoptimi...

2016-09-23 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/190#discussion_r80220168 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala --- @@ -397,20 +452,38 @@ class

[GitHub] incubator-carbondata pull request #194: [CARBONDATA-270] Double data type va...

2016-09-23 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/194#discussion_r80221140 --- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java --- @@ -1401,8 +1401,7 @@ public static void logError(Throwable

[GitHub] incubator-carbondata pull request #190: [CARBONDATA-268]Improve carbonoptimi...

2016-09-23 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/190#discussion_r80219989 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala --- @@ -68,9 +70,50 @@ object CarbonOptimizer

[GitHub] incubator-carbondata pull request #190: [CARBONDATA-268]Improve carbonoptimi...

2016-09-23 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/190#discussion_r80219576 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala --- @@ -87,20 +130,32 @@ class

[GitHub] incubator-carbondata pull request #158: [CARBONDATA-241]Fixed out of memory ...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/158#discussion_r79290374 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -102,7 +115,7 @@ class CarbonScanRDD[V

[GitHub] incubator-carbondata pull request #158: [CARBONDATA-241]Fixed out of memory ...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/158#discussion_r79290196 --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/ft/CarbonInputMapperTest.java --- @@ -129,6 +132,37 @@ private int

[GitHub] incubator-carbondata pull request #158: [CARBONDATA-241]Fixed out of memory ...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/158#discussion_r79290267 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -706,8 +725,9 @@ private String getUpdateExtension

[GitHub] incubator-carbondata pull request #161: [CARBONDATA-246] compaction is wrong...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/161#discussion_r79289289 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -102,6 +102,11 @@ class

[GitHub] incubator-carbondata pull request #161: [CARBONDATA-246] compaction is wrong...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/161#discussion_r79289428 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -259,6 +253,9 @@ class

[GitHub] incubator-carbondata pull request #161: [CARBONDATA-246] compaction is wrong...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/161#discussion_r79289444 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -280,6 +277,25 @@ class

[GitHub] incubator-carbondata pull request #158: [CARBONDATA-241]Fixed out of memory ...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/158#discussion_r79288466 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/BlockIndexStore.java --- @@ -260,11 +295,29 @@ public void

[GitHub] incubator-carbondata pull request #168: [CARBONDATA-251] making the auto com...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/168#discussion_r79287073 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -623,14 +623,7 @@ object

[GitHub] incubator-carbondata pull request #168: [CARBONDATA-251] making the auto com...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/168#discussion_r79287134 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -1030,28 +1021,36 @@ object

[GitHub] incubator-carbondata pull request #168: [CARBONDATA-251] making the auto com...

2016-09-17 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/168#discussion_r79287056 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -920,7 +920,7 @@ * Default value

[GitHub] incubator-carbondata pull request #158: [CARBONDATA-241]Fixed out of memory ...

2016-09-16 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/158#discussion_r79222167 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -101,6 +106,8 @@ //comma separated list of

[GitHub] incubator-carbondata pull request #155: [CARBONDATA-239] Handling the except...

2016-09-16 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/155#discussion_r79208835 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -590,16 +605,25 @@ object

[GitHub] incubator-carbondata pull request #158: [CARBONDATA-241]Fixed out of memory ...

2016-09-15 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/158#discussion_r79008577 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala --- @@ -20,20 +20,13 @@ package

[GitHub] incubator-carbondata pull request #158: [CARBONDATA-241]Fixed out of memory ...

2016-09-15 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/158#discussion_r79003748 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java --- @@ -102,6 +91,60 @@ public long

[GitHub] incubator-carbondata pull request #135: [CARBONDATA-226]changing the error m...

2016-09-07 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/135#discussion_r77953863 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -931,11 +931,11 @@ private

[GitHub] incubator-carbondata pull request #140: [CARBONDATA-227] In block distributi...

2016-09-07 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/140#discussion_r77950786 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -110,13 +110,15 @@ class CarbonScanRDD

[GitHub] incubator-carbondata pull request #140: [CARBONDATA-227] In block distributi...

2016-09-07 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/140#discussion_r77950753 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -73,7 +73,7 @@ class CarbonScanRDD[V

[GitHub] incubator-carbondata pull request #137: [CARBONDATA-222] Handled query issue...

2016-09-07 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/137#discussion_r77950155 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/impl/btree/BTreeDataRefNodeFinder.java --- @@ -240,9 +240,16

[GitHub] incubator-carbondata pull request #139: [CARBONDATA-224]Fixed data mismatch ...

2016-09-07 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/139#discussion_r77947424 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala --- @@ -864,8 +864,8 @@ class CarbonSqlParser

[GitHub] incubator-carbondata pull request #116: [CARBONDATA-198] System level lock f...

2016-09-01 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/116#discussion_r77129488 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -400,43 +631,36 @@ object

[GitHub] incubator-carbondata pull request #116: [CARBONDATA-198] System level lock f...

2016-09-01 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/116#discussion_r77129093 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -333,7 +531,7 @@ object

[GitHub] incubator-carbondata pull request #116: [CARBONDATA-198] System level lock f...

2016-09-01 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/116#discussion_r77128213 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -297,15 +366,144 @@ object

[GitHub] incubator-carbondata pull request #116: [CARBONDATA-198] System level lock f...

2016-09-01 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/116#discussion_r77127755 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -297,15 +366,144 @@ object

[GitHub] incubator-carbondata pull request #116: [CARBONDATA-198] System level lock f...

2016-08-31 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/116#discussion_r77044909 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -904,6 +904,27

[GitHub] incubator-carbondata pull request #116: [CARBONDATA-198] System level lock f...

2016-08-31 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/116#discussion_r77044027 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -344,49 +540,77 @@ object

[GitHub] incubator-carbondata pull request #107: [CARBONDATA-191]Fix bug when quote c...

2016-08-31 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/107#discussion_r77038851 --- Diff: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithSingleQuotechar.scala

[GitHub] incubator-carbondata pull request #111: [CARBONDATA-194] ArrayIndexOfBoundEx...

2016-08-31 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/111#discussion_r76946838 --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java --- @@ -41,6 +41,10 @@ public

[GitHub] incubator-carbondata pull request #111: [CARBONDATA-194] ArrayIndexOfBoundEx...

2016-08-31 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/111#discussion_r76936740 --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java --- @@ -104,6 +108,20 @@ public

[GitHub] incubator-carbondata pull request #87: [CARBONDATA-171] Block distribution n...

2016-08-23 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/87#discussion_r75907088 --- Diff: integration/spark/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java --- @@ -1204,12 +1208,14 @@ private static

[GitHub] incubator-carbondata pull request #71: CARBONDATA-155 Code refactor to avoid...

2016-08-15 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/71#discussion_r74879445 --- Diff: core/src/main/java/org/carbondata/core/carbon/datastore/block/Distributable.java --- @@ -19,7 +19,7 @@ /** * Abstract