[GitHub] incubator-carbondata pull request #323: Fix codestyle in CarbonExample

2016-11-16 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/incubator-carbondata/pull/323 Fix codestyle in CarbonExample Fix codestyle in CarbonExample You can merge this pull request into a Git repository by running: $ git pull https://github.com/jackylk/incubator

[GitHub] incubator-carbondata issue #262: [CARBONDATA-308] Use CarbonInputFormat in C...

2016-11-13 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/incubator-carbondata/pull/262 CI testing http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/609/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r87716151 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -130,41 +130,27 @@ public static CarbonTable

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r87716124 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -244,68 +195,40 @@ class CarbonScanRDD[V

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r87716097 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java --- @@ -97,15 +91,14 @@ public long

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r87716071 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -224,42 +221,29 @@ private void addSegmentsIfEmpty

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r87716028 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -224,42 +221,29 @@ private void addSegmentsIfEmpty

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r87714121 --- Diff: integration/spark/src/main/scala/org/apache/spark/mapreduce/CarbonHadoopMapReduceUtil.scala --- @@ -0,0 +1,25

[GitHub] incubator-carbondata pull request #299: [CARBONDATA-384][WIP]Add Table Prope...

2016-11-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/299#discussion_r87615082 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala --- @@ -122,14 +122,29 @@ object CommonUtil

[GitHub] incubator-carbondata pull request #313: [CARBONDATA-405]Fixed Data load fail...

2016-11-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/313#discussion_r87613876 --- Diff: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataframe/DataFrameTestCase.scala --- @@ -0,0 +1,57

[GitHub] incubator-carbondata pull request #312: [CARBONDATA-404] Fixing dataframe sa...

2016-11-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/312#discussion_r87606284 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonDataFrameWriter.scala --- @@ -60,7 +61,12 @@ class

[GitHub] incubator-carbondata pull request #312: [CARBONDATA-404] Fixing dataframe sa...

2016-11-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/312#discussion_r87540690 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonDataFrameWriter.scala --- @@ -60,7 +60,8 @@ class

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r87540836 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java --- @@ -177,6 +178,13 @@ public

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r87540816 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java --- @@ -177,6 +178,13 @@ public

[GitHub] incubator-carbondata pull request #311: add example for data load without us...

2016-11-10 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/incubator-carbondata/pull/311 add example for data load without using kettle In this PR, example SQL and dataframe usage is added for loading data without kettle You can merge this pull request into a Git

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-09 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87218055 --- Diff: examples/src/main/scala/org/apache/carbondata/examples/CarbonExample1.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-09 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87217857 --- Diff: conf/ss.txt --- @@ -0,0 +1,122 @@ + +Release Notes - CarbonData - Version 0.1.0-incubating --- End diff -- why

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87125387 --- Diff: integration/spark/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java --- @@ -215,6 +227,105 @@ public static void

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87124965 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -396,4 +407,223 @@ private static

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87124860 --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87124691 --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordslogger.java --- @@ -81,13 +81,24

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87124544 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortParameters.java --- @@ -122,6 +116,11

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87123603 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataConverterProcessorStepImpl.java --- @@ -47,20 +58,109

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87123336 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataConverterProcessorStepImpl.java --- @@ -47,20 +58,109

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87122653 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/parser/impl/RowParserImpl.java --- @@ -18,22 +18,80

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87122331 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java --- @@ -43,35 +45,58

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87122165 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java --- @@ -102,21 +102,14

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87120631 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -1112,24 +1085,27 @@ case

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r87117986 --- Diff: integration/spark/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java --- @@ -215,6 +227,105 @@ public static void

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-07 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r86786637 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/block/Distributable.java --- @@ -16,10 +16,12

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-07 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r86786673 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -311,80 +278,6 @@ private void addSegmentsIfEmpty

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r8739 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -1198,10 +1172,16 @@ case

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r8652 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -0,0 +1,281

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r86665773 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -0,0 +1,281

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r86665514 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -0,0 +1,281

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r86664431 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/DataLoadProcessExecutor.java --- @@ -0,0 +1,28 @@ +package

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r86664395 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -0,0 +1,281

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2] Data load integration...

2016-11-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r86664148 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -0,0 +1,281

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] Use CarbonInputForm...

2016-11-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/262#discussion_r86362889 --- Diff: integration/spark/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java --- @@ -953,66 +959,6 @@ public static void

[GitHub] incubator-carbondata pull request #287: [CARBONDATA-367]Add support alluxio(...

2016-11-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/287#discussion_r86300020 --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/impl/FileFactory.java --- @@ -57,14 +58,18 @@ if (property

[GitHub] incubator-carbondata pull request #287: [CARBONDATA-367]Add support alluxio(...

2016-11-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/287#discussion_r86299810 --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/filesystem/ALLUXIOCarbonFile.java --- @@ -0,0 +1,129

[GitHub] incubator-carbondata pull request #287: [CARBONDATA-367]Add support alluxio(...

2016-11-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/287#discussion_r86299847 --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/impl/FileFactory.java --- @@ -57,14 +58,18 @@ if (property

[GitHub] incubator-carbondata pull request #287: [CARBONDATA-367]Add support alluxio(...

2016-11-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/287#discussion_r86299867 --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/impl/FileFactory.java --- @@ -57,14 +58,18 @@ if (property

[GitHub] incubator-carbondata pull request #272: [CARBONDATA-353]Update doc for datef...

2016-11-01 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/272#discussion_r85958955 --- Diff: docs/DML-Operations-on-Carbon.md --- @@ -91,12 +91,17 @@ Following are the options that can be used in load data: ```ruby

[GitHub] incubator-carbondata pull request #272: [CARBONDATA-353]Update doc for datef...

2016-11-01 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/272#discussion_r85958878 --- Diff: docs/DML-Operations-on-Carbon.md --- @@ -91,12 +91,17 @@ Following are the options that can be used in load data: ```ruby

[GitHub] incubator-carbondata pull request #272: [CARBONDATA-353]Update doc for datef...

2016-11-01 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/272#discussion_r85959032 --- Diff: docs/DML-Operations-on-Carbon.md --- @@ -91,12 +91,17 @@ Following are the options that can be used in load data: ```ruby

[GitHub] incubator-carbondata pull request #263: [CARBONDATA-2][WIP] Data load integr...

2016-10-31 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/263#discussion_r85757712 --- Diff: integration/spark/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java --- @@ -213,6 +224,64 @@ public static void

[GitHub] incubator-carbondata pull request #208: [CARBONDATA-284] Abstracting index a...

2016-10-28 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/208#discussion_r85480694 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/internal/segment/impl/IndexedSegment.java --- @@ -0,0 +1,73

[GitHub] incubator-carbondata pull request #208: [CARBONDATA-284] Abstracting index a...

2016-10-27 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/208#discussion_r85480562 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/internal/segment/impl/IndexedSegment.java --- @@ -0,0 +1,73

[GitHub] incubator-carbondata pull request #208: [CARBONDATA-284] Abstracting index a...

2016-10-27 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/208#discussion_r85457738 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/internal/segment/impl/IndexedSegment.java --- @@ -0,0 +1,73

[GitHub] incubator-carbondata pull request #208: [CARBONDATA-284] Abstracting index a...

2016-10-27 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/208#discussion_r85457078 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -0,0 +1,169 @@ +/* + * Licensed to

[GitHub] incubator-carbondata pull request #262: [CARBONDATA-308] [WIP] Use CarbonInp...

2016-10-26 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/incubator-carbondata/pull/262 [CARBONDATA-308] [WIP] Use CarbonInputFormat in CarbonScanRDD compute Use CarbonInputFormat in CarbonScanRDD compute function 1. In driver side, only getSplit is required, so

[GitHub] incubator-carbondata pull request #251: [CARBONDATA-302]Added Writer process...

2016-10-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/251#discussion_r85159483 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -304,4 +311,92 @@ public static

[GitHub] incubator-carbondata pull request #251: [CARBONDATA-302]Added Writer process...

2016-10-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/251#discussion_r85159146 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactHandlerFactory.java --- @@ -0,0 +1,48

[GitHub] incubator-carbondata pull request #251: [CARBONDATA-302]Added Writer process...

2016-10-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/251#discussion_r85157225 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/writer/DataWriterProcessorStepImpl.java --- @@ -0,0 +1,360

[GitHub] incubator-carbondata pull request #184: [CARBONDATA-264]Fixed limit query sc...

2016-10-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/184#discussion_r84940497 --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/QueryExecutorProperties.java --- @@ -91,5 +89,10 @@ * list of

[GitHub] incubator-carbondata pull request #184: [CARBONDATA-264]Fixed limit query sc...

2016-10-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/184#discussion_r84940346 --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/DetailQueryExecutor.java --- @@ -36,6 +36,7 @@ @Override public

[GitHub] incubator-carbondata pull request #251: [CARBONDATA-302]Added Writer process...

2016-10-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/251#discussion_r84843684 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/writer/DataWriterProcessorStepImpl.java --- @@ -0,0 +1,360

[GitHub] incubator-carbondata pull request #251: [CARBONDATA-302]Added Writer process...

2016-10-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/251#discussion_r84842984 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/writer/DataWriterProcessorStepImpl.java --- @@ -0,0 +1,360

[GitHub] incubator-carbondata pull request #254: [CARBONDATA-326] Create wrong table ...

2016-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/254#discussion_r84686198 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonCatalystOperators.scala --- @@ -90,3 +90,11 @@ abstract class

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681646 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -210,7 +216,7 @@ object

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681761 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -277,44 +283,43 @@ object

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681517 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -188,16 +194,16 @@ object

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681004 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataLoadRDD.scala --- @@ -196,30 +195,28 @@ class

[GitHub] incubator-carbondata pull request #255: CARBONDATA-336 Align the the name de...

2016-10-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/255#discussion_r84578283 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala --- @@ -926,14 +926,14 @@ class CarbonSqlParser

[GitHub] incubator-carbondata pull request #249: [CARBONDATA-329] constant final clas...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/249#discussion_r84567557 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -19,866 +19,859 @@ package

[GitHub] incubator-carbondata pull request #247: [CARBONDATA-301] Added Sort processo...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/247#discussion_r84515278 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/CarbonSorter.java --- @@ -0,0 +1,56

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84513482 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/FieldEncoderFactory.java --- @@ -0,0 +1,69

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84513301 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java --- @@ -0,0 +1,99

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84513452 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java --- @@ -0,0 +1,99

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84512153 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java --- @@ -0,0 +1,99

[GitHub] incubator-carbondata pull request #247: [CARBONDATA-301] Added Sort processo...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/247#discussion_r84495043 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/RemoveDictionaryUtil.java --- @@ -123,6 +123,60 @@ private static int

[GitHub] incubator-carbondata pull request #247: [CARBONDATA-301] Added Sort processo...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/247#discussion_r84494016 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/RemoveDictionaryUtil.java --- @@ -123,6 +123,60 @@ private static int

[GitHub] incubator-carbondata pull request #247: [CARBONDATA-301] Added Sort processo...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/247#discussion_r84492901 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java --- @@ -334,24 +151,24 @@ public

[GitHub] incubator-carbondata pull request #247: [CARBONDATA-301] Added Sort processo...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/247#discussion_r84491588 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/SortProcessorStepImpl.java --- @@ -0,0 +1,79

[GitHub] incubator-carbondata pull request #247: [CARBONDATA-301] Added Sort processo...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/247#discussion_r84491864 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java --- @@ -334,24 +151,24 @@ public

[GitHub] incubator-carbondata pull request #247: [CARBONDATA-301] Added Sort processo...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/247#discussion_r84490086 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/CarbonParallelReadMergeSorterImpl.java --- @@ -0,0

[GitHub] incubator-carbondata pull request #247: [CARBONDATA-301] Added Sort processo...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/247#discussion_r84489680 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/CarbonParallelReadMergeSorterImpl.java --- @@ -0,0

[GitHub] incubator-carbondata pull request #240: [CARBONDATA-298]Added InputProcessor...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/240#discussion_r84485160 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/constants/DataLoadProcessorConstants.java --- @@ -33,4 +33,8

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84484170 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java --- @@ -0,0 +1,99

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84484027 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/FieldEncoderFactory.java --- @@ -0,0 +1,59

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84484710 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/FieldEncoderFactory.java --- @@ -0,0 +1,59

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84484251 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java --- @@ -0,0 +1,99

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84482988 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/RowConverterImpl.java --- @@ -0,0 +1,94

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84483207 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/RowConverterImpl.java --- @@ -0,0 +1,94

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84482571 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/FieldEncoderFactory.java --- @@ -0,0 +1,59

[GitHub] incubator-carbondata pull request #238: [CARBONDATA-334] Correct Some Spelli...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/238#discussion_r84463724 --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java --- @@ -346,26 +346,26 @@ public static void

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r8023 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/RowConverterImpl.java --- @@ -0,0 +1,94

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84443937 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/RowConverterImpl.java --- @@ -0,0 +1,94

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r8189 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/FieldEncoderFactory.java --- @@ -0,0 +1,59

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84443403 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/RowConverterImpl.java --- @@ -0,0 +1,94

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84443155 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/RowConverterImpl.java --- @@ -0,0 +1,94

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84443496 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataConverterProcessorStepImpl.java --- @@ -0,0 +1,61

[GitHub] incubator-carbondata pull request #244: [CARBONDATA-300] Added Encoder proce...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84443007 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/encoding/impl/RowConverterImpl.java --- @@ -0,0 +1,94

[GitHub] incubator-carbondata pull request #240: [CARBONDATA-298]Added InputProcessor...

2016-10-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/240#discussion_r84435567 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/parser/ComplexParser.java --- @@ -0,0 +1,13 @@ +package

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404263 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -1114,36 +1121,36 @@ object

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404340 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala --- @@ -385,22 +385,22 @@ class

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404993 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -413,12 +413,12 @@ object

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404368 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala --- @@ -409,10 +409,10 @@ class

[GitHub] incubator-carbondata pull request #248: [CARBONDATA-328] Improve Code and Fi...

2016-10-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404900 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -267,10 +267,10 @@ object

  1   2   3   >