Re: [VOTE] CEP 33 - CIDR filtering authorizer

2023-06-27 Thread Francisco Guerrero
+1 (nb) On 2023/06/28 00:46:25 Yifan Cai wrote: > +1 > > On Tue, Jun 27, 2023 at 1:50 PM Dinesh Joshi wrote: > > > +1 > > > > > > On Jun 27, 2023, at 1:23 PM, Josh McKenzie wrote: > > > >  > > +1 > > > > On Tue, Jun 27, 2023, at 1:17 PM, Shailaja Koppu wrote: > > > > Hi Team, > > > > (Startin

Re: [VOTE] CEP 33 - CIDR filtering authorizer

2023-06-27 Thread Yifan Cai
+1 On Tue, Jun 27, 2023 at 1:50 PM Dinesh Joshi wrote: > +1 > > > On Jun 27, 2023, at 1:23 PM, Josh McKenzie wrote: > >  > +1 > > On Tue, Jun 27, 2023, at 1:17 PM, Shailaja Koppu wrote: > > Hi Team, > > (Starting a new thread for VOTE instead of reusing the DISCUSS thread, to > follow usual pr

Re: [VOTE] CEP 33 - CIDR filtering authorizer

2023-06-27 Thread Dinesh Joshi
+1On Jun 27, 2023, at 1:23 PM, Josh McKenzie wrote:+1On Tue, Jun 27, 2023, at 1:17 PM, Shailaja Koppu wrote:Hi Team,(Starting a new thread for VOTE instead of reusing the DISCUSS thread, to follow usual procedure).Please vote on CEP 33 - CIDR filtering authorizer https://cwiki.apache.org/confluen

Re: [VOTE] CEP 33 - CIDR filtering authorizer

2023-06-27 Thread Josh McKenzie
+1 On Tue, Jun 27, 2023, at 1:17 PM, Shailaja Koppu wrote: > Hi Team, > > (Starting a new thread for VOTE instead of reusing the DISCUSS thread, to > follow usual procedure). > > Please vote on CEP 33 - CIDR filtering authorizer > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-33%3A

[DISCUSS] Maintain backwards compatibility after dependency upgrade in the 5.0

2023-06-27 Thread Maxim Muzafarov
Hello everyone, We use the Dropwizard Metrics 3.1.5 library, which provides a basic set of classes to easily expose Cassandra internals to a user through various interfaces (the most common being JMX). We want to upgrade this library version in the next major release 5.0 up to the latest stable 4

[VOTE] CEP 33 - CIDR filtering authorizer

2023-06-27 Thread Shailaja Koppu
Hi Team, (Starting a new thread for VOTE instead of reusing the DISCUSS thread, to follow usual procedure). Please vote on CEP 33 - CIDR filtering authorizer https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-33%3A+CIDR+filtering+authorizer

Re: Writes after the column is dropped, broken reads, and TCM

2023-06-27 Thread Jakub Zytka
> > > With TCM a schema change bumps an epoch, this epoch is then serialized with > every read command/partition update and the replica can check if it is > behind > or ahead of the coordinator. This allows the replica to either catch up > with > the coordinator before executing the read/write or f

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
With git you can always opt-out by adding --no-verify flag to either push or commit I really prefer separate tasks than flags. Flags are not listed in the help message like "ant -p" and are not auto-completed in the terminal. That makes them almost undiscoverable for newcomers. Want to have jar i

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread David Capwell
> nobody referred to running checks in a pre-push (or pre-commit) hook In accord I added an opt-out for each hook, and will require such here as well… as long as you can opt-out, its fine by me… I know I will likely opt-out, but wouldn’t block such an effort > Your point that pre-push hook mig

[VOTE] CEP 33 - CIDR filtering authorizer

2023-06-27 Thread Shailaja Koppu
Hi Team, Starting voting for this CEP 33 - https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-33%3A+CIDR+filtering+authorizer . Please vote for this CEP, I will merge the PR after review if passes

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Mick Semb Wever
> The context is that we currently have 3 checks in the build: > > - Checkstyle, > - Eclipse-Warnings, > - RAT And dependency-check (owasp). > I want to discuss whether you are ok with extracting all checks to their > distinct target and not running it automatically with the targets which dev

Re: Improved DeletionTime serialization to reduce disk size

2023-06-27 Thread Mick Semb Wever
> > Just for completeness the change is a handful loc. The rest is added tests > and we'd loose the sstable format change opportunity window. > +1, if you have time for this approach and no other in this window. (If you have time for the other, or someone else does, then the technically superior

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
Stefan, if you build using command line and then commit / push also in the terminal, nothing would change for you: now: ant jar (automatically runs some checks) git commit git push proposed: ant jar (just build) git commit (run some checks) git push Your point that pre-push hook might not be the

Re: Writes after the column is dropped, broken reads, and TCM

2023-06-27 Thread Marcus Eriksson
Hi, reply inline below On Mon, Jun 26, 2023 at 06:39:09PM +0200, Jakub Zytka wrote: > Hello, > > I want to discuss the possibilities of fixing CASSANDRA-18591 and > CASSANDRA-18589 (~exceptions during reads), considering that TCM will > become a reality soon. > While both issues can be hit even o

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Miklosovic, Stefan
I am doing all git-related operations in the console / bash (IDEA terminal, alt+f12 in IDEA). I know IDEA can do git stuff as well but I never tried it and I just do not care. I just do not "believe it" (yeah, call me old-fashioned if you want) so for me how it looks like in IDEA around some che

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
So far, nobody referred to running checks in a pre-push (or pre-commit) hook. The use of Git hooks is going to be introduced along with Accord, so we could use them to force running checks once before sending changes to the repo. It would still be an opt-out approach because one would have to add t