Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Ekaterina Dimitrova
There is a separate thread started and respective ticket for generate-idea-files. https://lists.apache.org/thread/o2fdkyv2skvf9ngy9jhpnhvo92qvr17m CASSANDRA-18467 On Thu, 29 Jun 2023 at 16:54, Jeremiah Jordan wrote: > +100 I support making generate-idea-files auto setup everything in >

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Miklosovic, Stefan
Great stuff, Josh! This is what I was talking about when I was mentioning that I am super curious about the workflows of other people. Any chance you share your setup somewhere so I may try it? Too soon to tell if we indeed want to go that direction but trying it out would be great

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Jeremiah Jordan
+100 I support making generate-idea-files auto setup everything in IntelliJ for you. If you post a diff, I will test it. On this proposal, I don’t really have an opinion one way or the other about what the default is for local "ant jar”, if its slow I will figure out how to turn it off, if its

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Josh McKenzie
> In accord I added an opt-out for each hook, and will require such here as well On for main branches, off for feature branches seems like it might blanket satisfy this concern? Doesn't fix the "--atomic across 5 branches means style checks and build on hook across those branches" which isn't

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Ekaterina Dimitrova
Should we just keep a consolidated for all kind of checks no-check flag and get rid of the no-checkstyle one? Trading one for one with Josh :-) Best regards, Ekaterina On Thu, 29 Jun 2023 at 10:52, Josh McKenzie wrote: > I really prefer separate tasks than flags. Flags are not listed in the >

Re: Improved DeletionTime serialization to reduce disk size

2023-06-29 Thread Brandon Williams
On Thu, Jun 29, 2023 at 11:42 AM Jeff Jirsa wrote: > 3-4% reduction on disk ... for what exactly? > > It seems exceptionally uncommon to have 3% of your data SIZE be tombstones. If the data is TTL'd I think it's not entirely uncommon. Kind Regards, Brandon

Re: Improved DeletionTime serialization to reduce disk size

2023-06-29 Thread Jeff Jirsa
On Thu, Jun 22, 2023 at 11:23 PM Berenguer Blasi wrote: > Hi all, > > Given we're already introducing a new sstable format (OA) in 5.0 I would > like to try to get this in before the freeze. The point being that > sstables with lots of small partitions would benefit from a smaller DT > at

Re: Improved DeletionTime serialization to reduce disk size

2023-06-29 Thread Benedict
So I’m just taking a quick peek at SerializationHeader and we already have a method for reading and writing a deletion time with offsets from EncodingStats. So perhaps we simply have a bug where we are using DeletionTime Serializer instead of SerializationHeader.writeLocalDeletionTime? It looks

Re: CASSANDRA-18554 - mTLS based client and internode authenticators

2023-06-29 Thread Jeremiah Jordan
I like the idea of extending CREATE ROLE rather than adding a brand new ADD IDENTITY syntax. Not sure how that can line up with one to many relationships for an identity, but maybe that can just be done through role hierarchy? In either case, I don’t think IDENTITY related operations should be

Re: Improved DeletionTime serialization to reduce disk size

2023-06-29 Thread Josh McKenzie
> I would prefer we not plan on two distinct changes to this I agree with this sentiment, **and** > +1, if you have time for this approach and no other in this window. People are going to use 5.0 for awhile. Better to have an improvement in their hands for that duration than no improvement at

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Josh McKenzie
> I really prefer separate tasks than flags. Flags are not listed in the help > message like "ant -p" and are not auto-completed in the terminal. That makes > them almost undiscoverable for newcomers. Please, no more flags. We are *more* than flaggy enough right now. Having to dig through

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Mick Semb Wever
On Thu, 29 Jun 2023 at 13:30, Jacek Lewandowski wrote: > There is another target called "build", which retrieves dependencies, and > then calls "build-project". > Is it intended to be called by a user ? If not, please follow the ant style prefixing the target name with an underscore (so that

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Jacek Lewandowski
There is another target called "build", which retrieves dependencies, and then calls "build-project". czw., 29 cze 2023 o 12:33 Brandon Williams napisał(a): > This sounds good to me. Can we shorten 'build-project' to just 'build'? > > Kind Regards, > Brandon > > On Thu, Jun 29, 2023 at 3:22 

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Brandon Williams
This sounds good to me. Can we shorten 'build-project' to just 'build'? Kind Regards, Brandon On Thu, Jun 29, 2023 at 3:22 AM Jacek Lewandowski wrote: > > So given all the feedback, I'm going to do the following: > > "jar" will depend on "check" target > "build-project", "build-test" and

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Jacek Lewandowski
So given all the feedback, I'm going to do the following: "jar" will depend on "check" target "build-project", "build-test" and "test" targets will not depend on "check" target "check" target will include checkstyle, rat and eclipse-warnings There is an additional flag "no-check" to disable