Re: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-03 Thread Josh McKenzie
> Instead of running all the tests through available CI agents every time we > can have presets of tests: Back when I joined the project in 2014, unit tests took ~ 5 minutes to run on a local machine. We had pre-commit and post-commit tests as a distinction as well, but also had flakes in the pr

Re: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-03 Thread Maxim Muzafarov
For me, the biggest benefit of keeping the build scripts and CI configurations as well in the same project is that these files are versioned in the same way as the main sources do. This ensures that we can build past releases without having any annoying errors in the scripts, so I would say that th

Re: [DISCUSS] Maintain backwards compatibility after dependency upgrade in the 5.0

2023-07-03 Thread Maxim Muzafarov
I'd like to mention the approach we took here: to untangle the driver update in tests with the dropwizard library version (cassandra-driver 3.11 requires the "old" JMXReporter classes in the classpath) we have copied the classes into the tests themselves, as it is allowed by the Apache License 2.0.

Re: [VOTE] CEP 33 - CIDR filtering authorizer

2023-07-03 Thread Shailaja Koppu
Voting passes with 11 +1s and no -1. Closing this thread now. Thank you everyone. > On Jun 27, 2023, at 6:17 PM, Shailaja Koppu wrote: > > Hi Team, > > (Starting a new thread for VOTE instead of reusing the DISCUSS thread, to > follow usual procedure). > > Please vote on CEP 33 - CIDR filt

Re: Improved DeletionTime serialization to reduce disk size

2023-07-03 Thread Berenguer Blasi
Thanks for the comments Benedict. Given DeletionTime.localDeletionTime is what caps everything to year 2106 (uint enconded now) I am ok with a DeletionTime.markForDeleteAt that can go up to year 4284, personal opinion ofc. And yes I hope once I read, doc and understand the sstable format bette

Re: Improved DeletionTime serialization to reduce disk size

2023-07-03 Thread Benedict
I checked and I’m pretty sure we do, but it doesn’t apply any liveness optimisation. I had misunderstood the optimisation you proposed. Ideally we would encode any non-live timestamp with the delta offset, but since that’s a distinct optimisation perhaps that can be left to another patch.Are we hap