Re: [DISCUSS] putting versions into Deprecated annotations

2023-10-06 Thread Miklosovic, Stefan
If we want to use some description (of type String), we would need to introduce a brand new annotation instead of java.lang.Deprecated as that one does not have it. I am in favor of custom annotation instead of using Javadocs for this kind of technical documentation. An annotation seems to be

Re: [DISCUSS] Gossip shutdown may corrupt peers making it so the cluster never converges, and a small protocol change to fix

2023-10-06 Thread David Capwell
> Won't the replacement have a newer generation? The replacement is a different instance. I performs a shadow round with its seeds and if they are impacted by this issue then they are missing tokens, so we fail the host replacement… you can work around this by changing the seeds to nodes that

Re: [DISCUSS] Gossip shutdown may corrupt peers making it so the cluster never converges, and a small protocol change to fix

2023-10-06 Thread Brandon Williams
On Fri, Oct 6, 2023 at 5:50 PM David Capwell wrote: > Lets say you now need to host replace node1 Won't the replacement have a newer generation? > avoid peers mutating endpoint states they don’t own This sounds reasonable to me. > This would be a protocol change, so would need to make sure

Re: [DISCUSS] putting versions into Deprecated annotations

2023-10-06 Thread Francisco Guerrero
> Might be nice to support a 3rd param that's a String for the reason it's > deprecated. Javadocs offers this natively /** * @deprecated Use instance method {@link #newMethod(Param1, Param2...)} instead. */ @Deprecated So we could leverage javadocs for this purpose On

[DISCUSS] Gossip shutdown may corrupt peers making it so the cluster never converges, and a small protocol change to fix

2023-10-06 Thread David Capwell
Just filed https://issues.apache.org/jira/browse/CASSANDRA-18913 (Gossip NPE due to shutdown event corrupting empty statuses) which is where I saw this issue.. When we do gossip shutdown we send a message GOSSIP_SHUTDOWN which then gets handled by this method

Re: [DISCUSS] putting versions into Deprecated annotations

2023-10-06 Thread Doug Rohrer
+1 on reason string, especially some way to indicate what replaces a method if it’s being moved into some other class/new method with more parameters/etc. I’ve found lots of cases (in code bases in general, not C* in particular) where something is marked as Deprecated but there’s no mention of

Re: [VOTE] Accept java-driver

2023-10-06 Thread J. D. Jordan
The software grant agreement covers all donated code.  The ASF does not need any historical agreements. The agreement giving the ASF copyright etc is the Software Grant Agreement. Yes, any future work done after donation needs to be covered by ASF CLAs.But happy to see someone ask legal@ to

Hacktoberfest?

2023-10-06 Thread German Eichberger via dev
All, It's that time of year where the Hacktoberfest happens again:https://hacktoberfest.com/participation/#maintainers We would need to mark our repo and also review the contributions timely so the participants can earn their T-Shirt (?). As Ekaterina pointed out October is also the month

Re: [DISCUSS] putting versions into Deprecated annotations

2023-10-06 Thread Josh McKenzie
Might be nice to support a 3rd param that's a String for the reason it's deprecated. i.e. "Replaced by X", "Unmaintained", "Obsolete", "See CASSANDRA-N", link to a dev ML thread on pony mail, etc. That way if someone comes across it in the codebase they have some context to follow up on

Re: [DISCUSSION] Cassandra's code style and source code analysis

2023-10-06 Thread Maxim Muzafarov
Hello everyone, Some updates. There are issues that we have put on hold, waiting for the CEPs to be finalized. The java imports are one of these issues, let's do not forget them ^^ I've created a label to track it: https://issues.apache.org/jira/issues/?jql=labels%20%3D%20code-polishing On Tue,

[DISCUSS] putting versions into Deprecated annotations

2023-10-06 Thread Miklosovic, Stefan
Hi list, I have a ticket to discuss (1). When we deprecate APIs / methods etc, what I want to suggest is that we might start to explicitly add the version when that happened. For example, if you deprecated something which goes to 5.0, would you be so nice to do this? @Deprecated(since =

Re: [VOTE] Accept java-driver

2023-10-06 Thread Benedict
Are we certain about that? It’s unclear to me from the published guidance; would be nice to get legal to weigh in to confirm to make sure we aren’t skipping any steps, as we haven’t been involved until now so haven’t the visibility. At the very least it reads to me that anyone expected to be

Re: [VOTE] Accept java-driver

2023-10-06 Thread Mick Semb Wever
On Thu, 5 Oct 2023 at 17:50, Jeremiah Jordan wrote: > I think this is covered by the grant agreement? > > https://www.apache.org/licenses/software-grant-template.pdf > > 2. Licensor represents that, to Licensor's knowledge, Licensor is > legally entitled to grant the above license. Licensor