Re: Adding wiremock to test dependencies

2023-06-21 Thread Derek Chen-Becker
Generally +1 on this one because it looks different, but am I correct that we already have a couple of mocking libs in our dependencies? I guess my concern is that adding a dependency is probably as much about adding some documentation on why it's included and how/when to use it as it is about upda

Re: Adding wiremock to test dependencies

2023-06-20 Thread Josh McKenzie
Speaking only to the "we don't want to add a dependency on something that's unstable or likely to fizzle out", looks good there to me: • Long-term project health / activity looks robust: https://github.com/wiremock/wiremock/graphs/contributors • Pretty diverse set of contributors in the last co

Re: Adding wiremock to test dependencies

2023-06-20 Thread Brandon Williams
I was concerned about 'jre8' being in the dependency name and looked into which java versions were supported, and it looks like 17 is, so we should verify but I am +1 if that is the case. https://github.com/wiremock/wiremock/issues/1655 Kind Regards, Brandon On Tue, Jun 20, 2023 at 6:35 AM Miklo

Re: Adding wiremock to test dependencies

2023-06-20 Thread Miklosovic, Stefan
I forgot to mention that in the future this will not be used for testing AWS IDSv2 only. There are other snitches we have which are also calling similar "services" to get some metadata from an instance a node runs in and this communication is currently not tested at all. I can pretty much imagin