Re: Sonar

2011-08-01 Thread Aristedes Maniatis
On 1/08/11 10:59 PM, Andrey Razumovsky wrote: I've found this saying URLs are not good as keys for map/set (not performance issues though): http://alan.blog-city.com/do_not_use_javaneturl_as_a_key_in_hashmap.htm This explains it well: http://michaelscharf.blogspot.com/2006/11/javaneturlequals-

Re: M3?

2011-08-01 Thread Andrus Adamchik
Some good news. Our maven/Nexus setup has been complete, and mvn release:perform for a fake release just succeeded for me. In the next couple of days I'll hopefully figure out what else we need to do to make it a part of our release procedure. (And at the minimum I'll be able to check whether ou

Re: Ashwood Issues

2011-08-01 Thread Andrus Adamchik
Very nice. Perhaps one area of Ashwood improvement here would be a better diagnostics of the loops. I.e. if the exception could have the exact relationships involved you could've solved your problem in 5 minutes. Andrus On Aug 1, 2011, at 4:13 PM, Michael Gentry wrote: > BTW Andrus, the algori

Re: Maven: Aggregation and unpublished modules

2011-08-01 Thread Christian Grobmeier
> > I don't know that solves our problem from my initial understanding. Shade > will rename the classes, where our main problem is our hierarchy of poms. We > have an artificially flattened hierarchy to avoid end users seeing a regular > maven pom tree. With Shade Cayenne could have a regular mave

Re: Ashwood Issues

2011-08-01 Thread Michael Gentry
BTW Andrus, the algorithm I was using in my entity sorter had a pretty significant flaw, so I'm going to have to restart it at some point. However, it did help us find a deep DbEntity cycle that was messing Ashwood up. We had something like A->B->C->D->E->F->G->H->A and Ashwood got confused and ge

Re: Sonar

2011-08-01 Thread Andrey Razumovsky
I've found this saying URLs are not good as keys for map/set (not performance issues though): http://alan.blog-city.com/do_not_use_javaneturl_as_a_key_in_hashmap.htm Author advices to use URL.toString() as key instead. As for the false positives, I agree completely, obviously most of those ~10k d

Re: Sonar

2011-08-01 Thread Michael Gentry
I'll have to look more later, but these tools often generate lots of false positives and need a way to silence warnings from run-to-run. mrg On Mon, Aug 1, 2011 at 8:42 AM, Andrus Adamchik wrote: > Depends on whether their assertion about DNS lookups is true. We are using > local URLs anyways,

Re: Sonar

2011-08-01 Thread Andrus Adamchik
Depends on whether their assertion about DNS lookups is true. We are using local URLs anyways, and nobody complained to date, but certainly worth a run in a debugger. On Aug 1, 2011, at 3:30 PM, Michael Gentry wrote: > Is this really a blocker? > > https://analysis.apache.org/drilldown/violati

Re: Sonar

2011-08-01 Thread Michael Gentry
Is this really a blocker? https://analysis.apache.org/drilldown/violations/org.apache.cayenne:cayenne-parent?priority=BLOCKER# Thanks, mrg On Mon, Aug 1, 2011 at 6:04 AM, Aristedes Maniatis wrote: > https://analysis.apache.org/dashboard/index/67484 > > We can certainly throw out all the findb

Re: Sonar

2011-08-01 Thread Andrus Adamchik
Cool. So how does it work? Is there a special Jenkins build for Sonar to collect this info? (Wonder what LCOM "Lack of Cohesion of Methods" measures?) Andrus On Aug 1, 2011, at 1:04 PM, Aristedes Maniatis wrote: > https://analysis.apache.org/dashboard/index/67484 > > We can certainly throw o

Sonar

2011-08-01 Thread Aristedes Maniatis
https://analysis.apache.org/dashboard/index/67484 We can certainly throw out all the findbugs/clover/etc cruft now. This is much better. Ari -- --> Aristedes Maniatis GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A