Github user huikyole closed the pull request at:
https://github.com/apache/climate/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-97084414
Ack @chrismattmann and @MJJoyce. Thanks for the advice, still learning!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chrismattmann commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-97177215
Yep no worries I just call them tickle commits change spacing on s text
file then add commit msg all good!
---
If your project is set up for it, you can reply to
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-96820806
That sounds like a question for the relevant pull request @huikyole. I
would move that discussion over there and close this pull request since it's
been merged.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-96907424
Ack @chrismattmann. Looks like there was a typo in the merge commit that
caused it to not close.
---
If your project is set up for it, you can reply to this email and
Github user huikyole commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-96025655
I still wonder why we prioritize the changes in #112 over major bug in the
time decoding and seasonal average. Some critical bugs in
calc_climatology_season in
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95965439
@huikyole Please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95965230
Resolve CLIMATE-508. Merged PR#112.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95727966
@MJJoyce @cgoodale @huikyole @chrismattmann This is great functionality
to have in the code base which been demonstrated to work. It has been
outstanding here for
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95733047
Would have been nice if the requests/questions had been answered, or even
just acknowledged in some way, before merging. But if you want to take on the
responsibility
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95795527
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user huikyole commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95744029
@MJJoyce, there is dependency. Current OCW time parsing module could not
properly handle my test data (CMIP5 model output). Once #111 is merged, I will
refactor this
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95773039
Alrighty. No reason to hold merging this then if it's just the example data
not in this PR that wouldn't load. +1 again from me @kwhitehall. Easy enough to
integrate
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95783622
@huikyole I looked through this code, but I don't see the dependency to
#111 that you refer.
If it is a dependency that is wrapped up in an example, then I would
Github user cgoodale commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-78422029
Hey @huikyole I was looking into the open issues and I saw this one and I
have to agree with @MJJoyce that example code would be great. Even a simple
example of how
GitHub user huikyole opened a pull request:
https://github.com/apache/climate/pull/112
CLIMATE-508: added a class 'Downscaling' and histogram plots
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huikyole/climate CLIMATE-508
16 matches
Mail list logo
