Re: Error to start MS on 4.2

2013-07-20 Thread Koushik Das
The code needs to handle the case when the db. entry is not present. It should fall back on some default value. -Koushik On 21-Jul-2013, at 12:38 AM, Min Chen wrote: > Thanks Vijay. I just figured out that trick myself:) I will check in a fix > to 4.2, seems that he forgot to seed this config

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

2013-07-20 Thread Mike Tutkowski
> On June 28, 2013, 9:42 a.m., John Burwell wrote: > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java, > > line 3927 > > > > > > Use an ExceutorService. Don't implement your

Another way to save your build time

2013-07-20 Thread Edison Su
If you already know how to enable hostswap with jetty + maven + eclipse/intellij, please ignore. There are two links: https://gist.github.com/naaman/1053217 http://www.clickonchris.com/2010/05/configuring-jetty-maven-and-eclipse-together-with-hot-deploy/ If you follow their steps, test and develop

Re: Review Request 11942: ProcessUtil cleanup

2013-07-20 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/ --- (Updated July 20, 2013, 8:01 p.m.) Review request for cloudstack. Changes ---

Re: Error to start MS on 4.2

2013-07-20 Thread Min Chen
Thanks Vijay. I just figured out that trick myself:) I will check in a fix to 4.2, seems that he forgot to seed this config value in schema410to420.sql. -min On 7/20/13 12:05 PM, "Vijayendra Bhamidipati" wrote: >Hi Min, > >Yes it's due to Frank's changes that went into >0633608f8035f8f409c271f

RE: Error to start MS on 4.2

2013-07-20 Thread Vijayendra Bhamidipati
Hi Min, Yes it's due to Frank's changes that went into 0633608f8035f8f409c271fc6e7548699a63d366 on master (and a5ee39a54a8574b030655916d6156d049c99009c on 4.2). He introduced a new global configuration variable ucs.sync.blade.interval. So to not run into this error, either redeploy your db or

Error to start MS on 4.2

2013-07-20 Thread Min Chen
Hi there, Anybody encounter this issue in starting MS on latest 4.2 branch? INFO [utils.component.ComponentContext] (Timer-2:) Starting com.cloud.ucs.manager.UcsManagerImpl ERROR [utils.component.ComponentContext] (Timer-2:) Unhandled exception java.lang.NumberFormatException: null at java.lang

Re: Reviewboard and jenkins

2013-07-20 Thread Prasanna Santhanam
On Sat, Jul 20, 2013 at 09:46:59AM -0400, David Nalley wrote: > On Sat, Jul 20, 2013 at 5:53 AM, Hugo Trippaers wrote: > > > > > > Sent from my iPhone > > > > On 20 jul. 2013, at 10:09, Prasanna Santhanam wrote: > > > >> On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote: > >>> > >>>

Re: master unstable with CLOUDSTACK-3682/3683

2013-07-20 Thread Sheng Yang
CLOUDSTACK-3682: NPE in BridgeVifDriver causing systemvm startup failure in KVM https://issues.apache.org/jira/browse/CLOUDSTACK-3682 Agent log excerpt: Jul 19 22:25:24 apache-81-3.fmt.vmops.com local1: 2013-07-20 05:25:24,952 WARN [cloud.agent.Agent] (agentRequest-Handler-1:null) Caught: Jul 19

Re: Reviewboard and jenkins

2013-07-20 Thread David Nalley
On Sat, Jul 20, 2013 at 5:53 AM, Hugo Trippaers wrote: > > > Sent from my iPhone > > On 20 jul. 2013, at 10:09, Prasanna Santhanam wrote: > >> On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote: >>> >>> On Jul 19, 2013, at 7:15 PM, Daan Hoogland wrote: >>> good stuff, does it ru

RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-07-20 Thread Alex Huang
Daan, It should assert and throw a CloudRuntimeException. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Exceptions+and+logging --Alex From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Saturday, July 20, 2013 3:25 AM To: Alex Huang Cc: Hugo Trippaers; cloudstack Subject: Re: Re

Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value

2013-07-20 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/#review23577 --- Ship it! Ship It! - Koushik Das On July 19, 2013, 10:14 a.m., Ha

Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value

2013-07-20 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/#review23576 --- Ship it! master -> 78f1092df12928f06646b3bc42d69cc45dd3b1d3 4.2 ->

Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value

2013-07-20 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/#review23575 --- Commit f604e3d9cc9073c8863bbd7dfc47fb6693a0b6f0 in branch refs/heads

Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value

2013-07-20 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/#review23574 --- Commit 78f1092df12928f06646b3bc42d69cc45dd3b1d3 in branch refs/heads

Re: Noisy ASFBot

2013-07-20 Thread Prasanna Santhanam
I've turned off the noisy jobs from Cato_Fong. I suspect it isn't useful to others but only to those who are debugging the tests. Will enable them at a more appropriate time later. On Sat, Jul 20, 2013 at 04:23:36PM +0530, Prasanna Santhanam wrote: > What I like particularly about ASFBot is that

Re: Noisy ASFBot

2013-07-20 Thread Prasanna Santhanam
What I like particularly about ASFBot is that it lets me track JIRA easily. If it is indeed creating noise may be some of the alerts can be pruned down. The thing I suspect is annoying people is the git2jira updates on bugs. I guess bot comments on JIRA bug reports needn't be broadcast. Humbeedoh

Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-07-20 Thread Daan Hoogland
Alex, it falls through to 'UnDecided' if not known. Do you mean it should throw something? or maybe add an extra 'UnDefined'? On Fri, Jul 19, 2013 at 5:31 PM, Alex Huang wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12685/ > > Ship it! >

Re: [DISCUSS] coding convention for method - and class length

2013-07-20 Thread Daan Hoogland
John, Chip, I don't mean to impose laws on people. A convention is by definition a shared rule of thumb, in my understanding. If I am not correct in my understanding of the English language and the connotations of the term convention, I retract my proposal to add these two 'rules' to the coding co

Re: [ACS42] NFS Cache Naming

2013-07-20 Thread Daan Hoogland
NFS Staging it was in my recollection. On Fri, Jul 19, 2013 at 10:30 PM, John Burwell wrote: > All, > > It was my understanding that we had agreed to rename the "NFS Cache" > mechanism to reflect that it is not a cache and remove the assumption that > it will always be backed by NFS. Is my und

Re: Noisy ASFBot

2013-07-20 Thread Daan Hoogland
I agree, @Prasanna, can we make ignore default and /activate ASFBot? That would have my preference. Daan On Sat, Jul 20, 2013 at 6:55 AM, Prasanna Santhanam wrote: > On Sat, Jul 20, 2013 at 12:48:28AM +0200, Hugo Trippaers wrote: > > Hey guys, > > > > I've noticed that our friendly bots on #c

Re: Reviewboard and jenkins

2013-07-20 Thread Hugo Trippaers
Sent from my iPhone On 20 jul. 2013, at 10:09, Prasanna Santhanam wrote: > On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote: >> >> On Jul 19, 2013, at 7:15 PM, Daan Hoogland wrote: >> >>> good stuff, does it run the risk of running while another instance is busy? >> >> Probab

Re: Reviewboard and jenkins

2013-07-20 Thread Prasanna Santhanam
On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote: > > On Jul 19, 2013, at 7:15 PM, Daan Hoogland wrote: > > > good stuff, does it run the risk of running while another instance is busy? > > Probably not, it's a single threaded script. I intend to use jenkins > to schedule it and i

Re: Review Request 12758: Cloustack - 3452: Added check if security groups feature is enabled in basic zone before creating any sec group

2013-07-20 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12758/#review23571 --- Ship it! commit 4f8c43fc2089e455aaad8203c01d44ed409d0c32 (master)