Jenkins build is back to normal : cloudstack-4.4-maven-build-noredist #118

2014-04-14 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build-noredist/118/changes

Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup script from logging messages to /var/log/cloud/cloud.out

2014-04-14 Thread Saurav Lahiri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19584/ --- (Updated April 14, 2014, 7:10 a.m.) Review request for cloudstack and Jayapal

Review Request 20311: CLOUDSTACK-6398: [hyper-v] Change auto shutdown and startup actions of VMs to shutdown and nothing

2014-04-14 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20311/ --- Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs:

Review Request 20313: CLOUDSTACK-6400:[hyper-v] [vmsync] Occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS

2014-04-14 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20313/ --- Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs:

Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy support scripts from spawning multiple java processes

2014-04-14 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20123/#review40251 --- systemvm/scripts/run.sh

Issue with multiple hypervisor in Cloudstack 4.2

2014-04-14 Thread Pradeep Cloudstack
Hi, I have a Cloustack 4.2 deployment. I created a Advanced zone and there I chose the Hypervisor type as KVM. Later I created a cluster for XenServer hypervisor type and added a XenServer to it. Now I want to create a VM on the XenServer from Cloudstack UI. I created appropriate Host Tags

Re: Review Request 20117: Pilot patch for CS JIRA 6213

2014-04-14 Thread Mandar Barve
Do you mean at init walk the list of sensitive classes somehow, followed by sensitive Params and build the REGEX to be used at run time? Basically split the existing logic into 2 parts? That sounds like a good idea. I will need to find out how to do it but sounds doable. Thanks, Mandar On Mon,

RE: Coding Standards Questions

2014-04-14 Thread Stephen Turner
I agree that pulling the return value out into a variable and returning it at the end can be clearer, but I wouldn't want to make an absolute rule about it. Sometimes returning early can reduce the number of nested if/else statements and increase clarity. For example, I would rather see:

Review Request 20315: CLOUDSTACK-6401: [hyper-v] fixed correct host state in cloudstack if the hyper-v agent is down

2014-04-14 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20315/ --- Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs:

Review Request 20316: CLOUDSTACK-1466: Adding Domain Limits and Resize Volume test suits for Primary Storage Limits

2014-04-14 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20316/ --- Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Bugs:

Re: Issue with multiple hypervisor in Cloudstack 4.2

2014-04-14 Thread Pradeep Cloudstack
My bad; I was using wrong template (one that was meant for KVM) -pradeep From: Pradeep Cloudstack pradeepcloudst...@yahoo.com To: dev@cloudstack.apache.org dev@cloudstack.apache.org Sent: Monday, April 14, 2014 2:43 PM Subject: Issue with multiple hypervisor

Re: Coding Standards Questions

2014-04-14 Thread Rajani Karuturi
I agree with Stephen. IDEs are smart and can highlight all the exits of a function. Functions which are more than a page long are more of an issue than the multiple return statements. It is very difficult to follow such code. ~Rajani On 14-Apr-2014, at 3:05 pm, Stephen Turner

RE: Coding Standards Questions

2014-04-14 Thread Gabor Apati-Nagy
To my mind having multiple return statements might be unclear sometimes, but personally I do prefer this option. In this case we can easily make sure that the return value is not going to be changed. If we know the result, let's return it asap. If we reach a return statement anywhere, we can be

RE: Coding Standards Questions

2014-04-14 Thread Ian Southam
Hi, It is all a question of good computer science. A return can easily become a sneaky goto so, it does makes sense to avoid dotting them all over methods because it can (and often does) indicate that the code is poorly structured. That said, use common sense. Making code less readable or

Build failed in Jenkins: cloudstack-4.3-maven-build #521

2014-04-14 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.3-maven-build/521/changes Changes: [wido] CLOUDSTACK-4665: Depend on rados-java 0.1.4 [wido] CLOUDSTACK-4665: Check if a snapshot is protected before trying to unprotect [wido] debian: Add JNA flag when starting agent [wido] debian:

Re: Cloudstack support for Xen (on Ubuntu)

2014-04-14 Thread Rafael Weingartner
Well, if I remember right, what was discontinued was the XCP O.S. version (If I can call it that way.). I remember that when we were going to install XCP, there was the possibility to download an ISO that contained the Xen hypervisor and XCP installed over some O.S. (Debian). We were going to use

[4.3] Wrong download template URL

2014-04-14 Thread Nux!
Hello, I run my own realhostip and today by chance I needed to download a template from ACS 4.3, but instead of getting a link looking like http://1-2-3-4.mydomain.tld/blah-blah.qcow2 I got with just the top domain: http://domain.tld/blah-blah.qcow2 which end up in a 404. Can anyone

Committer accounts...

2014-04-14 Thread Chip Childers
Before everyone starts asking... This: - https://twitter.com/infrabot/status/47754934280192 And if you don't have a GPG key setup and tied to your ASF LDAP entry, this: - https://www.apache.org/dev/infra-contact#regain-account -chip

Re: NodeJS Client for CloudStack

2014-04-14 Thread Sebastien Goasguen
On Apr 11, 2014, at 6:46 AM, Madan Ganesh V madangan...@me.com wrote: Hello there, I’m writing nodeJS client application to interact with CloudStack. I notice csclient and node-cloudstack modules. csclient throws API error 432 for listVirtualMachines. Anybody has played with these

Re: DevCloud with OpenContrail

2014-04-14 Thread Sebastien Goasguen
On Apr 9, 2014, at 11:41 PM, Ranjeet R rranj...@juniper.net wrote: Hello all The instructions to download, build from source, install and provision OpenContrail Network offering with DevCloud is posted here.

Re: DevCloud with OpenContrail

2014-04-14 Thread Chip Childers
On Thu, Apr 10, 2014 at 03:41:44AM +, Ranjeet R wrote: Hello all The instructions to download, build from source, install and provision OpenContrail Network offering with DevCloud is posted here.

Re: interactions Cloudstack Vmware

2014-04-14 Thread ilya musayev
Interaction happens on several layers. Using VMware SDK, CloudStack Management Server initially talks to vCenter over 443. However, you will also see some interaction between Storage VM as well as Proxy VM to vCenter and ESXi hosts directly. Are you experiencing any issues or is this for

Re: DevCloud with OpenContrail

2014-04-14 Thread ilya musayev
Definitely going to be something i need to try in the near future. Thank you.. On 4/9/14, 11:41 PM, Ranjeet R wrote: Hello all The instructions to download, build from source, install and provision OpenContrail Network offering with DevCloud is posted here.

Re: Review Request 20117: Pilot patch for CS JIRA 6213

2014-04-14 Thread Daan Hoogland
you got my drift. we could also replace the regex with a tree of flags to search that contains flags or method names. Not sure how that impacts performance. On Mon, Apr 14, 2014 at 11:14 AM, Mandar Barve mandar.ba...@sungardas.com wrote: Do you mean at init walk the list of sensitive classes

Re: NodeJS Client for CloudStack

2014-04-14 Thread Madan Ganesh V
Thanks Sebastien for the reply, We could get started with node-cloudstack. So far so good. We will roll out our cloud analytics beta next week. Hope the nodeJS works like a charm with ACS. Cheers, Madan www.actonmagic.com On 14 April 2014 at 9:28:50 pm, Sebastien Goasguen (run...@gmail.com)

Re: interactions Cloudstack Vmware

2014-04-14 Thread Mohamed Ali Saidi
thank you for informations. Exactly i would like to know what protocol vcenter uses to send reponse to cloudstack. Cloudstack send requests via https but reponse is it on https too? Regards 2014-04-14 17:28 GMT+01:00 ilya musayev ilya.mailing.li...@gmail.com: Interaction happens on several

Re: Review Request 20154: Fix: ParamGenericValidationWorker shouldn't be case sensitive

2014-04-14 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20154/#review40274 --- Ship it! Ship It! - Alena Prokharchyk On April 9, 2014, 1:52

Re: NodeJS Client for CloudStack

2014-04-14 Thread Chip Childers
https://nodejsmodules.org/tags/cloudstack I have not used them myself, so YMMV. On Mon, Apr 14, 2014 at 10:42:02PM +0530, Madan Ganesh V wrote: Thanks Sebastien for the reply, We could get started with node-cloudstack. So far so good. We will roll out our cloud analytics beta next week.

Re: Review Request 20154: Fix: ParamGenericValidationWorker shouldn't be case sensitive

2014-04-14 Thread Alena Prokharchyk
On April 14, 2014, 5:18 p.m., Alena Prokharchyk wrote: Ship It! Fix is committed to 4.4 and master branches. - Alena --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20154/#review40274

Re: interactions Cloudstack Vmware

2014-04-14 Thread ilya musayev
Cloudstack send requests via https but reponse is it on https too? That would be my guess, the entire interaction for vCenter should be over 443. On 4/14/14, 1:17 PM, Mohamed Ali Saidi wrote: thank you for informations. Exactly i would like to know what protocol vcenter uses to send

Re: KVM, Re-create VR failed

2014-04-14 Thread Marcus
Your agent snippet just looks like the system trying to stop the vm. If a vm fails to start, it will also run through the stop routine to clean up all of the prework, so the 'failed to stop' debug is all normal. You may need to go above and look at why it failed to start. On Fri, Apr 11, 2014 at

Re: [4.3] Wrong download template URL

2014-04-14 Thread Amogh Vasekar
Hi, What is the value of secstorage.ssl.cert.domain? Thanks, Amogh On 4/14/14 8:21 AM, Nux! n...@li.nux.ro wrote: Hello, I run my own realhostip and today by chance I needed to download a template from ACS 4.3, but instead of getting a link looking like

Re: [4.3] Wrong download template URL

2014-04-14 Thread Nux!
On 14.04.2014 16:21, Nux! wrote: Hello, I run my own realhostip and today by chance I needed to download a template from ACS 4.3, but instead of getting a link looking like http://1-2-3-4.mydomain.tld/blah-blah.qcow2 I got with just the top domain: http://domain.tld/blah-blah.qcow2 which end up

Re: [4.3] Wrong download template URL

2014-04-14 Thread Nux!
On 14.04.2014 18:57, Amogh Vasekar wrote: Hi, What is the value of secstorage.ssl.cert.domain? It's domain.tld. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

Re: [4.3] Wrong download template URL

2014-04-14 Thread Amogh Vasekar
Can you change it to *.domain.tld and try? Thanks, Amogh On 4/14/14 10:59 AM, Nux! n...@li.nux.ro wrote: On 14.04.2014 18:57, Amogh Vasekar wrote: Hi, What is the value of secstorage.ssl.cert.domain? It's domain.tld. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

Re: Review Request 19917: Improvements on exception handlers (JIRA-6242)

2014-04-14 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19917/#review40285 --- Ding, sorry for the late reaction. I forgot to look at your patch

Re: Review Request 19686: Implementation of the issue CLOUDSTACK 6139 - System.vm.use.local.storage global setting to zone setting

2014-04-14 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19686/#review40286 --- Can you change the commit comment? It contains the text '... and

Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey

2014-04-14 Thread Sachchidanand Vaidya
Hi, Can someone pls review these changes. Thanks Regards, Sachin On 4/2/14 2:14 AM, Sachchidanand Vaidya vaidy...@juniper.net wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19912/

Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-04-14 Thread Sachchidanand Vaidya
Hi, Can someone pls review these changes. Thanks Regards, Sachin From: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Reply-To: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Date: Tuesday, April 1, 2014 3:05 PM To: Sachchidanand Vaidya

Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

2014-04-14 Thread Sachchidanand Vaidya
Hi, Can someone pls. review these changes. Thanks Regards, Sachin From: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Reply-To: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Date: Thursday, March 27, 2014 4:38 PM To: Sachchidanand Vaidya

Re: [4.3] Wrong download template URL

2014-04-14 Thread Nux!
On 14.04.2014 19:08, Amogh Vasekar wrote: Can you change it to *.domain.tld and try? Thanks, Amogh Thanks Amogh, that did the trick! Do not that I have the same problem with a default installation using realhostip, it's good to be fixed. -- Sent from the Delta quadrant using Borg

Re: Review Request 19917: Improvements on exception handlers (JIRA-6242)

2014-04-14 Thread Ding Yuan
Hi Daan,Here you go! Please let me know if this is not what you want...Thanks a lot for this!Ding 0002-6242.patch Description: Binary data On Apr 14, 2014, at 2:13 PM, daan Hoogland daan.hoogl...@gmail.com wrote: This is an automatically generated e-mail. To reply,

Re: Review Request 19917: Improvements on exception handlers (JIRA-6242)

2014-04-14 Thread Daan Hoogland
thanks Ding, it doesn't apply, I'm afraid. Can you rebase it to latest master? Make sure it is only one commit. On Mon, Apr 14, 2014 at 8:48 PM, Ding Yuan y...@ece.utoronto.ca wrote: Hi Daan, Here you go! Please let me know if this is not what you want... Thanks a lot for this! Ding On

Re: [4.3] Wrong download template URL

2014-04-14 Thread Amogh Vasekar
Hi, Is it an upgrade or a fresh 4.3 install for the other set-up you mentioned? If it is a fresh set-up, those fields should be NULL since we default everything to HTTP now. Thanks, Amogh On 4/14/14 11:33 AM, Nux! n...@li.nux.ro wrote: On 14.04.2014 19:08, Amogh Vasekar wrote: Can you change

RE: interactions Cloudstack Vmware

2014-04-14 Thread Michael Phillips
I did a trace the other day to open the correct ports from cloudstack to vcenter, and I found the mgmt servers and systems vm's talking to vcenter over 443 only... Date: Mon, 14 Apr 2014 18:17:12 +0100 Subject: Re: interactions Cloudstack Vmware From: saidi.mohamed.ali...@gmail.com To:

Re: interactions Cloudstack Vmware

2014-04-14 Thread Mohamed Ali Saidi
Thank you all for the help 2014-04-14 20:59 GMT+01:00 Michael Phillips mphilli7...@hotmail.com: I did a trace the other day to open the correct ports from cloudstack to vcenter, and I found the mgmt servers and systems vm's talking to vcenter over 443 only... Date: Mon, 14 Apr 2014

AsyncJobEvents missing from Event Bus in 4.3

2014-04-14 Thread David Grizzanti
Hi All, I came across an issue this week that I wanted to see if anyone is aware of. Until recently we've been running on 4.2 and using the Event Bus pretty heavily. We upgraded to 4.3 last week and I noticed since upgrading that we're not seeing any AsyncJobEvent messages. We see all the other

Re: Review Request 19917: Improvements on exception handlers (JIRA-6242)

2014-04-14 Thread Ding Yuan
Hi Daan,Sorry about that. Rebased my patch on the latest master. Attaching the patch. Please let me know if it still doesn’t work...thanks!Ding 0001-squash-6242-commits.patch Description: Binary data On Apr 14, 2014, at 3:04 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:thanks Ding,it doesn't

Re: AsyncJobEvents missing from Event Bus in 4.3

2014-04-14 Thread Kelven Yang
I was the original author for AsyncJob management and I wasn¹t aware of that there is a hook-up to EventBus? Kelven On 4/14/14, 1:37 PM, David Grizzanti david.grizza...@sungardas.com wrote: Hi All, I came across an issue this week that I wanted to see if anyone is aware of. Until recently

Network state machine

2014-04-14 Thread Alena Prokharchyk
Murali, I have a question to you. In NetworkOrchestrator, implementNetwork code, when we update the state for the network, why don¹t we use state machine for Shared networks, but instead update it directly in the DB? if (isSharedNetworkWithServices(network)) {

Review Request 20343: WIP: Force reload of the JS files only in MSIE

2014-04-14 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20343/ --- Review request for cloudstack. Repository: cloudstack-git Description

Re: [4.3] Wrong download template URL

2014-04-14 Thread Nux!
On 14.04.2014 20:51, Amogh Vasekar wrote: Hi, Is it an upgrade or a fresh 4.3 install for the other set-up you mentioned? If it is a fresh set-up, those fields should be NULL since we default everything to HTTP now. It's an upgrade from some 4.3 RC.. If I wanted to disable SSL altogether,

Systemvm.iso on kvm

2014-04-14 Thread Nitin Mehta
I am curious as to how does the systemvm.iso gets pushed onto the KVM host ? Lets say I upgrade from 4.2.1 to 4.3 and there is some ssvm agent code change, I would expect the new systemvm.iso getting pushed from MS to the KVM host and stop/start ssvm would have the new code into affect. I want

RE: [PROPOSAL] distributed routing and network ACL with OVS plug-in

2014-04-14 Thread Sanjeev Neelarapu
Hi, Following are the review comments on the FS: How many regions level vpcs we can create? Any limit on no.of tiers in each vpc(limit on no.of patch ports)? What are the admin APIs we are going to add for trouble shooting? How long the tunnels are active even though they are idle? Any

Review Request 20357: [CS-5907] [CS-6396] Fix for RBD (and potentially CLVM) volumes w/ KVM incorrectly identified as OVM volumes (not able to snapshot)

2014-04-14 Thread Tanner Danzey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20357/ --- Review request for cloudstack. Bugs: CLOUDSTACK-5907 and CLOUDSTACK-6396

Re: Review Request 20117: Pilot patch for CS JIRA 6213

2014-04-14 Thread Mandar Barve
Daan,Alena, 1. The pilot patch I posted already does this of checking the command level flag first and only for flagged commands check the list of sensitive parameters. I was wondering if that code itself, building list of sensitive parameters as a command can have more than one of these and then

Re: Review Request 19868: CLOUDSTACK-6287, CLOUDSTACK-6315 fixed password visible in plain text during some operation in hyperv

2014-04-14 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19868/ --- (Updated April 15, 2014, 4:45 a.m.) Review request for cloudstack, Devdeep

Re: Review Request 20343: WIP: Force reload of the JS files only in MSIE

2014-04-14 Thread Rajani Karuturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20343/#review40348 --- utils/src/com/cloud/utils/servlet/CacheControlUtil.java

Re: Review Request 20315: CLOUDSTACK-6401: [hyper-v] fixed correct host state in cloudstack if the hyper-v agent is down

2014-04-14 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20315/ --- (Updated April 15, 2014, 5:12 a.m.) Review request for cloudstack, Devdeep

RE: [PROPOSAL] Maven integration for windowsfication

2014-04-14 Thread Damoder Reddy
Ok to start with I will include it in the project and will remove it later to new project on github Thanks Regards Damodar/ -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Friday, April 4, 2014 2:43 PM To: dev Subject: Re: [PROPOSAL] Maven integration for

Re: Review Request 19917: Improvements on exception handlers (JIRA-6242)

2014-04-14 Thread Daan Hoogland
it applies, I won't push it like this though. The comment says 'squash 6242 commits' so i will take the liberty of changing it to something like 'CLOUDSTACK-6242: exception handling improvements'. Also I'd appriciate it if you upload to reviewboard next time. This make reviewing easier for me.