[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/292 CLOUDSTACK-8506 - Make ACS compliant with the RFC 3021 Hi @bhaisaab and @DaanHoogland Could you please have a look at this PR and also at the RFC 3021? It allows us to h

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/292#discussion_r30943135 --- Diff: utils/src/com/cloud/utils/net/NetUtils.java --- @@ -329,35 +329,46 @@ public static String getMacAddress(InetAddress address) {

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/292#discussion_r30943140 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3556,6 +3556,11 @@ private void checkPublicIpRangeErrors(long zone

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/292#issuecomment-104865612 hard to review this, @wilderrodrigues I made one comment on the logic. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: ui: add custom error handling page

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/256#issuecomment-104867025 thanks @bhaisaab nice alias albeit of the write once read never kind, it works ;) --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/292#discussion_r30943291 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3556,6 +3556,11 @@ private void checkPublicIpRangeErrors(long z

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/292#discussion_r30943304 --- Diff: utils/src/com/cloud/utils/net/NetUtils.java --- @@ -329,35 +329,46 @@ public static String getMacAddress(InetAddress address) {

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/292#issuecomment-104871245 @DaanHoogland , I also commented on your comments. Which bit is hard to review? Put a lot of test results and also did the manual tests for the publi

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/292#issuecomment-104871936 the pr contains a lot of added final keywords, more then actual code. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/292#issuecomment-104872293 Ah, indeed. There is the logic you mentioned in the previous comment and 1 added call to NetUtils.isIpWithtInCidrRange() line 1509 which is:

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/292#discussion_r30943403 --- Diff: utils/src/com/cloud/utils/net/NetUtils.java --- @@ -329,35 +329,46 @@ public static String getMacAddress(InetAddress address) {

[GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/292#discussion_r30943691 --- Diff: utils/src/com/cloud/utils/net/NetUtils.java --- @@ -329,35 +329,46 @@ public static String getMacAddress(InetAddress address) {

Build failed in Jenkins: build-master-jdk18 #73

See Changes: [wrodrigues] CLOUDSTACK-8506 [wrodrigues] CLOUDSTACK-8506 -- [...truncated 2607 lines...] [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugi

[GitHub] cloudstack pull request:

Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/1c408dec37a278c97c1b40da0bdbca437d7a564c#commitcomment-11339020 In packaging/centos63/cloud.spec: In packaging/centos63/cloud.spec on line 273: Hi again @DaanHoogland :) This o

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8502 Improvement/annotations k...

Hoi Rafael, Perhaps that's an intermittent test error based on the random order that packages are loaded. Anyway, if you got it working without problems, feel free to fix and send a PR! I really appreciate you looking after those things. :) Once your PR is through I will have a look and merge

[GitHub] cloudstack pull request: Fix xenserver tests for travis

GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/293 Fix xenserver tests for travis Fix ClassCast exception being thrown due to recursive scan in com.cloud.hypervisor.xenserver.resource.wrapper picking up subpackage modules for running the cit

[GitHub] cloudstack pull request: CLOUDSTACK-8502 Improvement/annotations k...

Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/280#issuecomment-104901705 Hoi @wilderrodrigues :) I've created a pull request for it, have a look https://github.com/apache/cloudstack/pull/293 glad to help :) ---

[GitHub] cloudstack pull request: CLOUDSTACK-8502 Improvement/annotations k...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/280#issuecomment-104903208 Awesome. Will look/merge it once behind the computer. Thanks again. Cheers, Wilder Sent from my iPhone On 23 M

Re: [GitHub] cloudstack pull request: Fix xenserver tests for travis

Testing it. Thanks, Rafael! Cheers, Wilder Sent from my iPhone > On 23 May 2015, at 16:19, rsafonseca wrote: > > GitHub user rsafonseca opened a pull request: > >https://github.com/apache/cloudstack/pull/293 > >Fix xenserver tests for travis > >Fix ClassCast exception being thr

Re: IPv6 ideas for Basic Networking

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/22/2015 11:05 PM, server24 Cloudstack wrote: > Hi Wido, > > was nice talking to you about this. > > On 5/21/2015 8:59 PM, Wido den Hollander wrote: > >> (IPv6) routers should send out RAs (Router Advertisements) with >> the managed-other-fla

[GitHub] cloudstack pull request: Fix xenserver tests for travis

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix xenserver tests for travis

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/293#issuecomment-104913335 Thanks, @rsafonseca ! Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: CLOUDSTACK-6181 Specify GB for the value ...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/294 CLOUDSTACK-6181 Specify GB for the value of rootdisksize parameter. Add some Bytes/GB for log or exception messages. Fix Gb->GB. The new behavior (since 4.4) rootdisksize for KVM hypervise

[GitHub] cloudstack pull request: CLOUDSTACK-6181 Specify GB for the value ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack-docs-rn pull request: add note on XenServer: we depend ...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/21 add note on XenServer: we depend on pool HA these days Add note that we need HA on the pool in XenServer in order to recover from a pool-master crash. We may want to add this

[GitHub] cloudstack-docs-rn pull request: add note on XenServer: we depend ...

Github user xenserverarmy commented on the pull request: https://github.com/apache/cloudstack-docs-rn/pull/21#issuecomment-104945193 I agree that we should add this to the 4.4 and 4.5 notes, but would suggest an addition relating to the config-timeout. The default has changed with Xe

Re: IPv6 ideas for Basic Networking

Did you guys review the functional spec that has been floating around on cwiki? On May 23, 2015 8:27 AM, "Wido den Hollander" wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > > On 05/22/2015 11:05 PM, server24 Cloudstack wrote: > > Hi Wido, > > > > was nice talking to you about this

Re: IPv6 ideas for Basic Networking

At Schuberg Philis we’ve been working on a design voor IPv6 in VPC networks (so this is Advanced Networking) and I indeed had a look at your functional spec. I’ll finalise what we’ve come up with and publish it early next week so we can align and discuss and work from there. Nice to see there is

[GitHub] cloudstack-docs-rn pull request: add note on XenServer: we depend ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack-docs-rn/pull/21#issuecomment-104984303 @xenserverarmy thanks, I wanted to keep it simple and not rewrite the XenServer docs inside the CloudStack ones. BUT you're right, the timeout is not docu