Re: [GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...

You are right Wido. It is only a test case change to handle volume cleanup. On Tue, Jul 14, 2015 at 11:43 AM, wido wrote: > Github user wido commented on the pull request: > > https://github.com/apache/cloudstack/pull/481#issuecomment-121140868 > > The description of the pull request isn

Re: [GitHub] cloudstack pull request: Newb

LGTM!! On Tue, Jul 14, 2015 at 11:47 AM, pavanb018 wrote: > GitHub user pavanb018 opened a pull request: > > https://github.com/apache/cloudstack/pull/581 > > Newb > > Test Create/Delete a LB rule and verify correct usage is recorded ... > === TestName: test_01_lb_usage | Status : SU

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/582 CLOUDSTACK-8581: S3, make connection TTL and TCP KeepAlive configureable Signed-off-by: Wido den Hollander You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-121150878 Hi @wido , On this comment https://github.com/apache/cloudstack/pull/372#issuecomment-110239298 I suggested that the PR should be split so we could

[GitHub] cloudstack pull request: Newb

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/581#issuecomment-121151295 :-1: What does a "Newb" as the PR title means? We are trying to organise the way we work and avoid such PR titles. Please create an

Github not syncing?

Hi, Since past 2 hours, I’ve been waiting to send a PR but could not as my source branch is on ACS repo itself. Looks like the gh mirror it’s not syncing, anyone else experiencing this issue? Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +9

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/583 CLOUDSTACK-8457: SAML UI Dialog fixes to use local $form This uses local selector to access the DOM elements, the previous commit would find a global element which is not in the context and

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/583#issuecomment-121153413 cc @abhinandanprateek @wilderrodrigues @jburwell and others --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/481#issuecomment-121159832 In that case LGTM Next time try to be more descriptive, since the Jira issue didn't show it either. I really didn't know what you meant. --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-8630: Fix for missing Firewall...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/581#issuecomment-121164744 Created an ACS ticket describing the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Coverity regressions

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/584 Coverity regressions three new issues pertaining to too generic exception handling You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanH

Re: capitalized method name

thanks, i made https://github.com/apache/cloudstack/pull/584 On Tue, Jul 14, 2015 at 5:45 AM, Jayapal Reddy Uradi wrote: > Hi Daan, > > Please go ahead and change the name. > Thanks for notifying. > > -Jayapal > > > On 13-Jul-2015, at 8:45 PM, Daan Hoogland wrote: > >> Jayapal, >> >> I didn't no

[GitHub] cloudstack pull request: CLOUDSTACK-8630: Fix for missing Firewall...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/581#issuecomment-121171768 Thanks for the quick fix, @pavanb018 Now it LGTM :+1: Please proceed with the merge. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: This branch implements the CSV and native...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-121174974 @runseb These are false failures. The changes on which these tests are failing are in Hyper-V agent so can be safely ignored as these tests are not testing Hyper-

[GitHub] cloudstack pull request: Coverity regressions

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/584#issuecomment-121177268 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/585 CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limit… test result Test Try to deploy VM with admin account where account has not used ... === TestName:

[GitHub] cloudstack pull request: Coverity regressions

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/584#issuecomment-121183714 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

Re: Jenkin automated job to create release package

Hi, On 10-07-15 20:17, Pierre-Luc Dion wrote: > Hi, I've create a collection of jenkins jobs [1] allowing to create > packages of a release and publish them on cloudstack.apt-get.eu so > current community yum and apt repos get updated. > > I've also add pgp signature[2] for RPM's and generate MD5

Build failed in Jenkins: simulator-singlerun #1362

See -- Started by upstream project "build-master-simulator" build number 2179 originally caused by: Started by an SCM change Started by upstream project "build-master" build number 2465 origin

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/582#discussion_r34553635 --- Diff: plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java --- @@ -60,7 +60,9 @@ public DataS

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/582#issuecomment-121191099 logic looks good with respect to the functional description. could do with tests --- If your project is set up for it, you can reply to this email and have you

Re: Github not syncing?

this happens once in a while. better send your branch to your fork and create the PR. I merged some and they don't get updated either. If it takes to long I think we need to ask infra. On Tue, Jul 14, 2015 at 9:33 AM, Rohit Yadav wrote: > Hi, > > Since past 2 hours, I’ve been waiting to send a

[GitHub] cloudstack pull request: CLOUDSTACK-8630: Fix for missing Firewall...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/581#issuecomment-121195598 Committed to ACS master: commit 03e8176baba43f0394d530e64e7f96d6c841e9b2 Author: pavan018 Date: Mon Jul 13 18:11:24 2015 +0530 Passing fi

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/582#discussion_r34554904 --- Diff: plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java --- @@ -60,7 +60,9 @@ public DataStoreTO g

[GitHub] cloudstack pull request: CLOUDSTACK-8630: Fix for missing Firewall...

Github user pavanb018 closed the pull request at: https://github.com/apache/cloudstack/pull/581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Build failed in Jenkins: simulator-singlerun #1363

See -- Started by upstream project "build-master-simulator" build number 2180 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by an SC

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

you can add that commit here for my part, please don't squash it;) On Tue, Jul 14, 2015 at 12:30 PM, wido wrote: > Github user wido commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/582#discussion_r34554904 > > --- Diff: > plugins/storage/image/s3/src

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/585#issuecomment-121210285 Can you please specify the reason for changing the if condition for the benefit of others? --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/585#issuecomment-121210527 its there in ticket On Tue, Jul 14, 2015 at 5:03 PM, sanju1010 wrote: > Can you please specify the reason for changing the if condition for t

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/585#issuecomment-121211124 I agree with Sanju. please ammend to something like CLOUDSTACK-8631: changing if condition to update to zero when needed --- If your project is set up for

cannot login to UI - MS log shows Failed to start bean "cloudStackLifeCycle" error

Hi, Using Master builds, MS logs shows following error - "management-server.log:org.springframework.context.ApplicationContextException: Failed to start bean 'cloudStackLifeCycle'; nested exception is com.cloud.utils.exception.CloudRuntimeException: Failed to inject generated public key into sy

[DISCUSS] PR list length

H, It is a concern to me that the list of PRs on our github page is beyond a single page (maybe configurable but now a t a very reasonable 25). I think we should adhere to a discipline of not having any PRs open after the weekend. This is putting a very strong statement outthere, I realize. A PR m

Re: [DISCUSS] PR list length

On 14-Jul-2015, at 5:26 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: H, It is a concern to me that the list of PRs on our github page is beyond a single page (maybe configurable but now a t a very reasonable 25). I think we should adhere to a discipline of not having any PRs open a

file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

hi: I install management and agent on the same vm. When I install agent as : " yum install cloudstack-agent " , get the following messages file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package clou

Re: [DISCUSS] PR list length

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14-07-15 13:56, Daan Hoogland wrote: > H, > > It is a concern to me that the list of PRs on our github page is > beyond a single page (maybe configurable but now a t a very > reasonable 25). I think we should adhere to a discipline of not > ha

RE: [DISCUSS] PR list length

For bug fixes I feel 1 LGTM should be fine provided there is a Jira ticket with all details and the request is pending for more than a specified time (may be 7 days). For new features the existing process should be fine. -Original Message- From: Wido den Hollander [mailto:w...@widodh.nl]

[GitHub] cloudstack pull request: CLOUDSTACK-8634: Made changes to test_sec...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/586 CLOUDSTACK-8634: Made changes to test_security_group.py test suite to support EIP Made changes to test_security_group.py test suite to support EIP 1. In case of a basic zone with

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/582#issuecomment-121226423 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPR with both ...

GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/587 CLOUDSTACK-8616: Redundant VPR with both routers as Master This PR contains some refactoring of the Python code used by the redundant routers and also a fix for the intermittent problem

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/583#issuecomment-121236324 LGTM :+1: Also talked to @bhaisaab on Slack about the 2 accountsWizard.js just to get some context. Cheers, Wilder --- If your projec

Re: CS 4.3.2 RPM builds have dependencies on i686 glibc?! while 4.3.1 do not.

No, it has not beed fixed AFAIK. This is not an issue per se. It is just a unnecessary dependencies, for i686 architecture. All the packages, no matter which repo, have the same issue, starting from 4.3.2. Seems no one cares, as with all issues I have submitted.The only guy who has ever responde

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14-07-15 14:11, lavaf...@163.com wrote: > > hi: > > I install management and agent on the same vm. When I install agent > as : " yum install cloudstack-agent " , get the following > messages > > file /var/log/cloudstack/agent from install of

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

Its probably the issue i fixed in this PR -> https://github.com/apache/cloudstack/pull/329 It was only merged on 4.4 On Tue, Jul 14, 2015 at 3:37 PM, Wido den Hollander wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > > On 14-07-15 14:11, lavaf...@163.com wrote: > > > > hi: > > > >

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14-07-15 16:42, Rafael Fonseca wrote: > Its probably the issue i fixed in this PR -> > https://github.com/apache/cloudstack/pull/329 It was only merged on > 4.4 > It is also in master, but probably not in 4.5.1. That's the problem. Wido > On

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/587#discussion_r34579273 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py --- @@ -35,10 +35,9 @@ def load(self): self.new_config.append(lin

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/587#discussion_r34579656 --- Diff: systemvm/patches/debian/config/opt/cloud/templates/check_heartbeat.sh.templ --- @@ -47,13 +47,14 @@ then if [ $s -gt 2 ] then

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/587#discussion_r34578120 --- Diff: systemvm/patches/debian/buildsystemvm.sh --- @@ -375,8 +375,10 @@ packages() { chroot . apt-get --no-install-recommends -q -y --force-yes

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

You may use one of the following el6/7 repo, I believe it won’t cause the specific issue you’re facing: http://packages.shapeblue.com/cloudstack/upstream/centos/4.5/ http://packages.shapeblue.com/cloudstack/upstream/centos7/4.5/ On 14-Jul-2015, at 5:41 pm, lavaf...@163.com

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/14/2015 05:30 PM, Rohit Yadav wrote: > You may use one of the following el6/7 repo, I believe it won’t > cause the specific issue you’re facing: > > http://packages.shapeblue.com/cloudstack/upstream/centos/4.5/ > http://packages.shapeblue.com

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/587#discussion_r34586102 --- Diff: systemvm/patches/debian/buildsystemvm.sh --- @@ -375,8 +375,10 @@ packages() { chroot . apt-get --no-install-recommends -q -y --fo

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/587#discussion_r34588816 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py --- @@ -35,10 +35,9 @@ def load(self): self.new_config.app

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/587#discussion_r34589895 --- Diff: systemvm/patches/debian/config/opt/cloud/templates/check_heartbeat.sh.templ --- @@ -47,13 +47,14 @@ then if [ $s -gt 2 ]

Re: [DISCUSS] Moving to Java 8

Wido, Is the OpenJDK PPA [1] not acceptable? Since Java7 is no longer supported, we run the risk of an Java security issue affecting the project that won’t be fixed. Thanks, -John [1]: https://launchpad.net/~openjdk-r/+archive/ubuntu/ppa --- John Burwell (@john_burwell) VP of Software Engine

Re: [DISCUSS] Moving to Java 8

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/14/2015 10:18 PM, John Burwell wrote: > Wido, > > Is the OpenJDK PPA [1] not acceptable? Since Java7 is no longer > supported, we run the risk of an Java security issue affecting the > project that won’t be fixed. > I didn't know that a PPA

[PROMOTE] CloudStack Silicon Valley User Group Meetup - August 4th, 2015

Hi all, If you’re going to be in the Silicon Valley on August 4th - then join us! The next CloudStack Silicon Valley Meetup has been scheduled for Tuesday, August 4th at the Citrix Startup Accelerator in Santa Clara, CA. David Nalley will be presenting "Jenkins + jclouds + CloudStack = On-demand C

Re: Jenkin automated job to create release package

I've updated jenkins jobs for release to put rpms in centos/{6|7} instead of centos7|rhel although, centos/6 differ from rhel folder and documentation refer to URL with rhel, so should we replace centos/6 content by rhel and make rhel a symlink ? For debian, the build create a set of .deb files a

[GitHub] cloudstack pull request: CLOUDSTACK-8635: Depend on the headless J...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/588 CLOUDSTACK-8635: Depend on the headless JRE for Ubuntu packages This will install less packages on the system running CloudStack. The -headless JRE doesn't include packages for running on d

[GitHub] cloudstack pull request: CLOUDSTACK-8580

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/589 CLOUDSTACK-8580 CLOUDSTACK-8580 Users are now able to view, expunge and recover their vm's themselves. Two configuration options are added to allow this behaviour on a global or per account

[GitHub] cloudstack pull request: CLOUDSTACK-8580

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/589#issuecomment-121414567 The pull request is against the 4.5 branch while it should be against the master branch. We can't merge it into 4.5. Also, you seem to change more then the issu

Re: Jenkin automated job to create release package

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/14/2015 11:40 PM, Pierre-Luc Dion wrote: > I've updated jenkins jobs for release to put rpms in centos/{6|7} > instead of centos7|rhel although, centos/6 differ from rhel folder > and documentation refer to URL with rhel, so should we replace

Git Rebase Question

Hi everyone, I have a Git question that relates to a rebase problem I've been seeing. I have a branch I've been working on the past six or seven weeks. As you'd expect, every now and then I update my local 4.5 branch from the upstream CloudStack one and perform a rebase. The weird part is that

packaging/package.sh not in 4.5?

Hi, I was going to build centos7 RPM's for acs 4.5.1 but we can't! packaging/package.sh and packaging/centos7 are absent from 4.5 branch. Was that voluntarily avoid in 4.5 as it is in 4.4 and master ? Just to know because the 4.5.1 release note refer centos 7 as supported OS for cloudstack-mana

Re: [4.5] Issue logging in under User account

OK, I had a bit of time to debug this more today. As it turns out, it was my bad. I was throwing an exception when checkAccess in my API plug-in didn't wish to allow the user to leverage the specific operation, but I should have been returning false. All is well with this now. :) On Fri, Jul 10

Re: packaging/package.sh not in 4.5?

On 15-Jul-2015, at 7:34 am, Pierre-Luc Dion mailto:pdion...@apache.org>> wrote: Hi, I was going to build centos7 RPM's for acs 4.5.1 but we can't! packaging/package.sh and packaging/centos7 are absent from 4.5 branch. Was that voluntarily avoid in 4.5 as it is in 4.4 and master ? Just to know

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

LGTM!! On Tue, Jul 14, 2015 at 5:08 PM, DaanHoogland wrote: > Github user DaanHoogland commented on the pull request: > > https://github.com/apache/cloudstack/pull/585#issuecomment-121211124 > > I agree with Sanju. please ammend to something like > CLOUDSTACK-8631: changing if condit

[GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/590 CLOUDSTACK-8632: Unable to revert snapshot on XenServer On XenServer check that volume snapshot fails for the ROOT volume of VM which has VM snapshot created. You can merge this pull requ

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/591 CLOUDSTACK-8633: Changing file permissions from 755 to 440 With 0755 permissions on /etc/sudoers.d/cloudstack-management we are getting following error in bringing up CS: Failed to start b

[GitHub] cloudstack pull request: CLOUDSTACK-8635: Depend on the headless J...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/588#issuecomment-121510209 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this