Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

What I mean to say is that unit test are meant to test individual unit which here is getPatchFilePath and not meant to test hierarchy as you are pointing out here. By individual unit I mean it doesn’t matter for test that it is in class A or class B. This way you are kind of justifying that we s

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/625#issuecomment-132472682 @runseb Yes, indeed. But the PR is not ready to merge yet, it's blocked by a GSON issue which I don't know how to resolve. This is what @DaanHoogland found out:

Re: Review PRs: please help!

Hi, Understood :) I'm trying, but most PRs are VMWare or Xen and I personally don't know anything about that code, so I don't feel good in giving in LGTM on such a PR. This is from my personal view, but I only want to give a LGTM on code I understand. KVM and RBD storage PRs? Happy to review the

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-132476722 test result of enough storage is not available to perform test put storage in maintenance mode and start ha vm and check usage ... SKIP: sufficient s

Re: Review PRs: please help!

Hello Wido, PR from me are on the localization and web UI, easy to review ;-) https://github.com/apache/cloudstack/pull/697 https://github.com/apache/cloudstack/pull/699 https://github.com/apache/cloudstack/pull/712 Milamber On 19/08/2015 08:22, Wido den Hollander wrote: Hi, Understood :)

[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/716 Changed AddressFormat elements to reflect changes in IPv4 and IPv6 refactor. See issue CLOUDSTACK-8736 for ongoing effort to clean up network code. You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-132482850 @DaanHoogland @kishankavala Have made changes regarding allowing the duplicate keys for different accounts. DB checks are additional checks and API level checks are d

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/699#discussion_r37388778 --- Diff: client/WEB-INF/classes/resources/messages_es.properties --- @@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-132484646 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/712#issuecomment-132484500 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/699#discussion_r37389129 --- Diff: client/WEB-INF/classes/resources/messages_es.properties --- @@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, sa

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/699#issuecomment-132485606 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/699#discussion_r37389322 --- Diff: client/WEB-INF/classes/resources/messages_es.properties --- @@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-132488846 @kishankavala @DaanHoogland Can any of you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Jenkins build is back to normal : build-master-slowbuild #2095

See

[GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/699 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/697 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-132494328 I merged this only to 4.5. I though merge to master is not required based on #699. Let me know if this needs to go to master as well. --- If your project is set u

[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/716#issuecomment-132497888 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.2

-1 (binding) Based on a recent PR discussion, found that a regression in CM 5.3.2 RC1 where public keys etc were double encoded. That commit is reverted now. Due to this and also the end of the voting window, I’m calling off this round and starting a new round. On 14-Aug-2015, at 5:00 pm, Raja

Build failed in Jenkins: simulator-4.5-singlerun #261

See -- Started by upstream project "build-4.5-simulator" build number 316 originally caused by: Started by upstream project "build-4.5" build number 512 originally caused by: Started by an

[VOTE] Release Apache CloudStack CloudMonkey 5.3.2 (Round 2)

Hi All, I've created a 5.3.2 release of CloudMonkey, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shortlog;h=refs/heads/master Commit: 653dcca9e008e20fee83f0b40f388611ad931d15 List of changes: https:/

Re: [VOTE] Apache Cloudstack 4.5.2

Due to not enough votes and testing efforts for this RC to be passed, and a recent useful commits on 4.5 (translations and router migration related: https://github.com/apache/cloudstack/commit/b655104b77286889cc849a5bad4fcceb38234606) I’m calling this round off. Will start a new round now. On

[VOTE] Apache Cloudstack 4.5.2 (Round 2)

Hi All, I've created a 4.5.2 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Commit: 7385441807ba3fde3d45c226df6b1bdd2f36ae26 Tag: 4.5.2-rc2 List of changes: https:

Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.2 (Round 2)

+1 (binding) Tested to deploy KVM zones using an existing cloudmonkey/bash script, and tested to register ssh public keys. On 19-Aug-2015, at 2:39 pm, Rohit Yadav mailto:rohityada...@gmail.com>> wrote: Hi All, I've created a 5.3.2 release of CloudMonkey, with the following artifacts up for a

Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)

+1 (binding) Tested against KVM (Ubuntu 14.04, Ubuntu 14.10 and CentOS 6.5 based hosts), tested local storage, VM migrations and basic network (with/without SG) and adv network (pf and firewall rules). Upgraded to 4.5.2-rc2, running a local cloudstack/KVM deployment with 4.5.2-rc1 since last 5

Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)

+1 again We are running 4.5.2 build from Git in production and it is working properly. On 19-08-15 11:22, Rohit Yadav wrote: > Hi All, > > I've created a 4.5.2 release, with the following artifacts up for a vote: > > Git Branch and Commit SH: > https://git-wip-us.apache.org/repos/asf?p=cloudsta

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-132515960 Thanks for the merge. yes not necessary, the PR #699 make the works for master branch. --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/717 CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and Re… …vertToVMSnapshotCommand This patch makes it possible to expose VM UUID to subsystems, this can be useful

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/718 CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names This tries to avoid cleaning by a device name. You can merge this pull request into a Git repository by running: $ git pul

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/715#issuecomment-132530052 travis builds, awaiting analysis build but LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/715#issuecomment-132532173 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

a unit can be defined at more then just the method level and in this case those paths have changed from under us in the past. I am not justifying testing any constant this way. I am justifying just this work. On Wed, Aug 19, 2015 at 9:03 AM, Anshul Gangwar wrote: > What I mean to say is that uni

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[DISCUSS] apache builds vs reviews

LS, I have disabled cloudstack-pull-request on builds.apache.org as we now have cloudstack-pull-rat and cloudstack-pull-analysis and also still have jenkins.bac.o. I want to further unburdon the apache jenkins web by scheduling down other jobs to once a day. noticably this is the master build but

Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

@anshul1886 I totally agree with you that tests are meant to test individual, and as you pointed the individual code that we want to test is “getPatchFilePath”. However, that method is abstract, and its “implementation” that is as simple as returning a constant, changes in few subclasses of CitrixR

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132540113 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132550029 @rafaelweingartner I like it! For me it simply proves that the paths are still the same after your change. If the paths need to be changed, we'll update the test

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/665#issuecomment-132555104 Test result: Test multiple volume snapshot in zwps ... === TestName: test_01_multiple_snapshot_in_zwps | Status : SUCCESS === ok --

Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Can you point to any reference/blog which justifies writing tests for this kind of scenario? What I can infer from these tests is that that there are two scenarios 1) Method will not change In that case it doesn’t make sense to put test for never changing method. 2) Method will change In

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/665#issuecomment-132573747 @nitt10prashant Can you please review this PR again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Let me summarise the tests class A { x(){ return “d”; a constant } } test p=“d” Assert( A.x() = p) Which can be reduced to class A { q=“d"; } Here q is replacement for x method as it is only returning a constant now test is p=“d" assert (p=q) To me this basically proves that java assignment

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/665#issuecomment-132583048 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

@anshul1886 I agree that we disagree. Folks I do not know what to do in this case, I will not looking for references to support what I said and did. Whatever you guys decided I will do (remove or let the test cases there). On Wed, Aug 19, 2015 at 9:47 AM, Anshul Gangwar wrote: > Let me summaris

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user pedro-martins closed the pull request at: https://github.com/apache/cloudstack/pull/714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Anshul, I do not think a reference for the intricate problems we face with the hierarchy of the CitrixResourceBase and descendants is fair to ask. I think the burdon of proof is with you and not Rafael. The tests do not just prove that the assignment works as in you example. They prove that the fr

[GitHub] cloudstack pull request: Apply RHEL 7 fix for comounted cgroups to...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/719 Apply RHEL 7 fix for comounted cgroups to CentOS 7 KVM hypervisors as well The RHEL 7 version string is hard coded and misses CentOS 7. You can merge this pull request into a Git repository

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/720 CLOUDSTACK-8308: Adding automation testcases for Delta Snapshot. CLOUDSTACK-8308: Updating automation testcases for Delta Snapshot testpath. Reference to #384 You can merge this pull

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-132630872 This closes #384. Squashed to commits into 1 as requested per comment. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/384#issuecomment-132631777 See #720 -> Resolved comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-132631927 @remibergsma @bhaisaab Any more comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Apply RHEL 7 fix for comounted cgroups to...

Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/719#issuecomment-132636109 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Apply RHEL 7 fix for comounted cgroups to...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/719#issuecomment-132636564 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...

GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/721 Add scripts to merge PRs and release fixes forward As it is now, additions to CloudStack need to go through a GitHub PR and, if accepted, merged to the Apache remote (not in GitHub). Thi

Merging Pull Requests

Hi all, As it is now, additions to CloudStack need to go through a GitHub PR and, if accepted, merged to the Apache remote (not in GitHub). This means that merging a PR for CloudStack is a bit more involved than merging a normal GitHub PR. To help with this, Miguel, Rajani, Daan and myself, hav

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/718#issuecomment-132639320 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/718#issuecomment-132642477 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/716#issuecomment-132643862 @borisroman If I run this `grep -r Ip4 *` I see many references to `Ip4`. Isn't this going to be confusing to rename a part of it only? Or am I missing something

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/718#issuecomment-132644284 @bhaisaab Let's make sure this ends up in master as well! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Apply RHEL 7 fix for comounted cgroups to...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-132645009 @borisroman Can you add the test output please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/716#issuecomment-132646596 @remibergsma You are correct. Those are all not related to the AddressFormat enum. Of course all should be renamed, but doing so in 1 time will also will not bene

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132647888 @kishankavala Thanks for the update! When you're ready, also be sure to ping @wido so he can have another look. --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132653773 @rafaelweingartner I think it's good that you wrote the unit tests, and I actually wished people were a bit more supportive. I strongly agree with @remibergsma. I think

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-132654938 @DaanHoogland I agree with your considerations. My first commit was not performed properly. Sadly, the eclipse ended up formatting classes I touched, and that

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-132662044 @pedro-martins your motivation makes sense to me, can you create a jira ticket and c&p it there? then use that as a tag for any commits (including cleanup/autof

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/718#issuecomment-132667999 @remibergsma thanks, done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/718#discussion_r37435429 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java --- @@ -287,7 +287,7 @@ private void deleteExitingLinkLocal

Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Please mention lines in tests which is justifying your statement "They prove that the fragile integrity of the class hierarchy that has been meddled with so often is still intact” I have no problem with solution. I have problem with tests. For reference see section Superficial Test Coverage @

Build failed in Jenkins: build-4.5 #513

See Changes: [Rohit Yadav] CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names -- [...truncated 2792 lines...] [INFO] Compiling 7 source files to

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/718#discussion_r37437656 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java --- @@ -287,7 +287,7 @@ private void deleteExitingLinkLocal

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132697192 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-132698414 Got your comments, sadly we have not analyzed which classes are singleton or not. We have opened a jira ticket to that: https://issues.apache.org/jira/brow

[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132706089 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Build failed in Jenkins: build-master-noredist #4547

See Changes: [github] CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and RevertToVMSnapshotCommand -- [...truncated 10408 lines...] [INFO] [INFO] --- maven-jar-plugin

Jenkins build is back to normal : build-4.5 #514

See

Build failed in Jenkins: simulator-4.5-singlerun #262

See -- Started by upstream project "build-4.5-simulator" build number 317 originally caused by: Started by upstream project "build-4.5" build number 514 originally caused by: Started by an

Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Manual assertions are not in play. These are not in the tests. Regular assertEquals calls are made. Investigating the hierarchy once again to give you a reference I found one thing that is less then optimal with them. The tests are in testclasses not generic to the tested resources: XcpOssResource

Build failed in Jenkins: build-master-jdk18 #293

See Changes: [github] CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and RevertToVMSnapshotCommand -- [...truncated 2601 lines...] Results : Tests run: 10, Failures: 0, E

Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)

Hello, +1 (binding) * Building CloudStack ubuntu packages from Git 4.5.2 RC2 tag. * Tests migration from 4.4.4 -> 4.5.2rc2 on Ubuntu 14.04.3 (1 mgr, 2 nodes, 1 nfs), basic install, NFS storage, KVM, SystemVM shapeblue, After migration: some tests on HA (crash node), some tests with templates

Build failed in Jenkins: simulator-4.5-singlerun #263

See -- Started by upstream project "build-4.5-simulator" build number 318 originally caused by: Started by upstream project "build-4.5" build number 515 originally caused by: Started by an

Build failed in Jenkins: build-master-slowbuild #2099

See Changes: [github] CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and RevertToVMSnapshotCommand -- [...truncated 9974 lines...] [INFO] [INFO] --- maven-resources-

Build failed in Jenkins: build-master-slowbuild #2100

See -- [...truncated 9974 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Usi

[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132813609 LGTM We've tested the git-pr script with #705 #709 #708. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Build failed in Jenkins: build-master-slowbuild #2101

See -- [...truncated 9974 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Usi

[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132877083 Thanks for the scripts @miguelaferreira and @remibergsma. It makes merging( and closing) PRs very easy. I also used this script to merge doc prs at [apache/cloudsta

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132879424 master build broken with the below error http://jenkins.buildacloud.org/job/build-master-slowbuild/2101/consoleText ``` [INFO] --

Build failed in Jenkins: build-master-slowbuild #2102

See -- [...truncated 9974 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Usi

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132897134 @karuturi I reverted the commit to master (044e685c92ef98d08771f04c766ec42d97fe5c35) --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132898937 LGTM, I used it to merge this PR ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132899406 Thanks @remibergsma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

Jenkins build is back to normal : build-master-noredist #4548

See

Re: [DISCUSS] apache builds vs reviews

pull-rat doest the rat check pull-analysis does a roredist build and unittests after applying the pr. I dont know what pull-request does. So, I am ok with disabling it :) The problem I see with these jobs is that, it only informs me of a success or a failure once its done. There is no inprogress i

Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)

+1(binding) tested fresh install on xenserver 6.5 advanced zone setup. register template, create network, launch vm, view console etc. worked fine. ~Rajani On Thu, Aug 20, 2015 at 12:04 AM, Milamber wrote: > Hello, > > +1 (binding) > > * Building CloudStack ubuntu packages from Git 4.5.2 RC2

Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.2 (Round 2)

+1 (binding) built from source, could deply vm, create disk, attack disk, list vms etc. ~Rajani On Wed, Aug 19, 2015 at 2:55 PM, Rohit Yadav wrote: > +1 (binding) > > Tested to deploy KVM zones using an existing cloudmonkey/bash script, and > tested to register ssh public keys. > > > On 19-Aug