[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/820 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-140983817 @borisroman Please ping me if this PR is ready to be tested. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-140984295 @remibergsma I tested it on my local setup and worked fine. Maybe you can also check to make sure I haven't missed anything. --- If your project is set up for it,

Re: VPC router issue

Hi Rajani, The last commit from 8 September works: https://github.com/apache/cloudstack/commit/5e9e9b84fb1a4ca029c32e5b1c305124bfa4d4af The merge commit just before the 5e9e9b does NOT work: https://github.com/apache/cloudstack/commit/237e0e4611dd3d0ae56a8c0557dba93e7fbd3440 And the commit

Re: VPC router issue

Issue is here: https://issues.apache.org/jira/browse/CLOUDSTACK-8878 Cheers, Wilder On 17 Sep 2015, at 10:14, Wilder Rodrigues > wrote: Hi Rajani, The last commit from 8 September works:

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/845#discussion_r39714178 --- Diff: engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java --- @@ -282,6 +289,14 @@ public IPAddressVO findByVmIp(String vmIp) {

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140983520 @resmo You're right and I wasn't clear enough I guess. Because I think the 'PowerReportMissing' comes from the VM on the hypervisor that you are migrating _to_,

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/790#issuecomment-140999446 @remibergsma Yes this one should be closed. PR #775 does the same thing. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/842#issuecomment-141001813 Thanks, @jayapalu I will try to take some time today to test your PR. Cheers, Wilder --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8872: Replaced all occurences ...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/832#issuecomment-141002870 Thanks, @borisroman ! :) I will have a look at your PR again later today. Cheers, Wilder --- If your project is set up for it, you can

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141022408 @remibergsma @wilderrodrigues @karuturi Please review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141050957 If @remibergsma is right then the design is really broken. two events come in during migration: # PowerOn (or Off or what ever is actual) #

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-141051316 @ustcweizhou @miguelaferreira @karuturi @remibergsma so no merges till this is fixed? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-141052485 @ustcweizhou , Which tests did you execute? I would say: no merge until it's fixed, tested by @ustcweizhou and he let us know how we should

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-141056052 in general: factor out a small chunk of the method into a private method or helper class. (commit 1) then unit test that. (commit 2) then apply your fix

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141057501 @borisroman there are no (unit) tests. can you add or describe or at least how to prove this fix? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-141058143 @wilderrodrigues that is not fair, it is not @ustcweizhou 's bug that needs fixing! --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-141059487 @DaanHoogland @wilderrodrigues @ustcweizhou I agree with Daan, the problem is most likely elsewhere. But I also agree with Wilder, first we need to figure

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141059956 @DaanHoogland That was also one of my questions on Slack. There are no Unit tests regarding Dao classes in /cloud-engine-schema/test/. So how do I test these?

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141061213 @borisroman so please add a description of your manual test scheme in the description area of this PR ( and help us think of a better dao implementation ;)

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/835#issuecomment-141004854 I agree with @DaanHoogland That should be unit tested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-141015775 @DaanHoogland, @rafaelweingartner Yes I understand, I also think there should be test cases for a change because we don't know the entire logic. As there is

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-141004554 @karuturi I think that 8 is a good thing, that brings in much more combinations. Maybe even 10? And I agree with @bhaisaab, no more global settings :) --- If

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-141064763 Thanks for rebasing @ustcweizhou The pull-analysis is now running. https://builds.apache.org/job/cloudstack-pull-analysis/583/ Lets keep an

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-141065052 @DaanHoogland @miguelaferreira @wilderrodrigues I have rebase with the lastest master, and force push to github. let's see if it will be fixed. --- If

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

Nice work. I compiled and install new version into local maven repository, but now I can't compile Cloudstack with this library. I changed dependency version in pom file to new, but got next exception while compiling 'cloud-plugin-hypervisor-kvm': Konsole output [ERROR] Failed to execute goal

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141090948 :-1: until we get steps to test it. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-141135958 Hi there @rafaelweingartner, No hard feelings, dude. Long story short: * we are going through a critical phase with ACS - release

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141124718 @borisroman Just successfully deleted a POD and a ZONE. ![screen shot 2015-09-17 at 17 02

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/765#discussion_r39765711 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -414,7 +426,7 @@ def fw_router(self): self.fw.append(['',

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-141142775 @wilderrodrigues, Of course no hard feelings. I understand the pain that you feel when you stabilize everything and people come and breaking

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-141095617 Hi @ustcweizhou , I will :-1: this PR until we get to know which integration tests you executed, against which environment and the steps so we can

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-141086916 The build job already passed the point it had failed before (fingers-crossed) --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141086717 Hi @borisroman I deployed a DC and then added an extra POD. Then without creating even a cluster, tried to delete it. It failed saying: ``` The pod

[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/842#issuecomment-141091132 @jayapalu Which integration tests did you execute? Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141175510 @wilderrodrigues The steps to test this are simply creating a POD, then deleting it. It fails in current master and succeeds in this PR. Same with a zone. If

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-141170729 For the record, I tested against fa5f388fe91bc2fd477b1f6752c2a31ac69d5051. --- If your project is set up for it, you can reply to this email and have your reply

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 09/17/2015 02:33 PM, Dmytro Shevchenko wrote: > Nice work. I compiled and install new version into local maven > repository, but now I can't compile Cloudstack with this library. I > changed dependency version in pom file to new, but got next exception > while compiling

[GitHub] cloudstack pull request: [4.5.3]Cherry-pick PR #795 into 4.5 branc...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-141342804 LGTM, merging this this is already merged on master and builds are passing on 4.5 branch now --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8851 Redundant VR getting star...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/839#issuecomment-141343706 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/846 Bug-ID: CLOUDSTACK-8870: Skip external device usage collection if no external devices exist external network device usage monitor thread that runs every 5mins by default (based on global

[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/840#issuecomment-141343287 LGTM, pl fix one of the indentation issues and perhaps use better and verbose log messages. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: [4.5.3]Cherry-pick PR #795 into 4.5 branc...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/817 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/840#discussion_r39823849 --- Diff: framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java --- @@ -96,12 +96,13 @@

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/828#discussion_r39824131 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java --- @@ -598,6 +601,19 @@ public static void

[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/842#issuecomment-141348042 @wilderrodrigues I have tested the changes on my local against the VR. It is specific to shared network and the fix is also specific to shared network VR. I

[Blocker] PF, static nat, LB, egress rules not working in case of isolated networks

Hi, Created a blocker - https://issues.apache.org/jira/browse/CLOUDSTACK-8881 This is failing a bunch of BVTs in Adv for XS/KVM and VMWare. Can someone please look at this ? best, Raja

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8880: calculate free m...

GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/847 Bug-ID: CLOUDSTACK-8880: calculate free memory on host before deploying Vm. free memory = total memory - (all vm memory) With memory over-provisioning set to 1, when mgmt server starts

RE: [Blocker] PF, static nat, LB, egress rules not working in case of isolated networks

correction - not "BVT" - "Regression Tests" in Advanced zone. -Original Message- From: Raja Pullela [mailto:raja.pull...@citrix.com] Sent: Friday, September 18, 2015 11:12 AM To: CloudStack Dev (dev@cloudstack.apache.org) Subject: [Blocker] PF, static nat,