[GitHub] cloudstack pull request: Corrected sentence

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/951#issuecomment-149443831 @thinktwo Thanks for the patch! Could you please force push your commits again so Jenkins can do another build? It failed although I believe the problem is not i

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/952#issuecomment-149443237 @michaelandersen Thank you! Can you please rebase with current master? Will test it afterwards :-) --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149443163 @michaelandersen Travis failed due to a timeout. Could you please force push the commits again so it will re-run? Also, you may rebase with current master to inc

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-149442522 @wilderrodrigues Talked to @karuturi and she said @bvbharatk doesn't have time to work on this PR this week. Let's sit together and finalise. --- If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8952 - The redundant routers a...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/956 CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} guest OS mapping for vmware is n… …ot available You can merge this pull request into a Git repository by running: $ git pull https://github.co

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42457485 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java --- @@ -0,0 +1,95 @@ +//Licensed to the Apac

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42457376 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,199 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42457267 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,199 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42456930 --- Diff: framework/db/src/com/cloud/utils/db/Transaction.java --- @@ -59,4 +59,30 @@ public T doInTransaction(TransactionStatus status) throws

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42456793 --- Diff: framework/db/src/com/cloud/utils/db/Transaction.java --- @@ -59,4 +59,30 @@ public T doInTransaction(TransactionStatus status) throws

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42456738 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +469,35 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42456505 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -60,10 +60,25 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8969 VPN customer gateway can'...

GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/955 CLOUDSTACK-8969 VPN customer gateway can't be registered with hostname When we have VPN customer gateway which is resolved by a hostname , we should be able to register the VPN customer gat

[GitHub] cloudstack pull request: Quota

Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42454940 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,99 @@ +// Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42449207 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java --- @@ -0,0 +1,95 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42448847 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,78 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42448777 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42448715 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,199 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42448687 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,199 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42448579 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,199 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42448448 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,199 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42448346 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,78 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42446701 --- Diff: framework/db/src/com/cloud/utils/db/Transaction.java --- @@ -59,4 +59,30 @@ public T doInTransaction(TransactionStatus status) throws RuntimeEx

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42446645 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42446674 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,199 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42446598 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42446533 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42446365 --- Diff: framework/db/src/com/cloud/utils/db/Transaction.java --- @@ -59,4 +59,30 @@ public T doInTransaction(TransactionStatus status) throws RuntimeEx

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42446276 --- Diff: framework/db/src/com/cloud/utils/db/Transaction.java --- @@ -59,4 +59,30 @@ public T doInTransaction(TransactionStatus status) throws RuntimeEx

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42445644 --- Diff: framework/db/src/com/cloud/utils/db/Transaction.java --- @@ -37,10 +37,10 @@ } TransactionLegacy txn = TransactionLega

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42445587 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +469,35 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42445486 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -60,10 +60,25 @@ public boolean supportsRollingUpgrade() { @O

Re: [DISCUSS] KVM HA with IPMI Fencing

Saw this message a bit later, i tried to break it down and respond.. On 10/19/15 2:24 AM, Ronald van Zantvoort wrote: > On 19/10/15 11:18, Ronald van Zantvoort wrote: >> On 16/10/15 00:21, ilya wrote: >>> I noticed several attempts to address the issue with KVM HA in Jira and >>> Dev ML. As we al

Re: [DISCUSS] KVM HA with IPMI Fencing

Ronald, Please see response in-line... On 10/19/15 2:18 AM, Ronald van Zantvoort wrote: > On 16/10/15 00:21, ilya wrote: >> I noticed several attempts to address the issue with KVM HA in Jira and >> Dev ML. As we all know, there are many ways to solve the same problem, >> on our side, we've given

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-149321626 @jburwell do you approve the PR ? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8952 - The redundant routers a...

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/940#issuecomment-149317933 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: CLOUDSTACK-8952 - The redundant routers a...

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/940#issuecomment-149317876 nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=../../../mct-zone1-kvm1.cfg -a tags=advanced test_vpc_vpn.py Test Remote Acc

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/954 CLOUDSTACK-8964: Can't create template or volume from snapshot on KVM You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweizhou/clouds

[GitHub] cloudstack pull request: CLOUDSTACK-8952 - The redundant routers a...

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/940#issuecomment-149314829 Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/953 CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance Added a new Icon in Instance page to launch the VM from the snapshot. A new icon over VM snapshot object, which u

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-149296878 What do you mean by the default build? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-149296707 There's a reason why the MySQL connector is not a dependency - it is Cat-X licensed, which means we may not depend on it in the default build. --- If your project i

Jenkins build is back to normal : build-master-jdk18 #369

See

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-149260290 Hi @remibergsma @karuturi @bvbharat I ran the first tests and following the management server closely during the tests. Although it all worked, the

[GitHub] cloudstack pull request: Corrected sentence

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack/pull/951#issuecomment-149260232 Thanks for the patch! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149260118 @wilderrodrigues thanks, done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/948 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149257541 Hi @miguelaferreira I built ACS, RPMs from source and deploy a DC and ran few tests - although it was not needed to cover the changes. Anyway, it LG

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149249897 Hi @michaelandersen I will merge PR #940 and this one and test them together. This PR depends on the fix we added to CsLoadBalancer.py. Wil

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/952#issuecomment-149249379 Thanks, @michaelandersen I will have a look at this one today! Cheers, Wilder --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: another typo that appears when monitoring...

Github user radu-stefanache commented on the pull request: https://github.com/apache/cloudstack/pull/913#issuecomment-149246909 When I've made the changed I've looked through all the files for the text and found no match but it's better to test first . --- If your project is set up f

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/952#issuecomment-149238771 run with: nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=/data/shared/marvin/mct-zone1-kvm1.cfg -a tags=advanced test/integratio

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/952 Improve marvin test site2site VPN Add optional fields: iprange and fordisplay to Marvin base.py class method Vpn.create Add optional field: passive to Marvin base.py class method Vp

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-149223151 Hi @karuturi @bvbharat @remibergsma I'm testing this PR at the moment. I merged it together with #940. I want to test if the changes on cloud-early-

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-149215099 Bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Corrected sentence

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/951#issuecomment-149214174 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Corrected sentence

GitHub user thinktwo opened a pull request: https://github.com/apache/cloudstack/pull/951 Corrected sentence Corrected the sentence as the previous one didn't make sense You can merge this pull request into a Git repository by running: $ git pull https://github.com/thinktwo/clo

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/950 Load mysql driver before connecting to db When deploying ACS as a WAR file in a vanilla tomcat installation, I always get an error reporting that the JDBC driver for MySQL can't be found

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/947 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149201734 I've made two PRs (#946 and #947) that are actually interdependent, so I'll close both and make a new one that combines the two. --- If your project is set

[GitHub] cloudstack pull request: Load mysql driver before creating datasou...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/946#issuecomment-149201301 Travis is reporting a missing dependency because the mysql connector jar is not being loaded. That should be fixed in PR #947. Closing this PR and moving the

[GitHub] cloudstack pull request: Load mysql driver before creating datasou...

Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149192133 @remibergsma @wilderrodrigues can you guys have a look when the build tests are finished? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149191773 running it in the bubble now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149189859 I think it's fixed. I've been able to reproduce the issue both locally and in our CI server. And after the last force push the issue is gone in both environm

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149190264 fixed the first test === Marvin Init Logging Successful=== Successfully created account: test-TestInternalLb-SG7Y3N, id: d64ee2ea-2

[GitHub] cloudstack pull request: CLOUDSTACK-8929: The list of VMs that can...

Github user rags22489664 commented on the pull request: https://github.com/apache/cloudstack/pull/949#issuecomment-149188565 Sorry for the ambiguous pull request earlier. I have updated the defect and created this pull request with proper description (Hopefully). As for the co

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149187828 This PR broke the maven build because dependency type was missing. Since apidocs does not generate a jar file, the dependency type has to be set to something

[GitHub] cloudstack pull request: CLOUDSTACK-8929: The list of VMs that can...

GitHub user rags22489664 opened a pull request: https://github.com/apache/cloudstack/pull/949 CLOUDSTACK-8929: The list of VMs that can be assigned to a load balancer rule is not updated after a VM is assigned to it. Once we assign a VM to a load balancer rule, the VM should not app

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149185286 Despite the fact that both builds are green, this PR as it is now breaks the maven build! Dug this up from the travis log: ``` [ERROR] Failed

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-149179735 Updated Transaction.java to handle database switches gracefully. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149172742 Indeed we cannot ship this dependency, however we can and have been using it in development. As long as we don't enable the developer profile when we build t

[GitHub] cloudstack pull request: Load mysql driver before creating datasou...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/946#issuecomment-149170996 @remibergsma will do that, also because the commit message got the '-' in between the words! --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149170965 wasn't there an issue about the license of this connector some time back? What's the current license ? is it ASF compliant ? --- If your project is set up for it,

[GitHub] cloudstack pull request: Load-mysql-driver-before-creating-datasou...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/946#issuecomment-149170855 @miguelaferreira You may want to force push again to see if Jenkins will be happy this time. --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149170612 @DaanHoogland automation, automation, automation ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: Load-mysql-driver-before-creating-datasou...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/946#issuecomment-149170422 PR #948 tries to fix the issue that travis faced while building this PR. As for the Jenkins build I've scanned through the output and couldn't find the re

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149168945 +1 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149166994 LGTM, only visual, i will run it in the bubble but the queue is now grown over 10 PRs :( --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149165230 Thanks for this @miguelaferreira I've been running into this lately it might explain some issues in the bubble. --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149165088 Travis stumbled on the same problem that I'm trying to fix here: https://travis-ci.org/apache/cloudstack/jobs/86030810 --- If your project is set up for it,

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/948 Marvin module depends on APIdoc module When building the developer tools, if the build is sequential then the marvin module always gets build after the apidoc module. However, it the bui

[GitHub] cloudstack pull request: CLOUDSTACK-8656: tests ignoring exception...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/850#issuecomment-149162987 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CID 1324349: conditionally return -1 or t...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/822#issuecomment-149162159 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/947 Add MySQL connector dependency to developer profile The most common way to run the management server while developing is to start up Jetty via maven. However, in a continuous integration

Re: [DISCUSS] KVM HA with IPMI Fencing

On 19/10/15 11:18, Ronald van Zantvoort wrote: On 16/10/15 00:21, ilya wrote: I noticed several attempts to address the issue with KVM HA in Jira and Dev ML. As we all know, there are many ways to solve the same problem, on our side, we've given it some thought as well - and its on our to do lis

Re: [DISCUSS] KVM HA with IPMI Fencing

On 16/10/15 00:21, ilya wrote: I noticed several attempts to address the issue with KVM HA in Jira and Dev ML. As we all know, there are many ways to solve the same problem, on our side, we've given it some thought as well - and its on our to do list. Specifically a mail thread "KVM HA is broken

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-149149393 So that means the SG tests are missing still. Ok, I will add it to my testing backlog. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-149147999 @DaanHoogland I think the status is still the same as of 7 days ago. Or am I missing something? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-149146910 @miguelaferreira @remibergsma are you satisfied with this PR, now? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8952 - The redundant routers a...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/940#issuecomment-149141666 Ping @karuturi @bhaisaab @wido @bvbharat @DaanHoogland @miguelaferreira Anyone else with some time to test this PR? Please, have a look at the test

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/927#issuecomment-149138303 Code-wise it looks good, but is it possible that you add a unit test? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: Add agent name in received response

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/936#issuecomment-149136968 With @DaanHoogland code-wise is LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe