[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152160447 hmm, in a advanced network setup, these IP address would be the private IPs but if it has a static NAT, the VM would also have a public IP. For a user, it mi

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1004#issuecomment-152159431 @wido not a really big feature, I think we should still accept UI changes? --- If your project is set up for it, you can reply to this email and have your reply ap

Re: [PROPOSAL] remove travis pull request checks from github

The apache build reports rats, findbugs, pmd, coverage etc. On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira < mferre...@schubergphilis.com> wrote: > It would add speed. > > Just for running maven we could move the travis build to their docker > based infra which is faster than what we use now.

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152157162 @borisroman Could you give this PR a spin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1005 kvm: Add UnitTests for LibvirtUtilitiesHelper These were lacking, but this helper is used in various places inside the KVM code. Some simple tests to verify the helper is doing what we

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1004#issuecomment-152157062 Isn't 4.5 closed for features? I know this might sound picky, but as far as I know we are only supposed to fix bugs in a point release. --- If your project is set up

Re: [PROPOSAL] remove travis pull request checks from github

It would add speed. Just for running maven we could move the travis build to their docker based infra which is faster than what we use now. I’m guess that the apache build does more stuff like packaging RPMs, but I’m not sure there. \ Miguel Ferreira mferre...@schubergphilis.com

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/916#issuecomment-152152422 @remibergsma @bhaisaab The above changes were made as the part of DHCP/DNS offload feature. The related ticket is https://issues.apache.org/jira/browse/CLOUDSTACK-832

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152150034 @wido we can burn the IPv6 bridge when the time comes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152149875 Code LGTM! Will run the tests and check the UI later today. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152149949 My only concern is, IPv6 is coming as well into CS, are we also going to display that address? For now this seems fine with me, but adding more columns later on makes

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152149708 Got it working, @bhaisaab! I did a full "mvn -P developer,systemvm clean install" and started the management server. Functionality is there. :)

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152148763 Hi @karuturi It worked! I removed the files under Jetty cache, stopped the management server, run mvn clean install again and restarted it.

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152148071 @wilderrodrigues can you clear browser cache (cmd +shift + del in firefox) or reload the page without cache using shift+f5 and then try? --- If your project is se

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152147799 @wilderrodrigues if you're running in dev mode, apply the UI git patch; mvn clean install -pl client; then run mgmt server. Alternatively, go to client/target/gene

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152147077 Hi @bhaisaab How to clean the cache in order to see the UI changes? I'm suffering a bit with the PR #996 :) We are running the management

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1003 [4.6/master] ui/instances: show IP address of the VM on the instances page The UI hides information regarding the IP address of the VM instance in its detail view, the patch add the IP addr

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1004 [4.5] ui/instances: show IP address of the VM on the instances page The UI hides information regarding the IP address of the VM instance in its detail view, the patch add the IP address col

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152145661 Ping @karuturi @remibergsma I delete the Jetty cache and restarted the Management Server, but still did not get the new item on the list. C

Re: [PROPOSAL] remove travis pull request checks from github

On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira < mferre...@schubergphilis.com> wrote: > However, I would still find it valuable to have travis run a single > command: > mvn clean isntall -P developer,systemvv > > That is because, still many people commenting on PRs don’t even do that. > In addi

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152138363 Ping @karuturi Testing your PR, but when I checked the UI I still got the old list: no VPC offering. Do I need to change anything else in order to g

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-152137705 @terbolous To get started, we need people actually testing / reviewing this and there also are some unaddressed comments. Testing this requires building the syst

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-152136821 I've done the following testing manually: 1. create snapshot snapshot-1 snapshot-2 snapshot-3 snapshot-4 2. reve

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-152136784 Guys, I just pushed some new commits to: (1) use libvirt-java flags instead of virsh command line (2) take snapshot of specific volume from vm snapshot

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-152134450 LGTM now DEB is included --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152131926 Ping @karuturi @remibergsma @miguelaferreira Code LGTM, because it's very simple. But I will run our set of tests agains this PR - although it menti

Re: [PROPOSAL] remove travis pull request checks from github

I do agree that at the moment Travis is either creating false sense of security when it is green, or a burden for contributors when it is red, because most of the time it goes red for no good reason. However, I would still find it valuable to have travis run a single command: mvn clean isntall -

Re: [PROPOSAL] remove travis pull request checks from github

+1 it doesn’t help like this. I look at actual test result people post combined with code reviews. Plus an OK from Jenkins should be more than enough to judge a PR. Let’s make Jenkins more reliable, that would help as well. Regards, Remi On 29/10/15 10:33, "Daan Hoogland" wrote: >Guys and

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/975#issuecomment-152127664 Ping @remibergsma @snuf Just started testing this PR. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-152127321 @wido Would be nice if the commit hash changed, so Github doesn't recognise it as already being merged. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-152127233 @wido Please send a new PR with this commit, I tried merging it again but that gives issues. We can proceed fast with this when you link the new one to this PR.

[PROPOSAL] remove travis pull request checks from github

Guys and dolls, We have been having travis builds for a while now and they seem to generate more work then help. There are a lot of time-outs, (false positive) and when a suite passes it is often because all tests where skipped (false negative). In addition, and this may be just me, I've never bee

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152127063 Ping @serbaut I just executed the test against Master and got the following error: ``` cat /etc/dhcphosts.txt | grep 10.1.1.50 | sed 's/

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152124858 @karuturi @remibergsma This is the second PR I look into and find that Travis is nor running any Marvin tests! As I said in PR #997, fire few Travis

Re: 4.6 status update

Hi, Not my pull request, but is this something that can be reviewed for 4.6 or is it too late? https://issues.apache.org/jira/browse/CLOUDSTACK-8682 (Replace openswan ipsec with strongswan ipsec) https://github.com/apache/cloudstack/pull/872 -Jan-Arve 2015-10-29 9:28 GMT+01:00 Remi Bergsma : >

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-152123825 Any update here @jayapalu? @remibergsma @karuturi what is the chance for this getting into 4.6? replacing the old openswan would be good.. --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152122778 @serbaut I created a tested to cover your fix! :) It's on PR #1002 Cheers, Wilder --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152122575 Ping @remibergsma @DaanHoogland @karuturi @bhaisaab @serbaut @borisroman Test results * Management Server + MySQL on CentOS 7.1 * One K

Re: 4.6 status update

On 29-10-15 09:28, Remi Bergsma wrote: > Hi, > > We’re down to a single blocker: > > 1) CentOS 7 - systemd-tmpfiles - Operation not permitted > This is about the CentOS 7 packaging of the Management Server. > https://issues.apache.org/jira/browse/CLOUDSTACK-8812 > > > PRs for 4.6 > ==

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1002 CLOUDSTACK-9007 - Write test to check that the /etc/dhcphosts.txt doesn't contain duplicate IPs This PR contains a test that will cover the fix on PR #981 The tests does the f

[GitHub] cloudstack pull request: [wip][4.6] CLOUDSTACK-8994 Add logging fo...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-152120849 @karuturi I would be very much interested in seeing the results of the tests that have passed in that environment were you could not get a router to come up.

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-152120874 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/995#issuecomment-152119427 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: [wip][4.6] CLOUDSTACK-8994 Add logging fo...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-152118890 @miguelaferreira All the tests did pass except for some template related failures due to download template timeout. But, when I manually created a new network on th

[GitHub] cloudstack pull request: CLOUDSTACK-9003 Make VirtualMachineName i...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/988#issuecomment-152118673 @ProjectMoon Thanks for the PR. I cannot judge the actual change you made. I did run some generic tests and they seem to pass just fine: ``` nosetest

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8951: validation for con...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/929#issuecomment-152117456 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/927#issuecomment-152116250 Results of set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tag

[GitHub] cloudstack pull request: [wip][4.6] CLOUDSTACK-8994 Add logging fo...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-152114882 @remibergsma Thanks for the effort. This was what also caused my vr to not reboot... Knowing that I closed the PR yesterday. Will look into it and test more prop

Re: Build fails on LocalTemplateDownloadTest

On 29-10-15 00:34, Josh Harshman wrote: > Is anyone else experiencing the same behavior? > > Building off master, get the following build failure: > I think you are building on Windows? I send a PR for this: https://github.com/apache/cloudstack/pull/884 This was reverted, but due to the code

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-152114694 @remibergsma ping? ^^ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: [wip][4.6] CLOUDSTACK-8994 Add logging fo...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-152114469 @karuturi How is it possible that "All the tests in BVT tests pass on xenserver 6.5 host" and "I started seeing below error messages on console and VR doesnt

Re: Hyper-V clock on KVM node - CLOUDSTACK-8978

On 27-10-15 23:42, Josh Harshman wrote: > I noticed around line 1949 in LibvirtComputingResource.java, there is some > commented out code for enabling hyperV enlightenment. Was there an issue > with enabling this behavior? > I don't know why this was disabled. Maybe somebody else knows, but

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-152114217 @jburwell thanks for intensive review. How does it look like? :) thanks --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: [wip][4.6] CLOUDSTACK-8994 Add logging fo...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-152113648 @borisroman FYI: I already started a test on this branch (which I rebased myself first) and it doesn't look too good: ``` nosetests --with-marvin --m

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/998 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

4.6 status update

Hi, We’re down to a single blocker: 1) CentOS 7 - systemd-tmpfiles - Operation not permitted This is about the CentOS 7 packaging of the Management Server. https://issues.apache.org/jira/browse/CLOUDSTACK-8812 PRs for 4.6 === If you have PRs that should go into 4.6, please ping me or Ra

[GitHub] cloudstack pull request: squashed commit for dockerfiles part#2 in...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/999#issuecomment-152107883 The changes themselves LGTM, I can test them as well just to be sure, takes some time though :-) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152106955 @serbaut Will merge when Travis and Jenkins are green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-152106800 Will merge when Travis and Jenkins are green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: squashed commit for dockerfiles part#2 in...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/999#issuecomment-152105724 This doesn't touch CloudStack itself, so I'm OK with merging this after some extra pair of eyes. @runseb @terbolous can you please review? --- If your project i

Jenkins failures

Hi, Can someone please look why Jenkins fails so often recently? It feels like a casino and slows down merging of PRs since we want to merge when they “are green”. This requires forse pushing many times now, including the wait. I’d prefer not to start ignoring them.. Thanks for the help! Rega

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152101614 ping @serbaut @remibergsma Can you please do a force push to see if we get Jenkins green? I know is a pain in the ass to depend on Jenkins/Travis th

[GitHub] cloudstack pull request: Update L10N files for Next 4.6.

Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: Update L10N files for Next 4.6.

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/984#issuecomment-152099956 Closed. Replace by #1001 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Update L10N Web UI resource files before ...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1001 Update L10N Web UI resource files before 4.6 RC1 (v2) Update the localization files for the next CloudStack 4.6. This PR cancel and replace the #984. cc @remibergsma Yo

<    1   2