[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1112 Fix Instance creation with swift as Secondary Storage [CLOUDSTACK-9061] Swift is currently broken when used as Secondary storage. This fix does the right thing when creating directories on the

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159042018 Yes, preferably but not necessarily. you can create your own if you want, based on scripts and cloudmonkey for instance or a similar tool. --- If your

New Defects reported by Coverity Scan for cloudstack

Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 98 new defect(s) introduced to cloudstack found with Coverity Scan. 6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159018652 ``` mvn -P developer,systemvm clean install -Dnoredist ``` ``` [INFO]

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159024273 Integration tests use Marvin, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Build failed in Jenkins: build-master-slowbuild #2701

See -- [...truncated 25566 lines...] [INFO] Done FindBugs Analysis [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-f5 <<< [INFO] [INFO]

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159017809 the problem seems to be only in using java8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159047345 @DaanHoogland, I have just ran "mvn clean install -Dnoredist -P developer,systemvm" with java 8 and everything was ok. What version of java 8 are you

[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1103#issuecomment-158873719 @remibergsma I think we will need to create new systemvmtemplate for 4.7.0 if we'll get the openswan->strongswan patch merged. --- If your project is set up for

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1069#issuecomment-158874631 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1082#issuecomment-158874507 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1081#issuecomment-158874568 LGTM, haven't tested with resized UI though --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1077#issuecomment-158874596 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1100#issuecomment-158874243 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-158874087 LGTM, though are the additional commas causing any issue for you? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1105#issuecomment-158873996 LGTM, should we fix the scripts in src paths? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1087#issuecomment-158874419 LGTM, here's a rpm repo built out of this patch: http://sb.bhaisaab.org/cloudstack/paul-rpmpr-1087/centos/paul-rpmpr-1087/ --- If your project is set up for it,

[GitHub] cloudstack pull request: Add47xmessagesproperties transifex

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1098#issuecomment-158874270 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1085#issuecomment-158874483 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Removed unnecessary @Local annotations an...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1102#issuecomment-158896104 LGTM, based on a set of tests that I run on this branch. Screenshot is from an experimental Jenkins job (that runs the same tests I did manually until now).

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1081#issuecomment-158900212 I was wondering; as it seems obvious from your screenshot that initial rendering works, after an item (i.e. row) has been added, whether it also re-renders ok

[GitHub] cloudstack pull request: CID 1338016: multi catch instead of pokem...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1018 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Build failed in Jenkins: build-master-noredist #4758

See Changes: [Daan Hoogland] CID 1338016: multi catch instead of pokemon [Rajani Karuturi] CLOUDSTACK-8951: validation for "remote.access.vpn.psk.length" [lucascristofolini] Removed unnecessary @Local annotations and their

Re: 4.6 release

isn't awsapi a requirement in older versions? https://github.com/apache/cloudstack/blob/GA-4.5.1/packaging/centos63/cloud.spec#L88 thus everyone doing an upgrade would have it installed, or do i misunderstand it? -- Erik On Mon, Nov 23, 2015 at 11:16 AM, Nux! wrote: > Hi, > >

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-158903497 Saw the changes, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Build failed in Jenkins: build-master-noredist #4760

See -- [...truncated 5596 lines...] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-hypervisor-baremetal --- [INFO] No sources to compile [INFO] [INFO]

Re: 4.6 release

It was an requirement but is removed in 4.6.0 (the ~1M line code delete change). Ok, so we need to add two things to the RN/docs then: 1. Remove old dependency on ‘awsapi’ (did not test, copied from Nux): rpm -e --nodeps cloudstack-awsapi 2. If upgrading from 4.4.x or earlier, 4.6.0 needs to

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-158901139 @wido @DaanHoogland @wilderrodrigues Did any of you run the unit test and did they pass? If so, please paste output. After this, OK to merge? --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-158901032 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-158901685 LGTM based on these tests (may not have tested the actual change): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a

Build failed in Jenkins: build-master-noredist #4759

See -- [...truncated 5515 lines...] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [2.177s] [INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [15.696s]

Build failed in Jenkins: build-master-jdk18 #402

See Changes: [Daan Hoogland] CID 1338016: multi catch instead of pokemon [Rajani Karuturi] CLOUDSTACK-8951: validation for "remote.access.vpn.psk.length" [lucascristofolini] Removed unnecessary @Local annotations and their

Re: 4.6 release

> On Nov 23, 2015, at 12:04 PM, Remi Bergsma > wrote: > > It was an requirement but is removed in 4.6.0 (the ~1M line code delete > change). > > Ok, so we need to add two things to the RN/docs then: > > 1. Remove old dependency on ‘awsapi’ (did not test, copied

Re: 4.6 release

These should be in the RN for 4.6.0, we can add it asap indeed. On 23/11/15 12:07, "Sebastien Goasguen" wrote: > >> On Nov 23, 2015, at 12:04 PM, Remi Bergsma >> wrote: >> >> It was an requirement but is removed in 4.6.0 (the ~1M line code

[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1037#issuecomment-158875003 LGTM, anyone tested this yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Quota

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-158887865 @remibergsma please go ahead and run the integration tests. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Removed unnecessary @Local annotations an...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1007#discussion_r45596255 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1069#issuecomment-158915937 LGTM, built a cloud on this PR and clicked through the UI which worked fine. ![screen shot 2015-11-23 at 13 05

Build failed in Jenkins: build-master-slowbuild #2699

See Changes: [Daan Hoogland] CID 1338016: multi catch instead of pokemon [Rajani Karuturi] CLOUDSTACK-8951: validation for "remote.access.vpn.psk.length" [lucascristofolini] Removed unnecessary @Local annotations and

Build failed in Jenkins: build-master-noredist #4761

See Changes: [Daan Hoogland] javascript:TrailingComma sonacube issue considered blocker removed [koushik] CLOUDSTACK-8485: listAPIs are taking too long to return results - --

[GitHub] cloudstack pull request: Create test cases to getPatchFilePath met...

Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/944#issuecomment-158921322 Thanks for your review Daan. The purpose of this test is to check if an exception is thrown. The point is that, we have several class that we need to

[GitHub] cloudstack pull request: Create test cases to getPatchFilePath met...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/944#issuecomment-158925001 @pedro-martins I am crazy/not paying attention, you are right. still, can you rebase on post 4.6.0, instead of merge? --- If your project is set up

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1007#issuecomment-158914722 Repeated the tests due to new commits: LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1021 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1069 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1105#issuecomment-158918940 Hi @bhaisaab, what do you mean with "fix the scripts in src paths" ? Regards --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Create test cases to getPatchFilePath met...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/944#issuecomment-158924129 Hi @DaanHoogland, in that "CitrixResourceBaseTest. testGetPathFilesExeption" method, there is no @test annotation. --- If your project is set up for it,

[GitHub] cloudstack pull request: Create test cases to getPatchFilePath met...

Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/944#issuecomment-158929670 Squash done. Thx guys --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1007#discussion_r45595780 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final

[GitHub] cloudstack pull request: CLOUDSTACK-9020: UI enhancements from met...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1106#issuecomment-158916248 Thanks @bhaisaab will test soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-158917040 @remibergsma this has probably been laying around to long. I did run unit tests and passed them but now compilation doesn't even succeed. I will put it back

[GitHub] cloudstack pull request: CLOUDSTACK-9080: Resource limits for Prim...

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/1107 CLOUDSTACK-9080: Resource limits for Primary arent respected during attach primary store resource limit check is not performed while attaching a volume to a vm. Added them same. Also

[GitHub] cloudstack pull request: Create test cases to getPatchFilePath met...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/944#issuecomment-158923595 @pedro-martins I think you should remove the Test annotation then. It is not supposed to run as a test itself, is it? --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-158924625 @remibergsma : that was a fluke, it does compile and run unit tests now??? ``` [INFO]

Re: 4.6 release

Hi, For cloudstack-awsapi, shouldn't we include is rpm in the 4.6 repo so ```yum upgrade``` will work, then part of the RN would be to remove awsapi after the upgrade if it's not used? Otherwise we can add ```rpm -e --nodeps cloudstack-awsapi``` to the RN For the repo URL

Re: 4.6 release

> On Nov 21, 2015, at 10:51 AM, Sebastien Goasguen wrote: > > Talking about 4.6 > > There seems to be an issue when people upgrade from 4.5.2 and the awsapi > package is missing. > Ping on this. Before me make the 4.6 release announcement is there an issue with the

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1081#issuecomment-158898488 @DaanHoogland Is that what you mean.. testing it with the wider UI or..? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9037 patterns can be more elab...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1035#issuecomment-158875017 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-158895941 @bhaisaab I think @wolf29 is trying to triage the sonarqube issues. @wolf29 We would like a ref to an issue with a patch, jira, coverity, findbugs is all

[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1103#issuecomment-158895870 @bhaisaab Sure, that would be a good reason. But it's not ready so let's bump when we merge that PR. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8951: validation for con...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/929#issuecomment-158897259 Run the tests again since master moved on quite a bit in the past weeks. Still LGTM based on these tests: ``` nosetests --with-marvin

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-158874821 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: 4.6 release

Hi, I think we do need to mention this in the notes, if people have the "awsapi" package installed, they should remove it, or we should gracefully "obsolete" it from the RPM packaging. I had to manually "rpm -e --nodeps cloudstack-awsapi" to avoid conflicts, but otherwise the upgrade went

[GitHub] cloudstack pull request: Removed unnecessary @Local annotations an...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1102#issuecomment-158896493 LGTM, checked the code. It felt like skimming at times as 607 lines were removed ;) I don't think there is any problem though. --- If your project is set up

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8951: validation for con...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/929 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Removed unused code from the EngineHostDa...

Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/942#issuecomment-158935886 I've pushed another commit to bring this PR up to date with the latest snapshot but it seems the Travis build had some issues sorting out some dependencies.

[GitHub] cloudstack pull request: Removed unused code from the EngineHostDa...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/942#issuecomment-158940788 @cristofolini you can force push, more important is that the regression suites are run on it. ping @remibergsma ? --- If your project is set up for it, you

[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...

GitHub user pedro-martins opened a pull request: https://github.com/apache/cloudstack/pull/1108 Removed the PlannerBase class because it is does not bring contribution to ACS' code. Removed the PlannerBase class because it is does not bring contribution to ACS' code. We

[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1108#issuecomment-158952872 less is more. Are there no other types of Planner{}s then DeploymentPlanner{}s? and in addition Interfaces are a betterway to signify types if/when there is

Build failed in Jenkins: build-master-slowbuild #2705

See -- [...truncated 25566 lines...] [INFO] Done FindBugs Analysis [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-f5 <<< [INFO] [INFO]

Re: New Defects reported by Coverity Scan for cloudstack

*98* New defects. All the latest merged PR authors, can you please go through the list of new defects? ~ Rajani -Original Message- From: "scan-ad...@coverity.com" Reply-To: "dev@cloudstack.apache.org" Date: Monday, 23

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-15917 @rafaelweingartner please go ahead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159175335 retried but it is repeatable :') ``` $ mvn -version Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T13:57:37+02:00)

[GitHub] cloudstack pull request: Cwe 190

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1057#issuecomment-159176971 [1057.network.results.txt](https://github.com/apache/cloudstack/files/42440/1057.network.results.txt)

[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1103#issuecomment-159179258 @pdion891 @bhaisaab In about two weeks (Dec 7) we freeze for 4.7.0. That would be a nice time to look back and see if the systemvm template needs to be bumped

[GitHub] cloudstack pull request: CLOUDSTACK-9037 patterns can be more elab...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1035#issuecomment-159179464 [1035.network.results.txt](https://github.com/apache/cloudstack/files/42442/1035.network.results.txt)

[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1112#issuecomment-159179498 Pinging @pdion891 to have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159108087 macosx 10.11.1: ``` $ java -version java version "1.8.0_66" Java(TM) SE Runtime Environment (build 1.8.0_66-b17) Java HotSpot(TM) 64-Bit

Build failed in Jenkins: build-master-slowbuild #2703

See -- [...truncated 25566 lines...] [INFO] Done FindBugs Analysis [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-f5 <<< [INFO] [INFO]

[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-159123334 The code seems ok, but what about a PR description and test cases for those encode and decode methods that were created? --- If your project is set up

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159109110 That is the plugin, here everything compiled without problems. ~$ mvn -version Apache Maven 3.0.5 Maven home: /usr/share/maven Java

[GitHub] cloudstack pull request: Cwe 190

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1057#issuecomment-159127988 @remibergsma, could you send me the stack trace of the test that failed? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9077 Fix injectkeys.sh to work...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/1109#issuecomment-159130294 @remibergsma can you update this PR with following update: It still need to look for ``/dev/loop0`` inside docker to know if it can update the sshkey at the

[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/1103#issuecomment-159133510 I have updated release scripts as per @DaanHoogland comments but didn't change template version, based on @bhaisaab I would suspect we will upgrade sysvm on 4.7,

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1082#issuecomment-159125197 In which version is this problem happening? I tested on CS 4.3.2 and it is working. I used both Chrome and Firefox. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1077#issuecomment-159125686 Isn't this PR the same as #1082? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-159128519 @DaanHoogland, would you like me to finish the changes that we need, so we can proceed with this PR? --- If your project is set up for it, you can reply

Cloudstack 4.6 PVLAN on Xen 6.5

Hi All, As per the below link PVLAN on Xen 6.5 will work because I tried on 4.5.2 I could see OVS plugin error. Is this issue been resolved in 4.5.3 or 4.6. It will be so great if someone can answer that on which version I can expect because we are holding production implementation for almost a

Build failed in Jenkins: build-master-slowbuild #2704

See -- [...truncated 25566 lines...] [INFO] Done FindBugs Analysis [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-f5 <<< [INFO] [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-159127168 I would rather use Java 1.8. We are already migrating to Java 8, right? --- If your project is set up for it, you can reply to this email and have

Re: New Defects reported by Coverity Scan for cloudstack

On Tue, Nov 24, 2015 at 7:46 AM, Rajani Karuturi wrote: > *98* New defects. > All the latest merged PR authors, can you please go through the list of > new defects? > Could we integrate it with travis and/or jenkins and get it reported once submitted as PR?

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1082#issuecomment-159181399 @rafaelweingartner This is happening in 4.5. I checked with this master. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1077#issuecomment-159181731 @rafaelweingartner This PR will merge with current master. and #1082 Will merge in branch 4.6. Thanks. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1108#issuecomment-158981153 I agree with @DaanHoogland, less is more! Thanks for your contribution. I'll run integration tests on it to show nothing breaks. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9077 Fix injectkeys.sh to work...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1109 CLOUDSTACK-9077 Fix injectkeys.sh to work on CentOS7 Fix regression from commit 3381154fafb7fa4f0a61d538f7c2550e48247787 The error seen on CentOS 7: ``` 2015-11-20

[GitHub] cloudstack pull request: CLOUDSTACK-9077 Fix injectkeys.sh to work...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/1109#issuecomment-158973082 @remibergsma Thanks for this PR, this will break the injection of the ssh key in the initial build of the docker container. But I will submit a PR to fix the

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-158961187 The PR has been fixed by the application of two more commits. Maybe squashing is in order before a merge. The abuse of reflection required to make the

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1105#issuecomment-158973478 @borisroman I mean, if it helps to do chmod +x to the scripts in scripts/storage in the git repo itself? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1110 PR1102 regression fix; half the annotation was removed I am having troubles getting this to work but it passes the point at which the master slowbuild is broken. You can merge this pull

  1   2   >