[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

2015-11-26 Thread pritisarap12
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1130 CLOUDSTACK-9091: Update testpath for parameter issues In testpath_volume_snapshot testpath creating volume from snapshot function is passing zonid parameter to function in base class but t

Re: Package Repositories

2015-11-26 Thread Rajani Karuturi
+1 to what Remi said. One source for packages on a generic domain with everyone in community trying to make it better. And, please do not mention different domains for systemvm templates in documentation. That is even more confusing. ~ Rajani -Original Message- From: Nux! Repl

[GitHub] cloudstack pull request: CID-1339965 handle retrun value on failur...

2015-11-26 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1129#issuecomment-159993684 LGTM, on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request: CID-1339965 handle retrun value on failur...

2015-11-26 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1129#discussion_r46006607 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java --- @@ -558,7 +558,9 @@ public String down

[GitHub] cloudstack pull request: CID-1339965 handle retrun value on failur...

2015-11-26 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1129 CID-1339965 handle retrun value on failure coverity reported this as new last week. It has been in the code for ever, i.e. since initial git commit. Minor issue, easy fix. You can merge t

Build failed in Jenkins: build-master-jdk18 #407

2015-11-26 Thread jenkins
See Changes: [Daan Hoogland] fix regression on 9a23229d946eb117985ef4547acccb3c11f56283, comma was -- [...truncated 398 lines...] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time el

[GitHub] cloudstack pull request: fix regression, comma was a needed separa...

2015-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: fix regression, comma was a needed separa...

2015-11-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1128#issuecomment-159968862 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

Re: Package Repositories

2015-11-26 Thread Nux!
+1 what Remi said. Jenkins is already building packages and system templates, when we release a version let's also copy one of those builds and make them "official". Let's use this enhancement as well with a sensible release number (Y-M-D-#build?) https://github.com/apache/cloudstack/pull/1075

RE: Package Repositories

2015-11-26 Thread Suresh Sadhu
+1. I agree with Remi. Regards sadhu -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: Thursday, November 26, 2015 9:52 PM To: dev@cloudstack.apache.org Subject: Re: Package Repositories Hi all, I do appreciate any effort to make it easy for users. My mai

Re: Package Repositories

2015-11-26 Thread Remi Bergsma
Hi all, I do appreciate any effort to make it easy for users. My main point of worry is that it is confusing to have different companies supply packages of what is supposed to be a single product. Which one should they pick? If we look at it, we have two types of packages: the OSS and NOREDIST

Re: Package Repositories

2015-11-26 Thread Rohit Yadav
Just some points of information from my side; - We (bunch of people at ShapeBlue) took this initiative to provide packages as a convenience to users, there were existing 3rd party repositories at that time but we found they were poorly maintained, for example - packages and systemvmtemplates we

[GitHub] cloudstack pull request: CLOUDSTACK-9077 Fix injectkeys.sh to work...

2015-11-26 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/1109#issuecomment-159936201 Quickly tested for the docker images, behave correctly. LGTM Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9020: UI enhancements from met...

2015-11-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1106#issuecomment-159932615 Thanks @karuturi will close once this is merged, and 4.6 is fwd-merged. --- If your project is set up for it, you can reply to this email and have your reply appea

Reviewers wanted (PRs removing needless code)

2015-11-26 Thread Rafael Weingärtner
Hi folks, Without wishing to take the liberty, I would like to ask some help. My team mates and I have few clean up PRs open that need review. All of them are easy to review; we mostly removed unused methods and classes. We might also need someone to run integration tests. The PRs that I am talkin

Re: main docs not on 4.6

2015-11-26 Thread Pierre-Luc Dion
Just got it fixed. so all doc now point to 4.6 releases. On Wed, Nov 25, 2015 at 11:46 AM, sebgoa wrote: > looking at this: > http://docs.cloudstack.apache.org/en/latest/# > > it's still on 4.5 > > there are no changes to it for 4.6, but it's confusing because there is no > 4.6 tag, …..and a 4.

[GitHub] cloudstack pull request: fix regression, comma was a needed separa...

2015-11-26 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1128#issuecomment-159913420 Pretty simple fix. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: fix regression, comma was a needed separa...

2015-11-26 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1128 fix regression, comma was a needed separator You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack trailing-commas

[GitHub] cloudstack pull request: CLOUDSTACK-9020: UI enhancements from met...

2015-11-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1106#issuecomment-159901255 I think #1119 can be closed as this PR will be fwd-merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9020: UI enhancements from met...

2015-11-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1106#issuecomment-159901047 verified on 4.6.. working fine.. ![screen shot 2015-11-26 at 5 59 33 pm](https://cloud.githubusercontent.com/assets/186833/11423099/8a583474-9467-11e5-9fad-5b30

RE: release managers wanted

2015-11-26 Thread Raja Pullela
would like to volunteer... please count me in, if this is still open! -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Tuesday, November 24, 2015 7:35 PM To: dev Subject: Re: release managers wanted shortly: check if PRs have enough review and merge to the r

[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...

2015-11-26 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-159894668 @DaanHoogland, @remibergsma, can this be merged in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1127#issuecomment-159889944 Thanks @ProjectMoon :+1: from me based on my previous tests. ping @remibergsma and @DaanHoogland to merge --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-26 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159889056 Closed in favor of #1127. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-26 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-26 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1127 Fix event UUIDS missing on event bus Same as pull request #, but this time on the 4.6 branch for forward merging in accordance with [the wiki](https://cwiki.apache.org/confluence/displ

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-11-26 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1126 CLOUDSTACK-9088: Update the description for migrateVirtualMachineWithVolume api https://issues.apache.org/jira/browse/CLOUDSTACK-9088 You can merge this pull request into a Git repository b

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-26 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159887285 Since the branches are different, I will create a new branch off of 4.6, cherry-pick my commit to it, and then submit that as a new PR, which can then be forwar

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159884682 No cherry-picking. The PR should be only for 4.6 which will be fwd-merged to master(and hence will be available in 4.7 and up) I wish it was as easy as editing

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-26 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159883807 Well, the target branch for this is master so it will be put in 4.7-SNAPSHOT, but it's also intended to be cherry-picked back into 4.6 (which I obviously do not

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159883325 I just realised the target branch should be 4.6 meaning the PR should be for 4.6 and fwd-merged to master. Can you take care of that please @ProjectMoon --- If y

[GitHub] cloudstack pull request: CLOUDSTACK-9065: fix bug when creating pa...

2015-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Package Repositories

2015-11-26 Thread Daan Hoogland
Erik On Thu, Nov 26, 2015 at 11:12 AM, Erik Weber wrote: > Would it be too blunt to propose that we set up a team, composed of any > community members interested, to handle packaging and promote that as 'the > community package'? > > Realistically, as a user, it is not really crucial for me that

Re: Package Repositories

2015-11-26 Thread Erik Weber
Would it be too blunt to propose that we set up a team, composed of any community members interested, to handle packaging and promote that as 'the community package'? Realistically, as a user, it is not really crucial for me that the package is 100% equal to the official source release. I'm more i

Re: Package Repositories

2015-11-26 Thread sebgoa
On Nov 26, 2015, at 7:52 AM, John Burwell wrote: > All, > > A conversation emerged on a PR [1] regarding how package repositories should > listed on the downloads page [2]. This PR was prompted by a change on the > page which removed reference to the ShapeBlue repositories. Let me touch bas

Jenkins build is back to normal : build-master-slowbuild #2722

2015-11-26 Thread jenkins
See

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

2015-11-26 Thread kansal
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/1125 CLOUDSTACK-9086: ACS allows to create isolated networks with invalid … …gateway IP address - Fixed Problem: There was no check for the network and broadcast IP addresses in the case