Upcoming releases: ACS 4.7.1 / 4.8.0

2015-12-29 Thread Remi Bergsma
Hi all, We will freeze for new features for Apache CloudStack 4.8 on January 15th. The release is expected by the end of the month. So far we have one feature merged. Please go ahead and test/review any additional features. Bug fixes should be pointed towards 4.7 branch and will end up in

Re: Let’s discuss database upgrades

2015-12-29 Thread Daan Hoogland
a page on the wiki so I can add >>> everything we discuss and agree upon here? This way, we could add that >>> page >>> to the guidelines for devs creating PRs and committers reviewing and >>> merging them. >>> >>> On Tue, Dec 29, 2015 at 12:

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-29 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1296#issuecomment-167842372 @rafaelweingartner In the original PR against master someone asked to split the commits hehe :-s --- If your project is set up for it, you can reply to this

Build failed in Jenkins: build-master-slowbuild #2857

2015-12-29 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Upcoming releases: ACS 4.7.1 / 4.8.0

2015-12-29 Thread Wido den Hollander
On 12/29/2015 06:59 PM, Remi Bergsma wrote: > Hi all, > > We will freeze for new features for Apache CloudStack 4.8 on January 15th. > The release is expected by the end of the month. > > So far we have one feature merged. Please go ahead and test/review any > additional features. Bug fixes

Re: Let’s discuss database upgrades

2015-12-29 Thread Ron Wheeler
ael, I like the date-format but then of course CCYY-MM-DD. I can still think of ways to screw up that (or the plain int;) 20151229 is a valid integer which you can simply use to compare with. 100, 101, 102 or 20151229, 20160103, 20160104, I don't care that much. My point is that the database ve

Re: Let’s discuss database upgrades

2015-12-29 Thread Ron Wheeler
ink of ways to screw up that (or the plain int;) 20151229 is a valid integer which you can simply use to compare with. 100, 101, 102 or 20151229, 20160103, 20160104, I don't care that much. My point is that the database version should be separated from the code base. Wido On Tue, Dec 29,

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

2015-12-29 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1291#issuecomment-167842159 With this fix it survives longer wait times: ``` 2015-12-29 12:40:02,011 DEBUG [c.c.a.r.v.VirtualRoutingResource] (DirectAgent-111:ctx-d584fccd)

Build failed in Jenkins: build-master-slowbuild #2859

2015-12-29 Thread jenkins
See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Let’s discuss database upgrades

2015-12-29 Thread Erik Weber
On Mon, Dec 28, 2015 at 2:16 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hi all devs, > First of all, sorry the long text, but I hope we can start a discussion > here and improve that part of ACS. > > A while ago I have faced the code that Apache CloudStack (ACS) uses to >

Build failed in Jenkins: build-master-slowbuild #2858

2015-12-29 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-29 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-167932695 @remibergsma @kishankavala @terbolous @bhaisaab Added all the required tests below. Please review the PR. nosetests-2.7 --with-marvin

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-29 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167953466 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Build failed in Jenkins: build-master-slowbuild #2860

2015-12-29 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-29 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167931759 cc @remibergsma @bhaisaab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

2015-12-29 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1150#issuecomment-167931844 cc @bhaisaab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Build failed in Jenkins: build-master-slowbuild #2861

2015-12-29 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-29 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/869#issuecomment-167752950 @DaanHoogland / @remibergsma can you please merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-29 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/869#issuecomment-167752857 It is not type Daan. First test inside TestAttachDataDisk class tests some functionality on ZWPS and this one is for CWPS. Test Results : Attach Data

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-29 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/869#issuecomment-167753605 @sanju1010 it shouldn't be in the same file then, or the file should be renamed to a more generic name --- If your project is set up for it, you can reply to

Build failed in Jenkins: build-master-slowbuild #2854

2015-12-29 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Let’s discuss database upgrades

2015-12-29 Thread Daan Hoogland
€0,02: I think it is important to support per commit upgrades, so I not with Wido on this at all. Looking at your naming scheme that might be a problem. Other then this your initial proposal seems fine. The reason is not to allow for x.y.z schema changes but to be able to decide a certain commit

Re: master marvin install problem

2015-12-29 Thread Daan Hoogland
thanks guys, that is a rather old issue. When I install mysql-connector-python it looks in https://pypi.python.org/simple/mysql-connector-python/. The file does exist in https://pypi.python.org/pypi/mysql-connector-python/. strange error to arise all of a sudden. On Tue, Dec 29, 2015 at 7:54

Re: Let’s discuss database upgrades

2015-12-29 Thread Daan Hoogland
te: > > > > > > > On 29-12-15 14:46, Daan Hoogland wrote: > > > Wido, Rafael, > > > > > > I like the date-format but then of course CCYY-MM-DD. I can still think > > of > > > ways to screw up that (or the plain int;) > > > >

Re: Let’s discuss database upgrades

2015-12-29 Thread Wido den Hollander
On 29-12-15 13:21, Rafael Weingärtner wrote: > I got your point Daan. > > Well, and if we linked a version of ACS with a time stamp in the format of > DD.MM.? > In that case you could also say. ACS 4.6.0 == db ver X You don't have to say ver >= X, you can also say ver = X. > We could

Re: Let’s discuss database upgrades

2015-12-29 Thread Daan Hoogland
Wido, Rafael, I like the date-format but then of course CCYY-MM-DD. I can still think of ways to screw up that (or the plain int;) On Tue, Dec 29, 2015 at 1:40 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Wido, that is true, you are right; the naming on upgrade routines can

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-29 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-167769469 Site to site vpn test case results: $nosetests-2.7 --with-marvin --marvin-config=/Users/jayapalreddy/advanced-acs.cfg

Re: Let’s discuss database upgrades

2015-12-29 Thread Daan Hoogland
By this I meant I'm fine with any decision the implementer makes, btw. We will encounter the administrative issues with it and deal with them. On Tue, Dec 29, 2015 at 2:46 PM, Daan Hoogland wrote: > Wido, Rafael, > > I like the date-format but then of course CCYY-MM-DD.

Re: Let’s discuss database upgrades

2015-12-29 Thread Wido den Hollander
On 29-12-15 14:46, Daan Hoogland wrote: > Wido, Rafael, > > I like the date-format but then of course CCYY-MM-DD. I can still think of > ways to screw up that (or the plain int;) > 20151229 is a valid integer which you can simply use to compare with. 100, 101, 102 or 201

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-29 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167760979 @nitin-maharana now almost everything is ok. There is only one problem. the "org.apache.commons.lang.StringUtils.isBlank" also returns true if the

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-29 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167773312 Thanks a lot @rafaelweingartner , I learned many things. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Let’s discuss database upgrades

2015-12-29 Thread Rafael Weingärtner
I got your point Daan. Well, and if we linked a version of ACS with a time stamp in the format of DD.MM.? We could then use the time stamp in the same format to name upgrade routines. This way the idea of running all of the routines in between version during upgrades could be applied. On

Re: Let’s discuss database upgrades

2015-12-29 Thread Rafael Weingärtner
Wido, that is true, you are right; the naming on upgrade routines can use a numeric value independent of the number of the version. The numeric value can be a simple integer that is incremented each routine that is added or a time stamp when the routine was added. The point is that we would have

Re: Let’s discuss database upgrades

2015-12-29 Thread Rafael Weingärtner
, 2015 at 12:00 PM, Wido den Hollander <w...@widodh.nl> wrote: > > > On 29-12-15 14:46, Daan Hoogland wrote: > > Wido, Rafael, > > > > I like the date-format but then of course CCYY-MM-DD. I can still think > of > > ways to screw up that (or the plain int;) >

Re: Let’s discuss database upgrades

2015-12-29 Thread Rafael Weingärtner
Thanks, Daan and Wido for your contributions, I will discuss them as follows. Daan, about the idea of per commit upgrades. Do you mean that we separate each change in the database that is introduced by PRs/Commits in a different file (routine upgrade) per ACS version? So we would have,

Re: Let’s discuss database upgrades

2015-12-29 Thread Wido den Hollander
On 28-12-15 21:34, Rafael Weingärtner wrote: > Hi Wido, Rohit, > I have just read the feature suggestion. > > Wido, I am not trying to complicate things, quite the opposite, I just > illustrate a simple thing that can happen and is happening; I just pointed > how it can be easily solved. > >

Re: Let’s discuss database upgrades

2015-12-29 Thread Daan Hoogland
Rafael, On Tue, Dec 29, 2015 at 12:22 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Thanks, Daan and Wido for your contributions, I will discuss them as > follows. > > Daan, about the idea of per commit upgrades. Do you mean that we separate > each change in the database that is

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-29 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167765606 @rafaelweingartner : Thats cool. I went through the detail of isBlank, but could not catch. Thank you. I have updated. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-29 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167768433 @nitin-maharana now the code is perfect. I can give a LGTM now. Sorry if I bothered you with a lot of changes. --- If your project is set

Build failed in Jenkins: build-master-slowbuild #2855

2015-12-29 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Build failed in Jenkins: build-master-slowbuild #2856

2015-12-29 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check