Please ignore my previous email. Building offline worked.
Thanks and regards,
B Prakash
From: B Prakash
Sent: Sunday, August 28, 2016 3:06 PM
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1635#discussion_r76550534
--- Diff:
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
@@ -115,6 +115,12 @@ String
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1659
@murali-reddy Looking through the Marvin tests, there is a lot of
boilerplate code and duplicated setup in test cases. It feels like there is an
opportunity to introduce one or more base
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1659
@dsclose what is your opinion of the changes in this PR relative to your
work? Do you see any gaps or missing pieces?
---
If your project is set up for it, you can reply to this email and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1637
@lmrv does this defect impact 4.9 as well? If so, could you please
re-target this PR to the 4.9 branch?
Also, why is there a merge commit in this PR?
---
If your project is set up
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1652
@PaulAngus does this defect occur in 4.9 as well? If so, please re-target
the PR to the 4.9 branch.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi @nitt10prashant could you please collapse the test
case and feature PRs? It is very difficult to test the feature when the tests
are in a different branch.
---
If your
All,
I apologize for being behind getting the 4.8.2.0 and 4.9.1.0 RCs out. A small
part of it was due to the RC release dates falling the weekend after being on
vacation, and a large part of it is due to rookie mistakes as a first time RM.
Hopefully, the lessons learned will keep things
GitHub user jburwell opened a pull request:
https://github.com/apache/cloudstack/pull/1665
Changes database upgrade script names consistent for the 4.9.1.0 release
* Changes the names of the schema-490to491* scripts to
schema-490to4910*
* Changes the name of the
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1635#discussion_r76547668
--- Diff:
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
@@ -115,6 +115,12 @@ String
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1606
@jburwell Is there already an existing test for the previous behavior that
could be modified? I haven't had a chance to do much with Marvin other than
briefly browse the tests folder.
---
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1606
@leprechau you have expanded the type of networks blocks supported by the
system. Therefore, there should be a Marvin test case that attempts to specify
a CGN network block for a guest
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@milamberspace could you add a JIRA ticket for this issue and prefix the
title of the commit message and PR title with the ID?
---
If your project is set up for it, you can reply to this
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@nvazquez could you please amend your commit message to explain why/how
this fix addresses the defect?
Also, verification of this PR is to run ``test_network_acl`` against
VMware,
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1663
@NuxRo Any thoughts to add?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76546255
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76546205
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76546182
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76546145
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76546110
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76546049
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1648
@rhtyd thanks for clarification in the commit message -- makes total sense
now.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1621
I would like to get this PR into 4.9.1.0.
@borisstoyanov have you gotten a change to test this PR?
@rhtyd @milamberspace could you investigate the cause of the Travis build
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@rhtyd @dcarbone given that we are trying to get a 4.8 RC cut ASAP (we are
week late already), I think it is best to push this PR to 4.9.2.0. Would you
mind re-pointing it to the 4.9 branch?
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1606
@leprechau following up regarding Marvin tests. Unless they are ready, we
are likely going to have to push this PR to 4.9.2.0 since I am trying to get a
4.8.2.0 RC cut ASAP (we are week late
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1623
@ProjectMoon I am trying to cut the 4.8.2.0 RC ASAP. This PR looks like it
is not going to make it given the test failures. Do you mind re-pointing it to
4.9? We will make this PR a high
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r76545408
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -231,6 +253,73 @@ public void cleanup() {
CallContext.unregister();
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1624
@ProjectMoon both the Jenkins and Travis builds are failing. Could you
please investigate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1635#discussion_r76544594
--- Diff:
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
@@ -115,6 +115,12 @@ String
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@rhtyd do you any insight about the database schema issue @milamberspace is
encountering in the Travis build?
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@rhtyd I have updated this PR to reflect version being 4.8.2**.0** rather
than 4.8.2. I also added empty migration scripts to maintain consistency with
previous releases (e.g. 4.8.1). Could
Hi Rohit, I put-up another vm and built code on it, I got the same error. I
downloaded non oss jars and ran a build offline, I still get the same error,
unable to fix this.
Thanks and regards,
B Prakash
From: Rohit Yadav
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@jburwell now both tests passed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1660#discussion_r76532860
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -196,6 +198,9 @@ public static void scpTo(String host, int port, String
user,
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@nvazquez The Travis build has failed. Can you investigate? Likely just
needs to be re-kicked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1660#discussion_r76530524
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -196,6 +198,9 @@ public static void scpTo(String host, int port, String
user,
Github user dsclose commented on the issue:
https://github.com/apache/cloudstack/pull/1659
@murali-reddy - thank you for picking this up. Let me know when you think
it's appropriate to close PR #1519 and I shall do so.
---
If your project is set up for it, you can reply to this
37 matches
Mail list logo