Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1660#discussion_r77285299
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -196,6 +201,16 @@ public static void scpTo(String host, int port, String
user, F
All,
We are still working to merge the PR necessary to create the 4.8.2.0 and
4.9.1.0 RCs. The following is the status of the PRs targeted for 4.8.2.0:
* 1635 [1]: CLOUDSTACK-9451 — one open code review item and needs a test
LGTM
* 1636 [2]: Fix a quote issue with Spanish L10N (from tr
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@rhtyd good catch -- sorry for that oversight. I have redone the PR to
only rename the files and class.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1635
@nathanejohnson I want to get this bug fix into 4.8.2.0. In order to make
it, we need to complete the following:
* [] Resolve the question about the name of the method (``stop`` vs
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1635#discussion_r77279256
--- Diff:
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
@@ -115,6 +115,12 @@ String reserve(DeploymentPlan
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@jburwell we'll need that upgrade path class, we have some alter table
changes we want for the 4.9.0->4.9.1.0 upgrade path, see the diff for changes
you've removed.
---
If your project is set up
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1636
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@milamberspace I am trying to get this PR merged, but am running into some
issues the git-pr script. I am working with @rhtyd to figure out what I am
doing wrong.
---
If your project is set
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259462
--- Diff:
api/test/org/apache/cloudstack/api/command/test/CreateSnapshotCmdTest.java ---
@@ -0,0 +1,130 @@
+// Licensed to the Apache Software Foundatio
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259447
--- Diff: core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java
---
@@ -51,6 +50,7 @@
private final String url;
private Map de
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259407
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -328,15 +412,64 @@ private void
h
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259373
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
h
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259356
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
h
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259343
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
h
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259202
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34 @@
@Over
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259286
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34 @@
@Over
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259303
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34 @@
@Over
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259257
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -212,20 +251,47 @@ public SnapshotIn
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259176
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34 @@
@Over
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@rhtyd I have fixed the ``DatabaseUpgradeCheckerTest`` to reflect 4.9.1.0
being a ``NoopUpgrade``. I also removed the unnecessary 4.9.0->4.9.1.0 upgrade
scripts and class.
---
If your projec
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77254138
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
h
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1666
@rhtyd let's hold this fix for 4.9.2.0. I want to make sure we have had
the opportunity to thoroughly test it before merge.
---
If your project is set up for it, you can reply to this email a
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1624
@ProjectMoon we need a test LGTM. I inquired yesterday -- do you have
someone lined up to test it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77220737
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -328,15 +412,64 @@ private voi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77218636
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private voi
Hi,
I've observed on few system we've upgrade over the last months that they
don't have the same amount of global settings has opose to a fresh install
of cloudstack.
I have 3 scenarios
4.4.x to 4.7.x (484)
4.4.x to 4.7.x to 4.9.0 (494)
4.2.1 to 4.6.0 to 4.7.0 to 4.9.0 (499)
4.7.x (398)
in a
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1560
I rebased master branch, I'll post test results for this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77210539
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
h
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1624
Looks like it's ready for merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77209873
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -328,15 +412,64 @@ private void
h
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@jburwell looks like @rhtyd already tested this. Do you need another
testing? I am currently setting up my env
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@syed we received the LGTMs necessary overnight. Thank you for helping out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@jburwell @rhtyd Since #1654 has been merged. Travis and Jenkins tests have
passed. Ready to merge this small PR.
---
If your project is set up for it, you can reply to this email and hav
FYI. Issue is fixed in recently release Chrome v 53. After the update no more
WSOD ‘white square of death’
On 8/19/16, 1:51 AM, "Rohit Yadav" wrote:
Hi Sergey,
Since the same URL open perfectly fine in a tab, there must be something in
your installation of Chrome blocki
Github user milamberspace closed the pull request at:
https://github.com/apache/cloudstack/pull/1636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
GitHub user milamberspace reopened a pull request:
https://github.com/apache/cloudstack/pull/1636
Fix a quote issue with Spanish L10N (from transifex translation)
This fix is for the 4.8 branch.
You can merge this pull request into a Git repository by running:
$ git pull https:
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1624
The pull request has been rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user abhinandanprateek closed the pull request at:
https://github.com/apache/cloudstack/pull/1667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1667
Closing as it is already merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1624
@ProjectMoon please rebase now, PR 1654 has been merged now. DB upgrades
should not cause errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@jburwell this needs to be reworked now that #1654 is merged. Good to have
the changes but not a blocker for 4.8, 4.9 RCs.
---
If your project is set up for it, you can reply to this email and ha
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1670
Thanks @borisstoyanov
Based on the reviews, db upgrade and local env tests, I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Based on the tests and review. I'll proceed with merging this and fwd-merge
this across 4.9, master branches.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Tests on master branch (after fwd-merge), all pass:
- Upgrade from 4.8.2.0, upgrade from 4.9.1.0
- Clean db deployment
---
If your project is set up for it, you can reply to t
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1670
LGTM, based on review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Tests on 4.9 branch (after fwd-merge), all pass:
- Upgrade from 4.8.2.0 to 4.9.1.0
- Clean fresh db deployment
---
If your project is set up for it, you can reply to this ema
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1654
LGTM, I've stated management and the DB got updated to 4.8.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Tests on 4.8 branch, all pass:
- Clean db setup works, last upgraded version to 4.8.2.0.
| 17 | 4.8.1 | 2016-09-01 09:56:21 | Complete |
| 18 | 4.8.2.0 | 2016-09
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Given Travis has passed with 2 LGTMs and test LGTM, I'll go ahead and merge
this after testing this across 4.8->4.9, 4.9->master.
---
If your project is set up for it, you can reply to this email
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Looks good on code review
here is my LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1624
LGTM. Thanks @ProjectMoon as soon as #1654 is merged, we'll get this merged
as well. Do we have any regression tests results, especially around the changed
code?
---
If your project is set up fo
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi please add unit tests to increase code coverage,
break large methods into smaller reviewable methods. Thanks.
---
If your project is set up for it, you can reply to this ema
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1664#discussion_r77140682
--- Diff:
engine/schema/src/com/cloud/storage/dao/VMSnapshotTemplatePoolDaoImpl.java ---
@@ -0,0 +1,160 @@
+/*
+Â * Licensed to the Apache Software
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1664#discussion_r77140277
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/SeedTemplateFromVmSnapshotCmd.java
---
@@ -0,0 +1,145 @@
+/*
+Â
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1664#discussion_r77140308
--- Diff:
api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeFromVmSnapshotCmd.java
---
@@ -0,0 +1,105 @@
+// Licensed t
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1664#discussion_r77140264
--- Diff:
engine/schema/src/com/cloud/storage/VMSnapshotTemplateStoragePoolVO.java ---
@@ -0,0 +1,228 @@
+/*
+Â * Licensed to the Apache Software F
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1664#discussion_r77139978
--- Diff:
api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeFromVmSnapshotCmd.java
---
@@ -0,0 +1,105 @@
+// Licensed to the Apache So
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1664#discussion_r77139536
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/SeedTemplateFromVmSnapshotCmd.java
---
@@ -0,0 +1,145 @@
+/*
+Â * Licensed to t
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1624
Alright. I'll rebase it once #1654 has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1670#discussion_r77133791
--- Diff: setup/db/db/schema-490to491.sql ---
@@ -23,3 +23,11 @@
UPDATE `cloud`.`roles` SET `description`='Default user role' WHERE `id`=4
AND `role_t
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1670
LGTM, tested with a local installation, running it for past 3 days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
64 matches
Mail list logo