[GitHub] cloudstack pull request #1711: XenServer 7 Support

2016-11-14 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87754997 --- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh --- @@ -72,7 +72,7 @@ else fi rm $link -f fi -

[GitHub] cloudstack pull request #1711: XenServer 7 Support

2016-11-14 Thread ArmedGuy
Github user ArmedGuy commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87756104 --- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh --- @@ -72,7 +72,7 @@ else fi rm $link -f fi -lvc

[GitHub] cloudstack pull request #1711: XenServer 7 Support

2016-11-14 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87758702 --- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh --- @@ -72,7 +72,7 @@ else fi rm $link -f fi -

Apachecon this week

2016-11-14 Thread Giles Sirett
According to the schedule, the folks in CC here are all speaking on Cloudstack at Apachecon this week. It looks like Friday is the cloudstack track in room Giralda VI/VII (Jaydeep Marfatia is also speaking, but I cant find his address on the mailing lists - could one of the Accelerite folks on

RE: Apachecon this week

2016-11-14 Thread Giles Sirett
Sorry, I meant Wednesday or Thursday evening - I expect most people will be travelling on Friday Kind Regards Giles giles.sir...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue From: Giles Sirett Sent: 14 November 2016 09:11 To: dev@cloudsta

[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...

2016-11-14 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1763 ### ACS CI BVT Run **Sumarry:** Build Number 134 Hypervisor xenserver NetworkType Advanced Passed=103 Failed=2 Skipped=6 _Link to logs Folder (searc

[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...

2016-11-14 Thread yvsubhash
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...

2016-11-14 Thread yvsubhash
GitHub user yvsubhash reopened a pull request: https://github.com/apache/cloudstack/pull/1740 CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… Snapshot on primary storage not cleaned up after Storage migration. This happens in the following scenario ## St

[GitHub] cloudstack issue #1721: CLOUDSTACK-9557 Deploy from VMsnapshot fails with ex...

2016-11-14 Thread yvsubhash
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1721 @rhtyd i will merge this to #1664 once the conflicts are resolved int the other one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @yvsubhash according to the (MySQL deadlock documenation)[http://dev.mysql.com/doc/refman/5.7/en/innodb-deadlocks.html], a `MYSQL_DEADLOCK_ERROR_CODE` error indicates the enclosing transaction

Re: Apachecon this week

2016-11-14 Thread Rajesh Ramchandani
Giles - I am planning to be at ApacheCon and look forward to seeing you all. Thursday and/or Friday get together will be great. I added Jaydeep on the Cc too. Raj From: Giles Sirett Sent: Monday, November 14, 1:12 AM Subject: Apachecon this week To: dev@cloudstack.apache.org Cc: Will Stevens, G

[GitHub] cloudstack pull request #1711: XenServer 7 Support

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87836142 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java --- @@ -0,0 +1,32 @@ +/* + * Lice

[GitHub] cloudstack pull request #1711: XenServer 7 Support

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87846677 --- Diff: setup/db/db/schema-4910to41000.sql --- @@ -35,4 +35,192 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervi

[GitHub] cloudstack pull request #1711: XenServer 7 Support

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87837783 --- Diff: tools/marvin/marvin/lib/utils.py --- @@ -489,9 +490,11 @@ def checkVolumeSize(ssh_handle=None, return FAILED

[GitHub] cloudstack pull request #1711: XenServer 7 Support

2016-11-14 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87848428 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java --- @@ -0,0 +1,32 @@ +/* + * Licensed

[GitHub] cloudstack pull request #1711: XenServer 7 Support

2016-11-14 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87849857 --- Diff: setup/db/db/schema-4910to41000.sql --- @@ -35,4 +35,192 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervi

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @jburwell @yvsubhash My understanding that all roll back statements will receive MYSQL_DEADLOCK_ERROR_CODE and will be retired as a part of this patch. --- If your project is set up for it, you

[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1763 Thank you for your submission, but this issue has already been addressed as part of security fix ([CLOUDSTACK-9376](https://issues.apache.org/jira/browse/CLOUDSTACK-9376)) for 4.5+. Please se

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 my reading of the code is that only the most recently attempted DML will be re-executed. Furthermore, retrying without refreshing the base data can also lead to data corruption. The b

[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1757 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

2016-11-14 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1757 @jburwell a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests --- If your project is set up for

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1758 @nitin-maharana could you please provide a screenshot of this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

Re: Apachecon this week

2016-11-14 Thread Gabriel Beims Bräscher
Hello fellows, That would be great! I am staying at Seville until saturday (19 - Nov) afternoon. Cheers, Gabriel. Em 14/11/2016 15:07, Rajesh Ramchandani escreveu: Giles - I am planning to be at ApacheCon and look forward to seeing you all. Thursday and/or Friday get together will be great.

[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1760 @marcaurele this change looks a good check to add to LTS to as well. Could you please change the base branch to 4.9? Once you do, I will kick regression tests across all hypervisors in order

[GitHub] cloudstack pull request #1759: CLOUDSTACK-9589 vmName entries from host_deta...

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1759#discussion_r87896137 --- Diff: setup/db/db/schema-480to481-cleanup.sql --- @@ -18,3 +18,6 @@ --; -- Schema cleanup from 4.8.0 to 4.8.1; --; + +DELETE F

[GitHub] cloudstack issue #1759: CLOUDSTACK-9589 vmName entries from host_details tab...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1759 This change has been added to the `schema-480to481.sql` script. Since 4.8.1 has already shipped, this script will not be applied for those users. Therefore, this change needs to be placed in

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @jburwell I thought that most if not all of ACS interaction through DAO is rather atomic transactions. Do we have cases of multiple DML statements as a part of the same transaction? We have been

[GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1761#discussion_r87897999 --- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java --- @@ -76,4 +76,14 @@ public String getDetail(String ip) { }

[GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1761#discussion_r87900141 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -962,18 +962,22 @@ protected void updateSite2SiteVpnConnec

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 that is not a safe assumption. Transactions often span multiple statements and methods across DAOs. `TransactionLegacy` has a transaction stacking/nested model that further occludes w

[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1740#discussion_r87913074 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -,6 +,20 @@ public boolean canOperateOnVolume(Volume volume) {

[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1740#discussion_r87913578 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -,6 +,20 @@ public boolean canOperateOnVolume(Volume volume) {

[GitHub] cloudstack issue #1737: CLOUDSTACK-9561 After domain/account deletion, snaps...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1737 @SudharmaJain this fix seems like it would be good for LTS users as well. Could you please change the base branch to 4.9? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1735#discussion_r87915067 --- Diff: server/src/com/cloud/api/ApiResponseHelper.java --- @@ -526,16 +529,18 @@ public static DataStoreRole getDataStoreRole(Snapshot snapshot, Snap

[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...

2016-11-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1726#discussion_r87917132 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){ if(dow

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @jburwell @yvsubhash I might be wrong but this PR will retry on deadlock for only 2 DAO methods searchIncludingRemoved and customSearchIncludingRemoved. No update methods are set with this retr

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 there remains a risk when those methods are executed in the context of an open transaction where DMLs have already been executed and subsequent DMLs will be executed. In this scenario,

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @jburwell I concur but if @yvsubhash verified that those methods don't participate in complex DML transactions this might be still a good start. If so this approach might be expanded later to mul

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 with custom plugins, there is no way to reliably perform such tracing. I can think of batch cleanup operations in the storage layer that follow the pattern I described. Even if there

[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

2016-11-14 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1757 Trillian test result (tid-338) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 24043 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-11-14 Thread nitin-maharana
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1758 The Add Load Balancer tab was removed. ![image](https://cloud.githubusercontent.com/assets/12583725/20293745/f1a66b9a-ab1e-11e6-9707-40af38637447.png) The same functional

[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

2016-11-14 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1757 Trillian test result (tid-339) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29505 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

2016-11-14 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1757 Trillian test result (tid-337) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 30772 seconds Marvin logs: https://github.com/blueoran