Review Request 20154: Fix: ParamGenericValidationWorker shouldn't be case sensitive

2014-04-09 Thread Antonio Fornie
https://reviews.apache.org/r/20154/diff/ Testing --- Maven build, normal execution of the case and Unit Test Thanks, Antonio Fornie

Re: Review Request 19258: AclService changes to clone Acl for NetworkId

2014-03-15 Thread Antonio Fornie
rule functionalities Thanks, Antonio Fornie

Review Request 19258: AclService changes to clone Acl for NetworkId

2014-03-15 Thread Antonio Fornie
ATION server/test/com/cloud/vpc/NetworkACLServiceTest.java 786789f Diff: https://reviews.apache.org/r/19258/diff/ Testing --- Full maven build plus execution of ACL and ACL rule functionalities Thanks, Antonio Fornie

Review Request 19163: Adding some more parameter names that should not be considered unknown since they belong to general use parameters

2014-03-12 Thread Antonio Fornie
server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java 0803a2b Diff: https://reviews.apache.org/r/19163/diff/ Testing --- Full maven build including Junit Tests (updated) Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-07 Thread Antonio Fornie
ient/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-07 Thread Antonio Fornie
ient/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-07 Thread Antonio Fornie
daryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-07 Thread Antonio Fornie
ient/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-06 Thread Antonio Fornie
amples like http://localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-05 Thread Antonio Fornie
ype=type&tags[0].key=region&tags[0].value=canada Also other examples like http://localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-05 Thread Antonio Fornie
[0].value=canada Also other examples like http://localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-03 Thread Antonio Fornie
tpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-03 Thread Antonio Fornie
ey=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-03 Thread Antonio Fornie
//localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-02-28 Thread Antonio Fornie
t&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-02-28 Thread Antonio Fornie
ient/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-02-26 Thread Antonio Fornie
=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-02-25 Thread Antonio Fornie
host:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 18213: Fix and add some Rest unit and IT tests. Remove duplication of site pugin declaration. Fix by adding a missing type of RoutingConfig.

2014-02-18 Thread Antonio Fornie
f the functionality against our Ncira server. Thanks, Antonio Fornie

Review Request 18213: Fix and add some Rest unit and IT tests. Remove duplication of site pugin declaration. Fix by adding a missing type of RoutingConfig.

2014-02-18 Thread Antonio Fornie
: https://reviews.apache.org/r/18213/diff/ Testing --- Full maven lifecycle with unit and integration tests. Execute most of the functionality against our Ncira server. Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-02-18 Thread Antonio Fornie
i?command=createTags&resourceids=ids&resourcetype=type&tags[0].key=region&tags[0].value=canada Also other examples like http://localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-02-17 Thread Antonio Fornie
/ParamSemanticValidationWorkerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17888/diff/ Testing --- Full build and test plus manually testing many features. Also including CreateTagsCommand that failed in previous commit. Thanks, Antonio Fornie

Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-02-11 Thread Antonio Fornie
/com/cloud/api/dispatch/ParamSemanticValidationWorkerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17888/diff/ Testing --- Full build and test plus manually testing many features. Also including CreateTagsCommand that failed in previous commit. Thanks, Antonio Fornie

Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-02-09 Thread Antonio Fornie
commit. Thanks, Antonio Fornie

Re: Review Request 17638: Rest client moved to utils. Nvp extended.

2014-02-06 Thread Antonio Fornie
/RESTServiceConnectorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17638/diff/ Testing --- mvn full build plus unit and integration tests Thanks, Antonio Fornie

Re: Review Request 17638: Rest client moved to utils. Nvp extended.

2014-02-05 Thread Antonio Fornie
/ Testing --- mvn full build plus unit and integration tests Thanks, Antonio Fornie

Re: Review Request 17576: Detect & log unknown parameters for CS API and refactoring

2014-02-03 Thread Antonio Fornie
ttps://reviews.apache.org/r/17576/diff/ Testing --- mvn full build and manual test of functionalities Thanks, Antonio Fornie

Re: Review Request 17576: Detect & log unknown parameters for CS API and refactoring

2014-02-03 Thread Antonio Fornie
test/com/cloud/api/dispatch/ParamProcessWorkerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17576/diff/ Testing --- mvn full build and manual test of functionalities Thanks, Antonio Fornie

Re: Review Request 17638: Rest client moved to utils. Nvp extended.

2014-02-03 Thread Antonio Fornie
ly generated e-mail. To reply, visit: https://reviews.apache.org/r/17638/#review33396 ------- On Feb. 2, 2014, 7:47 a.m., Antonio Fornie wrote: > > --- > This is an auto

Review Request 17638: Rest client moved to utils. Nvp extended.

2014-02-01 Thread Antonio Fornie
full build plus unit and integration tests Thanks, Antonio Fornie

Review Request 17576: Detect & log unknown parameters for CS API and refactoring

2014-01-30 Thread Antonio Fornie
ttps://reviews.apache.org/r/17576/diff/ Testing --- mvn full build and manual test of functionalities Thanks, Antonio Fornie

Re: Review Request 16373: SecurityProfile for NiciraNvpApi, including Unit and Integration tests

2013-12-23 Thread Antonio Fornie
, Antonio Fornie

Re: Review Request 16373: SecurityProfile for NiciraNvpApi, including Unit and Integration tests

2013-12-23 Thread Antonio Fornie
/test/resources/config.properties PRE-CREATION Diff: https://reviews.apache.org/r/16373/diff/ Testing --- Unit and Integration Tests, both builds for this single submodule and for the whole stack with both default and integration profiles Thanks, Antonio Fornie

Re: Review Request 16373: SecurityProfile for NiciraNvpApi, including Unit and Integration tests

2013-12-20 Thread Antonio Fornie
/network-elements/nicira-nvp/test/resources/config.properties PRE-CREATION Diff: https://reviews.apache.org/r/16373/diff/ Testing --- Unit and Integration Tests, both builds for this single submodule and for the whole stack with both default and integration profiles Thanks, Antonio Fornie

Review Request 16373: SecurityProfile for NiciraNvpApi, including Unit and Integration tests

2013-12-18 Thread Antonio Fornie
submodule and for the whole stack with both default and integration profiles Thanks, Antonio Fornie

Re: Review Request 16295: Resources leaks, refactoring and testing for sanity check in cloud-usage

2013-12-16 Thread Antonio Fornie
.xml PRE-CREATION Diff: https://reviews.apache.org/r/16295/diff/ Testing --- Whole Maven lifecycle, Unit Tests and Integrations Tests Thanks, Antonio Fornie

Review Request 16295: Resources leaks, refactoring and testing for sanity check in cloud-usage

2013-12-16 Thread Antonio Fornie
and Integrations Tests Thanks, Antonio Fornie

Re: Review Request 16209: Fix several Resource Leak issues related to not closed PStmts and ResultSets

2013-12-12 Thread Antonio Fornie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16209/#review30257 --- Ship it! Ship It! - Antonio Fornie On Dec. 12, 2013, 9 a.m

Re: Review Request 16208: JUnit test for NetworkACLManagerImpl#applyNetworkACL

2013-12-12 Thread Antonio Fornie
/NetworkACLManagerTest.java 303da59 Diff: https://reviews.apache.org/r/16208/diff/ Testing --- Maven build lifecycle running without any problem Thanks, Antonio Fornie

Review Request 16209: Fix several Resource Leak issues related to not closed PStmts and ResultSets

2013-12-12 Thread Antonio Fornie
without any problem Thanks, Antonio Fornie

Review Request 16208: JUnit test for NetworkACLManagerImpl#applyNetworkACL

2013-12-12 Thread Antonio Fornie
, Antonio Fornie

Re: Review Request 15418: Fixes about: Code quality, checkstyle and cloudstack conventions

2013-11-18 Thread Antonio Fornie
ugins/network-elements/nicira-nvp/test/com/cloud/network/resource/NiciraNvpResourceTest.java 78465e4 Diff: https://reviews.apache.org/r/15418/diff/ Testing --- Maven build lifecycle running without any problems, including new checkstyle goals that wouldn't without these fixes Thanks

Re: Review Request 15418: Fixes about: Code quality, checkstyle and cloudstack conventions

2013-11-18 Thread Antonio Fornie
--- Maven build lifecycle running without any problems, including new checkstyle goals that wouldn't without these fixes Thanks, Antonio Fornie

Re: Review Request 15418: Fixes about: Code quality, checkstyle and cloudstack conventions

2013-11-18 Thread Antonio Fornie
Diff: https://reviews.apache.org/r/15418/diff/ Testing --- Maven build lifecycle running without any problems, including new checkstyle goals that wouldn't without these fixes Thanks, Antonio Fornie

Re: Review Request 15418: Fixes about: Code quality, checkstyle and cloudstack conventions

2013-11-12 Thread Antonio Fornie
://reviews.apache.org/r/15418/diff/ Testing --- Maven build lifecycle running without any problems, including new checkstyle goals that wouldn't without these fixes Thanks, Antonio Fornie

Review Request 15418: Fixes about: Code quality, checkstyle and cloudstack conventions

2013-11-11 Thread Antonio Fornie
that wouldn't without these fixes Thanks, Antonio Fornie

Re: Review Request 15412: Fixing coverity issue 1125364

2013-11-11 Thread Antonio Fornie
/contrail/management/ManagementNetworkGuru.java e457023 Diff: https://reviews.apache.org/r/15412/diff/ Testing --- Maven build lifecycle running without any problem Thanks, Antonio Fornie

Review Request 15412: Fixing coverity issue 1125364

2013-11-11 Thread Antonio Fornie
Diff: https://reviews.apache.org/r/15412/diff/ Testing --- Maven build lifecycle running without any problem Thanks, Antonio Fornie