Re: Question about volume snapshots

2014-08-28 Thread Chris Suich
that I can > handle > > reverting. > > > > If it's not one of mine, I can run the default logic that's provided from > > the class my strategy extends. > > > > Sounds about right? > > > > > > On Thu, Aug 28, 2014 at 1:42 PM, Chris Su

Re: Question about volume snapshots

2014-08-28 Thread Chris Suich
http://solidfire.com/solution/overview/?video=play>*(tm)* > >> > > > > > > > > -- > > *Mike Tutkowski* > > *Senior CloudStack Developer, SolidFire Inc.* > > e: mike.tutkow...@solidfire.com > > o: 303.746.7302 > > Advancing the way the world uses the cloud > > <http://solidfire.com/solution/overview/?video=play>*(tm)* > > > > > > -- > *Mike Tutkowski* > *Senior CloudStack Developer, SolidFire Inc.* > e: mike.tutkow...@solidfire.com > o: 303.746.7302 > Advancing the way the world uses the cloud > <http://solidfire.com/solution/overview/?video=play>*(tm)* > -- Chris Suich 919-334-8193 csui...@gmail.com

Re: Plugin Changes 4.3 to 4.4

2014-05-23 Thread Chris Suich
s. Does anyone have any suggestions? -- Chris Suich 919-334-8193 csui...@gmail.com

Re: NetApp plugin wins Best of Synergy 2014 award in cloud track

2014-05-20 Thread Chris Suich
10:04 AM, sebgoa wrote: > > On May 9, 2014, at 6:39 PM, "La Motta, David" > wrote: > >> I wanted to give a shout-out to Chris Suich, who was a key player in the >> team that worked on the NetApp plugin--aka Virtual Storage Console for >> Apache CloudStack

Re: Problem with mailing list....

2014-05-13 Thread Chris Suich
I seemed to notice that the email list went silent for 24-48 hours around last Thursday/Friday. On Tue, May 13, 2014 at 7:57 PM, Alex Huang wrote: > I've find some of my emails did not make it to the mailing list. Does anyone > else have this problem? > > --Alex -- Chris S

Re: CloudStack 4.3+ Plugins

2014-04-23 Thread Chris Suich
ifying > applicationContext.xml.inand commands.properties.in. 4.3 appears to have > introduces discoverable plugins. What needs to be done differently in order > to take advantage of this? > Thank you for your time, > Matt -- Chris Suich 919-334-8193 csui...@gmail.com

Review Request 20250: Fixed errors with simulator VM snapshot delete and revert

2014-04-10 Thread Chris Suich
hether this was just a typo of '!=' instead of '=='? Diffs - plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java f487eb4 Diff: https://reviews.apache.org/r/20250/diff/ Testing --- Thanks, Chris Suich

Re: Review Request 19460: Check for returned null, throw exception rather than continue.

2014-03-20 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19460/#review37891 --- Ship it! Ship It! - Chris Suich On March 20, 2014, 2:42 p.m

Re: Review Request 19460: Check for returned null, throw exception rather than continue.

2014-03-20 Thread Chris Suich
into VolumeServiceImpl.takeSnapshot()'s catch instead of just ignoring the exception it would be handled for anyone who tries to take a snapshot. - Chris Suich On March 20, 2014, noon, Alex Hitchins wrote: > > --- > This is an automa

Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-05 Thread Chris Suich
/diff/ Testing --- Thanks, Chris Suich

Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-05 Thread Chris Suich
/ Testing --- Thanks, Chris Suich

Review Request 16041: CLOUDSTACK-5384 UI dataProviders are unable to differentiate between load and refresh context

2013-12-05 Thread Chris Suich
: cloudstack-git Description --- Added load vs refresh context/indicator for dataProviders for CLOUDSTACK-5384 Diffs - ui/scripts/ui/widgets/detailView.js 3a3cd79 Diff: https://reviews.apache.org/r/16041/diff/ Testing --- Thanks, Chris Suich

Review Request 16001: ListViews marked with 'needsRefresh' do not have loading overlay removed on error

2013-12-04 Thread Chris Suich
remove the overlay when an error occurs during the operation. This is for JIRA-5368. If accepted, please apply to 4.3 branch as well. Diffs - ui/scripts/ui/widgets/listView.js 53b37f1 Diff: https://reviews.apache.org/r/16001/diff/ Testing --- Thanks, Chris Suich

Re: Review Request 15521: Fixed issue with DataStoreDrivers not being able to throw meaningful errors

2013-12-03 Thread Chris Suich
/src/com/cloud/storage/StorageManagerImpl.java e81e30e Diff: https://reviews.apache.org/r/15521/diff/ Testing --- Thanks, Chris Suich

Re: Review Request 15840: CLOUDSTACK-5206: Ability to control the external id of first class objects

2013-11-26 Thread Chris Suich
VirtualNetworkApplianceManagerImpl.java. Was that intentional? - Chris Suich On Nov. 25, 2013, 6:55 p.m., Nitin Mehta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 15521: Fixed issue with DataStoreDrivers not being able to throw meaningful errors

2013-11-14 Thread Chris Suich
e81e30e Diff: https://reviews.apache.org/r/15521/diff/ Testing --- Thanks, Chris Suich

Review Request 15362: Fixed issue with detail view fields marked as 'isPassword' not being obfuscated

2013-11-08 Thread Chris Suich
mitted, the password is still visible in plain text. This patch fixes the issue by respecting the 'isPassword' attribute on detail view fields. Diffs - ui/scripts/ui/widgets/detailView.js 65f71b3 Diff: https://reviews.apache.org/r/15362/diff/ Testing --- Thanks, Chris Suich

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread Chris Suich
/ Testing (updated) --- Thanks, Chris Suich

Re: Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

2013-11-07 Thread Chris Suich
advantage of. Thanks, Chris Suich

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread Chris Suich
/ Testing (updated) --- This has been tested locally with a custom plugin. However, the changes are not used by the existing CloudStack codebase and should not impact any existing workflows or use cases. They are simply for plugins to take advantage of. Thanks, Chris Suich

Review Request 15326: Added option to reload VM during in RevertToVMSnapshotCommand

2013-11-07 Thread Chris Suich
Testing --- This has been tested locally with a custom plugin. However, the changes are not used by the existing CloudStack codebase and should not impact any existing workflows or use cases. They are simply for plugins to take advantage of. Thanks, Chris Suich

Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

2013-11-07 Thread Chris Suich
://reviews.apache.org/r/15313/diff/ Testing --- Thanks, Chris Suich

Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread Chris Suich
supposed to be changed to store.getUuid() but was actually changed to volumeTo.getUuid(). Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 0e2423e Diff: https://reviews.apache.org/r/15309/diff/ Testing --- Thanks, Chris

Re: Review Request 14914: Make commands.properties optional for non-ACS code

2013-10-25 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14914/#review27529 --- Ship it! Works great! - Chris Suich On Oct. 24, 2013, 10:06 p.m

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-23 Thread Chris Suich
d-commit-of-the-following.patch Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-22 Thread Chris Suich
test this type of code. If anyone has any recommendations, please let me know. File Attachments (updated) https://reviews.apache.org/media/uploaded/files/2013/10/22/0001-Squashed-commits-from-review-revisions.patch Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-22 Thread Chris Suich
how to properly unit test this type of code. If anyone has any recommendations, please let me know. File Attachments (updated) https://reviews.apache.org/media/uploaded/files/2013/10/22/commits.patch Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-22 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27303 --- On Oct. 22, 2013, 2:48 p.m., Chris Suich wrote: > > --

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-22 Thread Chris Suich
trategy-sorting-selection.patch https://reviews.apache.org/media/uploaded/files/2013/10/22/0003-Added-context-to-strategy-sorting-error-responses.patch https://reviews.apache.org/media/uploaded/files/2013/10/22/0004-Updated-DataMotionServiceImpl-and-ApiResponseHelper-.patch Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-22 Thread Chris Suich
Testing --- I have tested all of this locally with a custom storage provider. Unfortunately, I'm still in the middle of figuring out how to properly unit test this type of code. If anyone has any recommendations, please let me know. Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-22 Thread Chris Suich
em. Is there some way around this? - Chris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27298 ------- On Oct. 17, 2013, 6:46 p.m., Chris Suich wrote: > > -

Re: Review Request 14823: Refactor StrategyPriority

2013-10-22 Thread Chris Suich
> On Oct. 22, 2013, 1:19 p.m., Chris Suich wrote: > > Darren, the design of all of this has already changed here: > > https://reviews.apache.org/r/14522/. Take a look at the newer revisions > > which haven't made it in yet (still waiting on a final review from Joh

Re: Review Request 14823: Refactor StrategyPriority

2013-10-22 Thread Chris Suich
imply chose one by iterating over the list of strategies once and returning the best strategy. - Chris Suich On Oct. 22, 2013, 3:34 a.m., Darren Shepherd wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 14782: [CLOUDSTACK-4910] Take VM snapshot instantly returns success regardless of actual result

2013-10-21 Thread Chris Suich
: cloudstack-git Description --- Fixed a typo causing vm snapshot requests to always instantly return successful in the CloudStack UI. Diffs - ui/scripts/instances.js 41d1772 Diff: https://reviews.apache.org/r/14782/diff/ Testing --- Thanks, Chris Suich

Review Request 14715: [CLOUDSTACK-4887] CLVM broken

2013-10-17 Thread Chris Suich
/ Testing --- Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-17 Thread Chris Suich
context information to error message to help operators and users > > determine what couldn't be snapshotted. > > Chris Suich wrote: > Fair enough - I just copied these existing error messages. What kind of > context would you like to see in this error message? The src

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-17 Thread Chris Suich
Testing --- I have tested all of this locally with a custom storage provider. Unfortunately, I'm still in the middle of figuring out how to properly unit test this type of code. If anyone has any recommendations, please let me know. Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-17 Thread Chris Suich
e volume. - Chris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27126 --- On Oct. 16, 2013, 2:50 p.m., Chris Suich wrote: > >

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-16 Thread Chris Suich
is locally with a custom storage provider. Unfortunately, I'm still in the middle of figuring out how to properly unit test this type of code. If anyone has any recommendations, please let me know. Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-15 Thread Chris Suich
derlying device can take a snapshot without > > accounting for whether or not the volume is in a state to take a consistent > > snapshot. I am also concerned that we don't have a semantic for handling > > errors that might result from the actual snapshot operation. > &g

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-15 Thread Chris Suich
d to throw an exception when a > > snapshot can't be reverted. In addition to be a simpler approach, it > > covers both the scenario when a device does not support reverting snapshots > > and, as well as, the device or the snapshot not being a revertable state. > >

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-15 Thread Chris Suich
d to throw an exception when a > > snapshot can't be reverted. In addition to be a simpler approach, it > > covers both the scenario when a device does not support reverting snapshots > > and, as well as, the device or the snapshot not being a revertable state. > >

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-15 Thread Chris Suich
d to throw an exception when a > > snapshot can't be reverted. In addition to be a simpler approach, it > > covers both the scenario when a device does not support reverting snapshots > > and, as well as, the device or the snapshot not being a revertable state. > >

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-15 Thread Chris Suich
8> > > > > Very poor performance as it circumvents the primitive pool. Change to > > Integer.valueOf(i1).compareTo(Integer.valueOf(i2)). Will do. > On Oct. 15, 2013, 2:41 p.m., John Burwell wrote: > > engine/storage/snapshot/src/org/apache/c

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-14 Thread Chris Suich
recommendations, please let me know. Thanks, Chris Suich

Review Request 14637: Fixed a bug with takeSnapshot failing as 'Not implemented'

2013-10-14 Thread Chris Suich
--- Thanks, Chris Suich

Re: Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-14 Thread Chris Suich
there shouldn't be any issues. However, I did do a clean build and played around with the UI while watching vmops.log to make sure there were no errors being thrown over this. Thanks, Chris Suich

Review Request 14609: Added Categorized Sorting of SnapshotStrategy and DataMotionStrategy

2013-10-11 Thread Chris Suich
). Thanks, Chris Suich

Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-10 Thread Chris Suich
re were no errors being thrown over this. Thanks, Chris Suich

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-08 Thread Chris Suich
: https://reviews.apache.org/r/14522/#review26786 ------- On Oct. 7, 2013, 8:26 p.m., Chris Suich wrote: > > --- > This is an automatically generated e-m

Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-07 Thread Chris Suich
know. Thanks, Chris Suich

Review Request 14516: Added storage_provider_name to storage_pool_view

2013-10-07 Thread Chris Suich
--- server/src/com/cloud/api/query/vo/StoragePoolJoinVO.java 69f2204 setup/db/db/schema-420to430.sql 653ff77 Diff: https://reviews.apache.org/r/14516/diff/ Testing --- Thanks, Chris Suich

Review Request 14477: Refactor Storage Related Resource Code

2013-10-03 Thread Chris Suich
Resource.java 3ef950b Diff: https://reviews.apache.org/r/14477/diff/ Testing --- Thanks, Chris Suich

Re: Review Request 14285: Add multi-row action support to UI list views (CLOUDSTACK-1579)

2013-09-27 Thread Chris Suich
b Diff: https://reviews.apache.org/r/14285/diff/ Testing --- Testing has been done in conjunction with a UI plugin I am developing. Additional testing will be performed as this is integrated into existing parts of the UI. Thanks, Chris Suich

Review Request 14285: Add multi-row action support to UI list views (CLOUDSTACK-1579)

2013-09-23 Thread Chris Suich
itional testing will be performed as this is integrated into existing parts of the UI. Thanks, Chris Suich

Review Request 13833: Added missing getters to UserVmResponse

2013-08-26 Thread Chris Suich
--- UserVmResponse was missing some getters, so I generated them with Eclipse. Diffs - api/src/org/apache/cloudstack/api/response/UserVmResponse.java e49e16b Diff: https://reviews.apache.org/r/13833/diff/ Testing --- Thanks, Chris Suich

Re: Review Request 13131: Default field identifier

2013-08-02 Thread Chris Suich
3131/diff/ Testing --- File Attachments https://reviews.apache.org/media/uploaded/files/2013/07/31/field-identify-value.patch Thanks, Chris Suich

Re: Review Request 13132: Field default value functions

2013-08-02 Thread Chris Suich
ermined at run time. Diffs - ui/scripts/sharedFunctions.js 8ddaeaf ui/scripts/ui/dialog.js 1ff5401 Diff: https://reviews.apache.org/r/13132/diff/ Testing --- Thanks, Chris Suich

Re: Review Request 13134: has_units UI Field Type

2013-08-02 Thread Chris Suich
ome way to fix this. Diffs - Diff: https://reviews.apache.org/r/13134/diff/ Testing --- File Attachments https://reviews.apache.org/media/uploaded/files/2013/07/31/has_units-field.patch Thanks, Chris Suich

Re: Review Request 13128: Zone Chart Extension

2013-08-02 Thread Chris Suich
Diffs - ui/scripts/ui-custom/zoneChart.js 1a5fb59 Diff: https://reviews.apache.org/r/13128/diff/ Testing --- Thanks, Chris Suich

Re: Review Request 13127: UI Plugin Internationalization

2013-08-02 Thread Chris Suich
appropriate plugin dictionary is loaded into the global js dictionary (with the global dictionary taking precedence in the event of a conflict). Diffs - ui/scripts/plugins.js 96ed229 Diff: https://reviews.apache.org/r/13127/diff/ Testing --- Thanks, Chris Suich