RE: Git Push Summary

2013-07-30 Thread Saksham Srivastava
Isaac, I tried some of your changes. Looks good. Regards, Saksham -Original Message- From: Isaac Chiang [mailto:isaacchi...@gmail.com] Sent: Wednesday, July 24, 2013 3:12 PM To: Pranav Saxena Cc: dev@cloudstack.apache.org Subject: Re: Git Push Summary Hi all, I've been working

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Saksham Srivastava
--- On July 27, 2013, 6:58 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/ --- (Updated July 27, 2013, 6

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Saksham Srivastava
(TemplateProfile) method, you will see that there is a for-loop to download the template to each image store for each zone. For each image store, this createTemplateAsyncCallback will be invoked. So in this callback, you should just generate usage event for this zone. Saksham Srivastava wrote

Review Request 13020: CLOUDSTACK-3252 An instance deployed using explicit or implicit dedication doesn't generate a usage even

2013-07-29 Thread Saksham Srivastava
processed: 0 virtual_size: NULL Build passed. Patch applies cleanly. Thanks, Saksham Srivastava

Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

2013-07-27 Thread Saksham Srivastava
://reviews.apache.org/r/12993/diff/ Testing --- Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/ --- (Updated July 26, 2013, 12:42 p.m

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
://reviews.apache.org/r/12968/#comment47832 Min, I have created a new patch addressing all the concerns, also removed extra checks. - Saksham Srivastava On July 27, 2013, 6:58 p.m., Saksham Srivastava wrote

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
| ++-++-+-+-+---+-+-+--+---+---+--+ Build passed. Patch applies cleanly. Thanks, Saksham Srivastava

Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-26 Thread Saksham Srivastava
| ++-++-+-+-+---+-+-+--+---+---+--+ Build passed. Patch applies cleanly. Thanks, Saksham Srivastava

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-24 Thread Saksham Srivastava
/StorageUsageParser.java 337e8e2 Diff: https://reviews.apache.org/r/12852/diff/ Testing --- Usage event generated for creating template with virtual size. Thanks, Saksham Srivastava

RE: Git Push Summary

2013-07-24 Thread Saksham Srivastava
Not there in 4.2? -Original Message- From: Isaac Chiang [mailto:isaacchi...@gmail.com] Sent: Wednesday, July 24, 2013 3:12 PM To: Pranav Saxena Cc: dev@cloudstack.apache.org Subject: Re: Git Push Summary Hi all, I've been working on re-factoring the dedication UI code in these

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread Saksham Srivastava
/schema-410to420.sql f9417a0 Diff: https://reviews.apache.org/r/12811/diff/ Testing --- Thanks, Saksham Srivastava

Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-23 Thread Saksham Srivastava
for creating template with virtual size. Thanks, Saksham Srivastava

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-22 Thread Saksham Srivastava
are generated. Thanks, Saksham Srivastava

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-22 Thread Saksham Srivastava
implicitly dedicated hosts and alerts are generated. Thanks, Saksham Srivastava

Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-22 Thread Saksham Srivastava
--- Thanks, Saksham Srivastava

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-19 Thread Saksham Srivastava
implicitly dedicated hosts and alerts are generated. Thanks, Saksham Srivastava

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-19 Thread Saksham Srivastava
/#review23372 --- On July 19, 2013, 11:52 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720

Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-18 Thread Saksham Srivastava
server/src/com/cloud/vm/UserVmManagerImpl.java 9968690 Diff: https://reviews.apache.org/r/12720/diff/ Testing --- Migrated VMs across explicitly dedicated hosts and alerts are generated. Migrated VMs across implicitly dedicated hosts and alerts are generated. Thanks, Saksham Srivastava

RE: Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail when release dedicated resource to that domain fails:

2013-07-18 Thread Saksham Srivastava
The fix should qualify for 4.1.1 Thanks, Saksham -Original Message- From: Musayev, Ilya [mailto:imusa...@webmd.net] Sent: Thursday, July 18, 2013 6:41 AM To: dev@cloudstack.apache.org; Alena Prokharchyk; Devdeep Singh Cc: Saksham Srivastava; cloudstack Subject: RE: Review Request 12510

Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail when release dedicated resource to that domain fails:

2013-07-12 Thread Saksham Srivastava
://reviews.apache.org/r/12510/diff/ Testing --- If domain has dedicated resources, cleanup=true will release dedication and delete the domain. cleanup=false will not release dedication and will not delete the domain. Thanks, Saksham Srivastava

Re: Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail when release dedicated resource to that domain fails:

2013-07-12 Thread Saksham Srivastava
--- On July 12, 2013, 2:01 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12510/ --- (Updated July 12

Review Request 12326: CLOUDSTACK-3094: Adding a shared network to already deployed VM is failing.

2013-07-08 Thread Saksham Srivastava
://reviews.apache.org/r/12326/diff/ Testing --- Created a shared network. Added the NIC to a vm with error state, causing a NIC entry in db but removed as not null. Added the same network again without error state, the network gets added. Thanks, Saksham Srivastava

Re: Review Request 11627: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

2013-06-28 Thread Saksham Srivastava
--- Tested on local setup. Build successful. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

2013-06-24 Thread Saksham Srivastava
://reviews.apache.org/r/11627/diff/ Testing --- Tested on local setup. Build successful. Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-3064: Able to create VM from different account of the same domain without using Affinity group even the Zone is dedicated to an Account.

2013-06-21 Thread Saksham Srivastava
/DeploymentPlanningManagerImpl.java 4ef2152 Diff: https://reviews.apache.org/r/12028/diff/ Testing --- Tested dedicating zone, then deploying vms from other accounts, it fails now. Also if no affinity group is chosen for the same account, vm deployment fails. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

2013-06-19 Thread Saksham Srivastava
vlan480-504;910-914;916-918;920-923;925-934;936-940/vlan isolationmethodsVLAN/isolationmethods /physicalnetwork /listphysicalnetworksresponse Build passes successfully. Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

2013-06-07 Thread Saksham Srivastava
/listphysicalnetworksresponse Build passes successfully. Thanks, Saksham Srivastava

RE: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

2013-06-05 Thread Saksham Srivastava
- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, June 05, 2013 12:40 AM To: dev@cloudstack.apache.org; Chiradeep Vittal Cc: Kishan Kavala; Saksham Srivastava; cloudstack Subject: Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades Also

Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.

2013-06-05 Thread Saksham Srivastava
= Existing Reservation is not affected. Added UnitTest testIsSameIpRange() Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-2130:UpdateDefaultNicForVirtualMachine api should also create usage events for updating new default network

2013-05-29 Thread Saksham Srivastava
| | 28 | NETWORK.OFFERING.ASSIGN | 2 | 2013-05-29 12:31:58 | 1 | 3 | 8 | 8 |NULL | 0 | NULL | 0 | Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-28 Thread Saksham Srivastava
. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-27 Thread Saksham Srivastava
unit tests under : plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host

2013-05-27 Thread Saksham Srivastava
is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-24 Thread Saksham Srivastava
/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host

2013-05-24 Thread Saksham Srivastava
Successful. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-24 Thread Saksham Srivastava
: For the new APIs and Service, added unit tests under : plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-24 Thread Saksham Srivastava
generated e-mail. To reply, visit: https://reviews.apache.org/r/11379/#review21000 --- On May 24, 2013, 7:30 p.m., Saksham Srivastava wrote: --- This is an automatically generated e

Re: [ANNOUNCE] New committer: Venkata Swamy

2013-05-23 Thread Saksham Srivastava
Congrats Swamy. On Friday 24 May 2013 02:51 AM, Chip Childers wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Venkata Swamy to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute

Review Request: CLOUDSTACK-2130: UpdateDefaultNicForVirtualMachine api should also create usage events for updating new default network

2013-05-14 Thread Saksham Srivastava
Diff: https://reviews.apache.org/r/11156/diff/ Testing --- Tested manually. Rat build passed. Rebased to latest master. Thanks, Saksham Srivastava

Template not getting downloaded on latest master

2013-05-10 Thread Saksham Srivastava
Hi, I did a fresh setup of CloudStack master, Both the system vms are running fine and the secondary storage is also shown enabled. But the built-in template is not getting downloaded. ISO Registration happens but the ISO download is not initiated. I keep on getting this message in the logs:

RE: Template not getting downloaded on latest master

2013-05-10 Thread Saksham Srivastava
? It could be related to CLOUDSTACK-2064 On 10-May-2013, at 7:20 PM, Saksham Srivastava saksham.srivast...@citrix.com wrote: Hi, I did a fresh setup of CloudStack master, Both the system vms are running fine and the secondary storage is also shown enabled. But the built-in template is not getting

Fix for CLOUDSTACK-2277

2013-05-09 Thread Saksham Srivastava
Hi Mice , I just saw your commit for https://issues.apache.org/jira/browse/CLOUDSTACK-2277 So I recently picked this bug, marked it as in progress as I was working on it and was about to submit the patch for the same, but then I saw that you already fixed it :) A quick comment : The fix

RE: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well

2013-05-02 Thread Saksham Srivastava
(10.1.1.255) for the entire network. Am I missing something? Regards, Saksham From: Sateesh Chodapuneedi Sent: Thursday, May 02, 2013 3:55 PM To: Saksham Srivastava; Murali Reddy Cc: cloudstack Subject: RE: Review Request: CLOUDSTACK-1748: IP Reservation results

Re: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well

2013-04-30 Thread Saksham Srivastava
., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10078/ --- (Updated March 22, 2013, 10:04 a.m.) Review

Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.

2013-04-23 Thread Saksham Srivastava
://reviews.apache.org/r/10005/diff/ Testing --- CIDR : 10.0.144.0/20, Network CIDR : null, guestVmCidr : 10.0.151.0/20 = Reservation is not applied. CIDR : 10.0.144.0/21, Network CIDR : 10.0.144.0/20, guestVmCidr : 10.0.151.0/20 = Existing Reservation is not affected. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.

2013-04-19 Thread Saksham Srivastava
. To reply, visit: https://reviews.apache.org/r/10005/#review19396 --- On April 19, 2013, 9:45 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply

Re: Add/Remove Network for VM : VMware Support

2013-04-17 Thread Saksham Srivastava
FS is available at : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Add+Remove+Networks+to+VMs+%28Enhanced%29 Thanks, Saksham On Monday 15 April 2013 11:11 PM, Saksham Srivastava wrote: Following the discussion on bug: https://issues.apache.org/jira/browse/CLOUDSTACK-645 , there needs

RE: [Add/Remove Network to VM] Multiple NICs on same Guest Network

2013-04-15 Thread Saksham Srivastava
). Should we allow only one of them, as they both tend to serve the same purpose, or am I missing something? Thanks, Saksham From: Marcus Sorensen [shadow...@gmail.com] Sent: Saturday, April 13, 2013 9:03 PM To: Saksham Srivastava Cc: dev@cloudstack.apache.org Subject: Re

Add/Remove Network for VM : VMware Support

2013-04-15 Thread Saksham Srivastava
Following the discussion on bug: https://issues.apache.org/jira/browse/CLOUDSTACK-645 , there needs to be some work done for enhancing VMware support for the feature Add/Remove Network on VM. I will be updating the FS soon and will send out for review. Thanks, Saksham

What should be the expected behaviour when VM is deployed (not through CloudStack) on CloudStack managed hosts? Was [IP Reservation] Is VM creation using the reserved IPs on cloudstack managed hosts

2013-04-12 Thread Saksham Srivastava
Changing the subject and reposting. -Original Message- From: Abhinav Roy [mailto:abhinav@citrix.com] Sent: Tuesday, April 02, 2013 10:36 AM To: dev@cloudstack.apache.org Subject: RE: [IP Reservation] Is VM creation using the reserved IPs on cloudstack managed hosts supported? Hi,

<    1   2