[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

2015-12-04 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1176 CLOUDSTACK-9025: Fixed can't create usable template from snapshot in Xenserver and Vmware https://issues.apache.org/jira/browse/CLOUDSTACK-9025 Fix also reverts below commit

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

2015-12-04 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

2015-12-04 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1174 CLOUDSTACK-9025: Fixed can't create usable template from snapshot in Xenserver and Vmware https://issues.apache.org/jira/browse/CLOUDSTACK-9025 Fix also reverts below commit

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

2015-12-04 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1166#discussion_r46673018 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -459,12 +463,8 @@ public

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

2015-12-04 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-161927620 @ustcweizhou That bug is already taken care in Ovm3 guru code with commit 66fed46 --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

2015-12-04 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-161926840 This file could be used while fixing some time taking bugs in Console Proxy code. It can be used in similar way as described on https://cwiki.apache.org

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

2015-12-04 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-161931232 @ustcweizhou I differ on this. We should not make HypervisorGuruManagerImpl complex by adding these kind of conditions as nobody is expert of all hypervisors

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

2015-12-03 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1164#issuecomment-161891307 Created PR https://github.com/apache/cloudstack/pull/1166 for 4.6. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

2015-12-03 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1166 CLOUDSTACK-8845: Fixed list snapshots command throwing exception https://issues.apache.org/jira/browse/CLOUDSTACK-8845 CLOUDSTACK-8845: Fixed list snapshots command throwing

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

2015-12-03 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

2015-12-03 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1164 CLOUDSTACK-8845: Fixed list snapshots command throwing exception https://issues.apache.org/jira/browse/CLOUDSTACK-8845 Fixed list snapshots command throwing exception if any one

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-12-01 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-161180226 @DaanHoogland I don't understand how json format is helping here? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-12-01 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-160938583 @DaanHoogland Could you suggest a better way of putting this information in API documents in current scenario? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-11-26 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1126 CLOUDSTACK-9088: Update the description for migrateVirtualMachineWithVolume api https://issues.apache.org/jira/browse/CLOUDSTACK-9088 You can merge this pull request into a Git repository

[GitHub] cloudstack pull request: CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed ...

2015-10-14 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/787#issuecomment-147970195 @remibergsma I will add the test if I gets the time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed ...

2015-10-10 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/787#issuecomment-147117991 @remibergsma @bhaisaab Updated the description with testing requirements. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8894: Restrict vGPU enabled VM...

2015-09-30 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/868#issuecomment-144328947 @runseb Updated the bug description. I am looking into travis tests. This test will require vGPU enabled hosts with different type of GPU cards. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8894: Restrict vGPU enabled VM...

2015-09-30 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/868#issuecomment-144341943 @runseb It seems like simulator does't have support for vGPU. If I find some time then I will try to add support for it. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

2015-09-28 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-143647389 Rebased the PR to current master. Regarding unit tests, method doesn't have input or output as a unit. It has output only in terms of DB updation so

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143639563 LGTM on the basis of code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-26 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143442228 We don't need new method isPowerStateUpToDate(long instanceId) as we are already performing the same operations in _instanceDao.updatePowerState(entry.getKey

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142903425 This simply means that there power_state has not changed for that period of time. As I pointed out in my previous comment that if state is consecutively updated

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142899514 From code it seems to be getting updated and DB also suggests that. It will not be updated if there is no power change

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142909650 Yes, increasing time should help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142920071 I have followed your explanation but what I am trying to say is that it may get updated due to side effect of some other code as from my experience

[GitHub] cloudstack pull request: CLOUDSTACK-8894: Restrict vGPU enabled VM...

2015-09-22 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/868 CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141613687 @DaanHoogland what update_time are you talking about? I think as a work around increasing ping interval to some higher value like 90 sec or 120 seconds

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

2015-09-16 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/835 CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination Also changed viewer/console identifier to vm uuid + vnc port to avoid using same connection console

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140665483 Currently we report only PowerOn VMs and do not report PowerOff VMs that's why we consider Missing and PowerOff as same And that's how whole code is written

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

2015-09-14 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/793#discussion_r39367811 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -1046,4 +1046,51 @@ private VmWorkJobVO createPlaceHolderWork(long

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

2015-09-14 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-139989420 @karuturi I don't get what will be validate by adding above kind of tests other than what I have mentioned in my previous comment. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

2015-09-14 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-139975023 @bhaisaab Here we are just accessing and updating the DB and not much logic is involved. So I can think of tests which does data validation of DB which

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-13 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-139968967 Attached the screenshots to ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2015-09-13 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/803#discussion_r39361975 --- Diff: engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java --- @@ -350,4 +351,20 @@ public void

[GitHub] cloudstack pull request: Fixed secstorage.proxy is not setting pro...

2015-09-11 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/802 Fixed secstorage.proxy is not setting proxy configuration on SSVM in some cases You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-11 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/804 CLOUDSTACK-8834: Fixed unable to download Template , when in multi zones We were listing image stores by zone id which was resulting in listing of only one image store If in that image

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

2015-09-09 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/793 CLOUDSTACK-8827: Move the VM snapshots stuck in transitional states to stable states during managment server restart i.e. If snapshot in creating state move it to Error state

[GitHub] cloudstack pull request: CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed ...

2015-09-08 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/787 CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed issues if vm.allocation.algorithm is set to firstfitleastconsumed Fixed following issues if vm.allocation.algorithm is set to firstfitleastconsumed

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-26 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37964980 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2188,7 +2188,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-26 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37964142 --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java --- @@ -136,13 +136,13 @@ public String getInstanceName

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-26 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134931329 @bhaisaab Lost in discussion and got only end result that all we need is here. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-26 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134925254 @bhaisaab What else is needed here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-26 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134938776 @remibergsma @bhaisaab Remi has already tested this and has given the LGTM. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

2015-08-18 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132186831 @DaanHoogland That doesn't seems to be the case here. I believe if somebody has to change unit test with every change then that unit test is burden and should

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

2015-08-18 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132438972 @rafaelweingartner @DaanHoogland If the purpose is to make sure that path is not modified by other developer then adding note/comment on top of that line makes

[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...

2015-08-17 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/672#issuecomment-131736170 @remibergsma First part of snapshot improvements is not yet implemented. To test verify following operations VM snapshots and volume snapshots

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-08-17 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-132072709 @DaanHoogland Updated the code with review comments. Regarding unit tests I am identifying modules for which unit tests can be written. But be aware

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

2015-08-17 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132067886 @cristofolini @DaanHoogland Are these unit tests adding any value? What type of value are they adding here? To me these seems to be burden on maintainer

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-08-17 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-131724787 @remibergsma Either we have to squash all commits to one commit or leave it as it is. In squashing all commits to one I will put all the relevant messages

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-16 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/669#issuecomment-131683677 @sedukull , Can you give a LGTM now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...

2015-08-16 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/672#issuecomment-131674635 @remibergsma Updated the description with bug link. These commits covers only second part i.e. allowing volume and VM snapshots to exist together. --- If your

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-08-16 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-131678148 Updated the code as per review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-08-14 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-130996684 Unit test which is failing is testing KVM code and is not related to any changes in this file --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-13 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36949815 --- Diff: client/pom.xml --- @@ -478,6 +478,12 @@ copy todir=${basedir}/target/generated-webapp/WEB-INF/classes/scripts

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-08-13 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-130973969 Removed the MigrateCompleteCommand as per review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-12 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36833745 --- Diff: client/pom.xml --- @@ -478,6 +478,12 @@ copy todir=${basedir}/target/generated-webapp/WEB-INF/classes/scripts

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36710980 --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java --- @@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r3676 --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java --- @@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36711314 --- Diff: systemvm/js/ajaxviewer.js --- @@ -184,7 +205,7 @@ KeyboardMapper.prototype = { if(eventType == AjaxViewer.KEY_UP

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-129696884 @remibergsma Using cloudmonkey we can pass as shown below update virtualmachine id=00f19661-da81-40b2-a07c-e46967421195 details[0].keyboard=fr

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36710619 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36710924 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36710950 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -595,6 +597,25 @@ private

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611140 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -595,6 +597,25 @@ private

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36612331 --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java --- @@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611014 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1279,6 +1285,27 @@ private static DiskTO

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611046 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1279,6 +1285,27 @@ private static DiskTO

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611296 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36609278 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36612463 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -595,6 +597,25 @@ private

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36612869 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59

[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...

2015-08-10 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/672 Allow VM snapshots and volume snapshots to exist together This branch fixes issues involved in allowing VM snapshots and volume snapshots to exist together. You can merge this pull request

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/669 Made the adding new keyboard language support easier This branch has implemented following improvements in console proxy keyboard language support 1) ajaxviewer.js and ajaxkeys.js

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-129407249 cloudstack-pull-requests #945 failure is because of some random error in git fetching --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-10 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/673 CLOUDSTACK-8721: Fixed Setting details of VM through API results in removal of all other details except the one passed in API You can merge this pull request into a Git repository

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-08-09 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-129292846 @remibergsma, Rebased the branch to latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

2015-08-05 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128231212 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-07-26 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-125090049 Rebased the code to latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-07-14 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-121174974 @runseb These are false failures. The changes on which these tests are failing are in Hyper-V agent so can be safely ignored as these tests are not testing Hyper

[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...

2015-06-17 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/466#issuecomment-113046025 Yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-06-03 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/351 This branch implements the CSV and native HA support for Hyper-V For design related details refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/iSCSI+and+HA+support+in+Hyper-V

[GitHub] cloudstack pull request: CLOUDSTACK-8431: [Hyper-V] Fixed VM deplo...

2015-04-30 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/214 CLOUDSTACK-8431: [Hyper-V] Fixed VM deployment failing when the stale vhd already exists Now generating guid when the template copy from secondary to primary storage requested instead

[GitHub] cloudstack pull request: CLOUDSTACK-8423: [Xenserver] Improved the...

2015-04-28 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/204 CLOUDSTACK-8423: [Xenserver] Improved the performance for processing of ClusterVMMetaDataSync command Current way of processing can cause slowness in DB if there are huge number of VMs

[GitHub] cloudstack pull request: CLOUDSTACK-8418: [Hyper-V] use systemvm.i...

2015-04-28 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/198 CLOUDSTACK-8418: [Hyper-V] use systemvm.iso from secondary storage use systemvm.iso from secondary storage and stop copying to local disk You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-8422: Fixed unable to delete z...

2015-04-28 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/202 CLOUDSTACK-8422: Fixed unable to delete zone from CCP You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK

[GitHub] cloudstack pull request: CLOUDSTACK-8419: [Hyper-V] corrected the ...

2015-04-28 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/200 CLOUDSTACK-8419: [Hyper-V] corrected the wrong error message in stop command answer corrected the wrong error message in stop command answer You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-8417 : [Hyper-V] Added support...

2015-04-28 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/197 CLOUDSTACK-8417 : [Hyper-V] Added support for smb share path in Hyper-V settings virtual disk path Added support for smb share path in Hyper-V settings virtual disk path You can merge

[GitHub] cloudstack pull request: CLOUDSTACK-8420: [Hyper-V] Fixed number f...

2015-04-28 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/201 CLOUDSTACK-8420: [Hyper-V] Fixed number format exception when untagged vlan is used for Hyper-V setup Change the vlan data type to string from int and handled the untagged vlan cases

[GitHub] cloudstack pull request: CLOUDSTACK-8413: Fixed resource tags on d...

2015-04-27 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/194 CLOUDSTACK-8413: Fixed resource tags on disk are lost when migrate to another storage During cold volume migration we are duplicating volume entry in volumes table. When migration

[GitHub] cloudstack pull request: CLOUDSTACK-8414: [Hyper-V] Fixed template...

2015-04-27 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/195 CLOUDSTACK-8414: [Hyper-V] Fixed template_spool_ref table is not getting updated with correct template size Fixed template_spool_ref table is not getting updated with correct template size

[GitHub] cloudstack pull request: CLOUDSTACK-8416: added support for FIPS c...

2015-04-27 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/196 CLOUDSTACK-8416: added support for FIPS compliant checksum. It will now support md5, sha1, sha224, sha256, sha384 and sha512 checksums. In same checksum parameter user can pass any

[GitHub] cloudstack pull request: CLOUDSTACK-6900: This fixes volume migrat...

2015-01-27 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/68#issuecomment-71788178 Yes. It seems travis CI errored out before running any tests. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-6900: This fixes volume migrat...

2015-01-16 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/68 CLOUDSTACK-6900: This fixes volume migration failing after that volume is downloaded When we download volume then we create entry in volume_store_ref table. We mark the volume entry

[GitHub] cloudstack pull request: CLOUDSTACK-6900: This fixes volume migrat...

2015-01-16 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/68#issuecomment-70239302 If not download_url than there needs to be other entry in db to detect the difference type of entries. But that will require the DB change and will not achieve any

[GitHub] cloudstack pull request: CLOUDSTACK-6900: This fixes volume migrat...

2015-01-16 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/68#issuecomment-70241529 Yes it will always be null for migration entries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-6900: Fixed if we download a v...

2015-01-14 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-6900: Fixed if we download a v...

2015-01-13 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/64 CLOUDSTACK-6900: Fixed if we download a volume and then migrate the same volume, then migration fails In findByStoreVolume method of VolumeDataStoreDao now listing only those volumes whose

[GitHub] cloudstack pull request: CLOUDSTACK-8067: Fixed NPEs in MS log rel...

2014-12-11 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/56 CLOUDSTACK-8067: Fixed NPEs in MS log related to console proxy VM Fixed NPEs in MS log related to console proxy VM You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: CLOUDSTACK-7620: Added SNMP MIB file for ...

2014-11-17 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-7620: Added SNMP MIB file for ...

2014-11-17 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/31#issuecomment-63287776 closing pull request as this got merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

<    1   2   3   4   >