Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38727056
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137664209
LGTM based on the tracking bugs for addressing some of the issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726623
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726468
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726691
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38512226
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2145,14 +2145,10 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38511573
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38511898
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38511940
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38515428
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38512709
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-137004807
What happens in case of an upgrade? Looks like there is a possibility that
the host may get over-provisioned. Should there be some scripts to let the user
know
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38392031
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38391829
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38392290
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38392508
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38401570
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -399,3 +399,14 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38397611
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38399204
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136673890
Anyone? @kishankavala @bhaisaab @remibergsma @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38399931
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2196,6 +2193,11 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38396458
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38397126
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -189,6 +194,21 @@ public LdapUser getUser
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136696233
2 LGTMs merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136680502
@DaanHoogland I ran the following integration test on simulator. Other than
this I don't thick there is any other test for VM HA.
test/integration/smoke
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/767#issuecomment-136940141
May be there is some issue with ACS or github. I also noticed that commits
are not getting closed on merge and @hubot is marking it as merged after
sometime
Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/760
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-136280810
Merging as 2 LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136286725
Changes LGTM for 4.4.
@miguelaferreira @remibergsma These can be fixed properly in a future
release. isVmAlive() can return some enum (like yes, no, unknown
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38302129
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303506
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303769
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303804
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38304057
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38301615
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38301757
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38302004
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38302765
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303216
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -39,6 +39,9 @@
private static final
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303622
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
I am no longer able to start MS after this. I did a clean build followed by
starting MS. Did travis pass for it? Should we revert?
mvn clean install -Dsimulator -DskipTests
mvn -pl client jetty:run -Dsimulator
Getting the following error. No qualifying bean of type
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/629#issuecomment-135660397
LGTM. Looks like travis failures are unrelated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/760
CLOUDSTACK-8785: Proper enforcement of retry count (max.retries) for â¦
â¦all work type handled by HighAvailability manager
Retry count is properly enforced for all work types
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/629#issuecomment-135791640
2 LGTMs, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135391862
Ran the test, LGTM.
test_02_scale_vm_without_hypervisor_specifics
(integration.smoke.test_scale_vm.TestScaleVm) ... === TestName
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135394707
@miguelaferreira Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/743#issuecomment-135395110
Merging as 2 LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/743#issuecomment-135398381
@remibergsma I merged this using the tool but still the merge commit didn't
automatically get the messages. I manually added some of the messages for now
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/743#issuecomment-135400836
Output of the tmp file
$cat .git-tmp-message.txt
Merge pull request #743 from koushik-das/code_cleanup
Removed unused agent command
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/741#discussion_r37955517
--- Diff:
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java
---
@@ -449,12 +450,34 @@ public Answer
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134895552
@miguelaferreira For running tests using simulator follow this
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134933068
Thanks @miguelaferreira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134901921
@miguelaferreira Sure a test can be added. Would you mind creating one and
send out a PR? You can start with the smoke/test_scale_vm.py and tweak it to
run only
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/743#issuecomment-134930046
@bhaisaab I am not sure what was the exact purpose of these agent commands.
I believe these existed even before the code was donated to Apache. But if you
look
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/743
Removed unused agent command AttachVolumeCommand and corresponding anâ¦
â¦swer AttachVolumeAnswer
These types are not used anywhere in the orchestration layer.
You can merge
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/741
Made following fixes in simulator
- Support for ScaleVmCommand/NetworkRulesVmSecondaryIpCommand in resource
layer
- Added support for scaling up a running VM in simulator
- Fixed
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-134491115
@bhaisaab Cherry-picked to 4.5 with commit
3d9cbf0bcb011f4012c94f0df040d9b8ddd325bc
---
If your project is set up for it, you can reply to this email and have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-134173550
@bhaisaab I haven't merged it to 4.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-134164677
@remibergsma I used the script to do the merge. This is how I used it
tools/git/git-pr 698
---
If your project is set up for it, you can reply to this email
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-134467595
@bhaisaab Should I simply cherry-pick to 4.5 branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/725#issuecomment-134038561
@DaanHoogland I have verified using the simulator based on the repro steps
mentioned in the bug. I found some issues in the simulator while testing this
issue
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-134030313
Merging as 2 LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-133369723
@remibergsma https://builds.apache.org is available, maybe
https://builds.apache.org/job/cloudstack-pull-requests/1001/ got removed from
the server
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/725
CLOUDSTACK-8754: VM migration triggered by dynamic scaling is failing
This is caused by serialization failure for VmWorkMigrateForScale object.
Replaced DeployDestination member present
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/725#issuecomment-133451646
@DaanHoogland check the base class
The test cannot catch a new addition to the class which may break
serialization.
Suppose a new non-serializable member
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/725#discussion_r37642249
--- Diff: engine/orchestration/src/com/cloud/vm/VmWorkMigrateForScale.java
---
@@ -18,30 +18,18 @@
import
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-132488846
@kishankavala @DaanHoogland Can any of you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/701
CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistenâ¦
â¦t VR configuration changes
Removed out-of-band VR reboot code
Refer to the discussion on dev
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/701#issuecomment-131741834
@remibergsma @DaanHoogland Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/700#issuecomment-131674848
LGTM. Please squash the commits before merge. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/698
CLOUDSTACK-8733: Host stuck in rebalancing state during agent LB
This is happening as ClusterServiceServletAdapter is started after
ClusteredAgentManagerImpl.
Fix is to start
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/694#issuecomment-131040736
@remibergsma In the middle of another thing, can help with it possibly by
next week. Let me know if that is ok? Basically all code in
postStateTransitionEvent
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/694#issuecomment-131031819
@remibergsma As per discussion in dev list, based on the persistent VR
changes, reboot/alert is no longer required in case of out of band VR
migration. So
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/679#discussion_r36958780
--- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java
---
@@ -125,6 +130,16 @@ public SecurityGroupResponse
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130602430
@borisroman I have provided a code comment. Once you fix that and squash
the commits as suggested by @remibergsma then its a LGTM from me. Thanks for
the unit
Please send out a PR with the fix.
-Original Message-
From: Rajani Karuturi [mailto:raj...@apache.org]
Sent: Wednesday, 12 August 2015 12:02
To: dev@cloudstack.apache.org
Subject: Re: [Low Priority] Resource method names
:)
~Rajani
On Wed, Aug 12, 2015 at 5:11 AM, Mike Tutkowski
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/681#issuecomment-130167859
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/679#discussion_r36827811
--- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java
---
@@ -125,6 +130,14 @@ public SecurityGroupResponse
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130175830
Please add tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Congrats Remi!
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Monday, 10 August 2015 22:39
To: dev
Subject: Remi Bergsma joins the PMC
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129371706
@remibergsma Yes the commits can be squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/662#issuecomment-129323691
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129335984
@remibergsma I have fixed the commits, please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129300344
@remibergsma Thanks for testing the PR. This is a best-effort fix. The
change just schedules the restart of the system VMs ahead of the user VMs. Now
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/666#discussion_r36527589
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -2627,7 +2627,7 @@ public boolean
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/666#discussion_r36526622
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -2627,7 +2627,7 @@ public boolean
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128745820
@remibergsma Will the following work?
- do git pull on master
- then do a git pull --rebase, this will make the commits appear on top
- then do
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128686334
@kishankavala Made the change to use VM type instead of name to distinguish
between user and system VMs
---
If your project is set up for it, you can reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128342511
Changes LGTM. Make sure travis is green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36382437
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -242,16 +242,19 @@ public void scheduleRestartForVmsOnHost(final HostVO
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/656
CLOUDSTACK-8704: Schedule restart of router VMs ahead of user VMs as â¦
â¦part of HA
VRs are scheduled for HA ahead of user VMs.
Refer to the bug for more details.
You
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36170828
--- Diff: server/test/com/cloud/ha/HighAvailabilityManagerImplTest.java ---
@@ -113,12 +110,18 @@
public void setup() throws
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/648#discussion_r36170620
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -1354,6 +1354,10 @@ public boolean
updateTemplateOrIsoPermissions
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36166742
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/SnapshotDescriptor.java ---
@@ -166,12 +168,7 @@ public void removeDiskReferenceFromSnapshot
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/653#issuecomment-127532378
Changes LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36166324
--- Diff: utils/src/com/cloud/utils/AutoCloseableUtil.java ---
@@ -0,0 +1,20 @@
+package com.cloud.utils;
--- End diff --
License
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36168376
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -261,25 +264,21 @@ public void scheduleRestartForVmsOnHost(final HostVO
If there is a group of users in dire need for a specific feature they can
always take the code and use it. No need to wait for an official release.
Official release should adhere to quality guidelines (at least in terms of any
reported regressions) even if it means release getting delayed.
On
Currently we are putting in effort to make sure no commit goes in directly
without a PR. Based on that, I think it makes sense to treat any reported
regression bug as a release blocker. If the bug is reported after release then
it is a different issue and needs to be fixed in the subsequent
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126260440
@DaanHoogland Merge this in 4.6. If possible push the log level changes in
4.6 as well.
---
If your project is set up for it, you can reply to this email
401 - 500 of 872 matches
Mail list logo
