Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1606
What's the current status of this PR? Is this acceptable as is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1954
LGTM ... this in combination with #1915 resolves our issues with logging in
the VR under rapid vm creation and destruction.
---
If your project is set up for it, you can reply to this email
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1915
We always want `compress` ... but the only time you need or want
`delaycompress` is if you can't be sure that the program writing to the log can
be successfully told to stop appending
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1915
We are seeing issues under heavy user interaction cycles with redundant
VRs. In testing you can reliably completely fill the `/var/log/` partition
with data primarily from `cloud.log` when
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou Nathan's work can be found in the `vm-snapshot` branch of our
fork here: https://github.com/myENA/cloudstack/commits/vm-snapshot
---
If your project is set up for it, you can
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1606
@jburwell Is there already an existing test for the previous behavior that
could be modified? I haven't had a chance to do much with Marvin other than
briefly browse the tests folder
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1608
Tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user leprechau closed the pull request at:
https://github.com/apache/cloudstack/pull/1608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user leprechau reopened a pull request:
https://github.com/apache/cloudstack/pull/1608
Cleanup RBD contexts after exceptions to prevent potential agent crash
We noticed that when an exception occurs within the cleanup loop inside
the deletePhysicalDisk routine
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1608
Absolutely, I'll add a bit more to the logging when I get into the office.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user leprechau closed the pull request at:
https://github.com/apache/cloudstack/pull/1608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user leprechau reopened a pull request:
https://github.com/apache/cloudstack/pull/1608
Cleanup RBD contexts after exceptions to prevent potential agent crash
We noticed that when an exception occurs within the cleanup loop inside
the deletePhysicalDisk routine
GitHub user leprechau opened a pull request:
https://github.com/apache/cloudstack/pull/1608
Upstream/context cleanup
We noticed that when an exception occurs within the cleanup loop inside
the deletePhysicalDisk routine that the previously allocated contexts
are not cleaned
GitHub user leprechau opened a pull request:
https://github.com/apache/cloudstack/pull/1606
Allow CGN (RFC6598) to be used within a VPC
Add the CGN network to the list of allowed netblocks for guest networks.
Additionally convert the previous strings to a list to allow easier
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@kishankavala Understood, thank you for the explanation. The long history
of the project makes digging into some of these things difficult.
---
If your project is set up for it, you can
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1581
Looking through the ```git blame``` for this section of code it appears the
operator and the ordering of the list was the same as this patch prior to 2013
when the operator was switched
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1581
Looks clean and the added test case should prevent this from happening
again. According to the "git blame" the comparator was switched back in 2013
and has been broken since.
-
17 matches
Mail list logo
