[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...

2015-07-28 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/626#discussion_r35639533 --- Diff: debian/rules --- @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven

[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...

2015-07-28 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/626#discussion_r35627314 --- Diff: debian/rules --- @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-07-16 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-121889370 Hi @wido I've been waiting for feedback from Pyr on a thread in the dev mailing list with subject "4.6" if you want to look it up. I will

[GitHub] cloudstack pull request: Cleanup stale files in /tmp which is fill...

2015-06-25 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/531 Cleanup stale files in /tmp which is filling up during some runs Output status of disk and memory on build host for some extra info on build environment before start This should fix

[GitHub] cloudstack pull request: Reduce script running time around 80%

2015-06-25 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/530#issuecomment-115413290 @bhaisaab not that w00ty.. its just on the downloadDeps.sh script.. its seems to be reducing 100/200 secs, this delay was introduced by the fix script itself

[GitHub] cloudstack pull request: Reduce script running time around 80%

2015-06-25 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/530#issuecomment-115384919 It seems the performance impact was much bigger from my network than from Travis' Still reduces run times a bit though :) --- If your project is set u

[GitHub] cloudstack pull request: Reduce script running time around 80%

2015-06-25 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/530 Reduce script running time around 80% This resolves the performance penalty introduced by adding the midonet repo downloadDeps.sh is taking around 9/10 mins to run on travis, this should

[GitHub] cloudstack pull request: Add git status output to debug git fetch ...

2015-06-24 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/523 Add git status output to debug git fetch failures The purpose of this is to visualize the git status output after git fetch, to identify possible problems that are stalling the build. On

[GitHub] cloudstack pull request: Extend wait before retry to states other ...

2015-06-23 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/514 Extend wait before retry to states other than 'Starting' https://github.com/apache/cloudstack/pull/493 implemented wait and retry for SSVM state trying, but today there was as an

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/497#issuecomment-114054951 @karuturi done in a nicer way, as requested :) FYI, the only thing that is needed to actually fix the ovm3 problem is the changes to plugins/hypervisors/ovm3

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/497#discussion_r32917874 --- Diff: plugins/hypervisors/ovm3/pom.xml --- @@ -27,11 +27,31 @@ ../../pom.xml - -org.apache.xmlrpc

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/497#discussion_r32917814 --- Diff: plugins/hypervisors/ovm3/pom.xml --- @@ -27,11 +27,31 @@ ../../pom.xml - -org.apache.xmlrpc

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/497#discussion_r32917853 --- Diff: plugins/hypervisors/ovm3/pom.xml --- @@ -27,11 +27,31 @@ ../../pom.xml - -org.apache.xmlrpc

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/497#discussion_r32917768 --- Diff: plugins/hypervisors/ovm3/pom.xml --- @@ -27,11 +27,31 @@ ../../pom.xml - -org.apache.xmlrpc

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/497#discussion_r32917802 --- Diff: plugins/hypervisors/ovm3/pom.xml --- @@ -27,11 +27,31 @@ ../../pom.xml - -org.apache.xmlrpc

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/505 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in Upgrade410to420.java You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/504 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorUtil… ….java You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/503 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorPrim… …aryDataStoreLifeCycle.java You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/502 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/501 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.… …java You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix 2 more findbugs DM_BOXED_PRIMITIVE_FO...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/500 Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.… …java You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix 2 findbugs occurences of DM_BOXED_PRI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/499 Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrad… …e218to22.java You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/498 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in DeployVMCmd.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/497#issuecomment-113956319 @bhaisaab you can go ahead and merge now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/497#issuecomment-113955383 Victory! One of the problem nodes just compiled it successfully and ran until the end without problems Will now get started on cleaning up the PR and just

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/497#issuecomment-113937925 Just as i said travis was stable, got a lot of failures haha :) Upon looking into it, travis didn't fail, it is correctly reporting that i killed ovm3 lo

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/497#issuecomment-113935738 Hi Rohit, Sorry for spamming you guys so hard this weekend eheh :) I've found the problem, but it's still not properly fixed. Cause seems to

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/497 Attempt to resolve ovm3 jenkins failure Resolve unsafe cast warnings reported by lint checker Add some debug config to compiler plugin You can merge this pull request into a Git

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-20 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113852244 I'd say this now downloads around 99% of project dependencies before build starts Mostly just maven-remote-resources-plugin stuff is still downloaded,

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113644292 It seems latest fix uncovered tests that were failing but actually reporting success! --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113614309 Ever since i first saw this failure I wondered... why is this considered a success?!? === TestName: test_02_sys_template_ready | Status : EXCEPTION

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113610266 Mentioned issue fixed in https://github.com/apache/cloudstack/pull/493/ :D --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Allow some time for the SSVM to start bef...

2015-06-19 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/493 Allow some time for the SSVM to start before throwing a failure This fixes the old issue with intermittently failing marvin test on travis Example output: Marvin Init

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113585258 It seems like this test sometimes fails because the SSVM takes a while to startup.. the test/integration/smoke/test_secondary_storage.py:159 asserts that

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113577142 Perfect, last travis failure was just what i was referring to in the last comment, after_failure.sh printed full marvin logs, we can properly troubleshoot that

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113532978 @DaanHoogland LGTM, altough travis has been very stable today :) Lastest commit is also useful, since the after_failure.sh script was doing nothing at all

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113487647 7 successes in a row is looking better :) Will do a couple more minor changes to force some more runs.. will rebase at the end when it feels like travis is

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-18 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113321916 Travis is still not looking very well :( will resume soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-18 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/482#issuecomment-113284857 Travis failure on 2c0d07e was due to second phase not running after i moved the script to tools/travis xerxesImpl is downloaded on that phase Issue is

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-18 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/482 This is a quick fix to attempt to resolve most of the travis failures Most of the failures have been due to transient network failures, that are causing dependency artifact downloads to fail

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/476#discussion_r32715161 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-18 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/477#issuecomment-113097972 Was already asleep by the time travis finished running hehe... removed trailing space, waiting for travis again :) --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/478 Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRI… …NG warnings in DatabaseConfig.java You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/473#discussion_r32663864 --- Diff: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java --- @@ -645,8 +643,9 @@ public boolean remove(Long id

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/477 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in ConfigurationServerImpl.java You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/476 Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRI… …NG warnings in ConfigurationManagerImpl.java You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/475 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in AsyncJobDaoImpl.java You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/474 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in PrimaryDataStoreDaoImpl.java You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/473 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in UserVmDaoImpl.java detail field was vulnerable You can merge this pull request into a Git

[GitHub] cloudstack pull request: findbugs: deal with all the encoding issu...

2015-06-17 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/467#discussion_r32618952 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java --- @@ -1094,13 +1092,6 @@ private String

[GitHub] cloudstack pull request: findbugs: deal with all the encoding issu...

2015-06-17 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/467#discussion_r32617957 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java --- @@ -1094,13 +1092,6 @@ private String

[GitHub] cloudstack pull request: findbugs: deal with all the encoding issu...

2015-06-17 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/467#discussion_r32617440 --- Diff: utils/src/com/cloud/utils/StringUtils.java --- @@ -32,6 +33,21 @@ public class StringUtils { private static final char

[GitHub] cloudstack pull request: Catch encoding exception

2015-06-16 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/464#discussion_r32506889 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -2265,7 +2265,11 @@ public Answer forgetObject

[GitHub] cloudstack pull request: Catch encoding exception

2015-06-16 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/464#discussion_r32506402 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -2265,7 +2265,11 @@ public Answer forgetObject

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-16 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/460#issuecomment-112344047 @DaanHoogland done! https://github.com/apache/cloudstack/pull/464 I should have checked travis for this one, still my bad :( --- If your project is set

[GitHub] cloudstack pull request: Catch encoding exception

2015-06-16 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/464 Catch encoding exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs75 Alternatively you can review

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-16 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/460#issuecomment-112338005 my bad there.. will surround in try/catch block and update --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-15 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/460#issuecomment-112232241 Here's an example of an instance where i also removed a Charset.defaultCharset() that was placed in the reading of a socket, where cloudstack controls both

[GitHub] cloudstack pull request: Fix findbugs warning in VmwareStorageMana...

2015-06-15 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/461#discussion_r32472910 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java --- @@ -256,7 +256,7 @@ public Answer

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareReso...

2015-06-15 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/462#discussion_r32472663 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -705,7 +705,7 @@ public ExecutionResult

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-15 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/460#discussion_r32469324 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -2265,7 +2265,7 @@ public Answer forgetObject

[GitHub] cloudstack pull request: Fix css syntax error in cloudstack3.css

2015-06-15 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/463 Fix css syntax error in cloudstack3.css Just a simple syntax fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareReso...

2015-06-15 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/462 Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix findbugs warning in VmwareStorageMana...

2015-06-15 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/461 Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency You can merge this pull re

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-15 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/460 Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency You can merge this

[GitHub] cloudstack pull request: update of the findbugs lib

2015-06-15 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/459#issuecomment-112091994 Let's see what new issues all those new patterns will uncover ;) --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_F...

2015-06-15 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/457#issuecomment-112080925 @DaanHoogland it's a fluke, sry :) Must have typed "wq1" instead of "wq!" on vi ... fixed and rebased --- If your project is set up

[GitHub] cloudstack pull request: Fix 4 findbugs warnings in JuniperSrxReso...

2015-06-15 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/399#issuecomment-111994620 perhaps due to other changes in base file? I've rebased with current master, can you retry @bhaisaab ? :) --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_F...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/457 Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in B… …aseCmd.java Dateformat objects are not thread safe. Instance field is highly recommended for these You

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/456 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressMan… …agerImpl.java Assert isn't used in prod runtime You can merge this pull request into a Git reposito

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/455 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVO… ….java Assert isn't used in prod runtime You can merge this pull request into a Git repository by ru

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/454 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderI… …mpl.java Assert isn't used in prod runtime You can merge this pull request into a Git reposito

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/453 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManager… …Impl.java Assert isn't used in prod runtime You can merge this pull request into a Git reposito

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/452 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOffer… …ingVO.java Assert isn't used in prod runtime You can merge this pull request into a Git reposito

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/451 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java Assert isn't used in prod runtime You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/450 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVO… ….java Assert isn't used in prod runtime You can merge this pull request into a Git repository by ru

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/449 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrche… …strator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/448 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVO… ….java Assert isn't used in prod runtime, null is checked in method You can merge this pull request i

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/447 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCe… …nterVO.java Assert isn't used in prod runtime, null is checked in method You can merge this pull re

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/446 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDis… …patcher.java Assert isn't used in prod runtime, null is properly checked in method You can merge

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/445 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachi… …neManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/444 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManager… …Impl.java Assert isn't used in runtime, null is properly checked in method You can merge this

[GitHub] cloudstack pull request: Fix 3 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/443 Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRI… …NG warnings in Upgrade410to420.java There was no risk of sql injection here, nor any need to use

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/442 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in Upgrade30xBase.java There was no risk of sql injection here, nor any need to use

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/441 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in Upgrade2214to30.java There was no risk of sql injection here, nor any need to use

[GitHub] cloudstack pull request: Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCU...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/440 Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in NetworkService… …Impl.java You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix findbugs warning HE_EQUALS_USE_HASHCO...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/439 Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java When overriding equals(), hashCode() must also be overriden do comply with the directive that equal objects must have equal

[GitHub] cloudstack pull request: Fix 2 findbugs warnings in ApiResponseHel...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/438 Fix 2 findbugs warnings in ApiResponseHelper.java ints were being boxed just to call .toString() You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fix findbugs warning in NetworkServiceImp...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/437 Fix findbugs warning in NetworkServiceImpl.java Integer was being boxed just to call toString() You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fix findbugs warning in Script.java

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/436 Fix findbugs warning in Script.java Unnecessary boxing/unboxing of int value You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca

[GitHub] cloudstack pull request: Fix findbugs warning in NetUtils.java

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/435 Fix findbugs warning in NetUtils.java Unnecessary boxing/unboxing of primitive value You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix findbugs warning in ProjectManagerImp...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/434 Fix findbugs warning in ProjectManagerImpl.java Unnecessary boxing/unboxing of primitive value You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fix findbugs warning in NetworkUsageManag...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/433 Fix findbugs warning in NetworkUsageManagerImpl.java Unnecessary boxing/unboxing of long value to create Date You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: Fix 2 findbugs warnings in NetworkService...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/432 Fix 2 findbugs warnings in NetworkServiceImpl.java Unnecessary boxing/unboxing of int values You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fix findbugs warning in CloudZonesStartup...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/431 Fix findbugs warning in CloudZonesStartupProcessor.java Unnecessary boxing/unboxing of primitive value You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fix findbugs warning in ApiDispatcher.jav...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/430 Fix findbugs warning in ApiDispatcher.java Unnecessary boxing/unboxing of long value You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix 2 findbugs warnings in ElastistorUtil...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/429 Fix 2 findbugs warnings in ElastistorUtil.java Unnecessary boxing/unboxing of long value You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Fix findbugs warning in ElastistorPrimary...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/428 Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java Unnecessary boxing/unboxing of primitive value You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: Fix findbugs warning in PaloAltoResource....

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/427 Fix findbugs warning in PaloAltoResource.java Unnecessary boxing/unboxing of primitive value You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fix findbugs warning in NetscalerResource...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/426 Fix findbugs warning in NetscalerResource.java Unnecessary boxing/unboxing of primitive value You can merge this pull request into a Git repository by running: $ git pull https

  1   2   3   >