Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/626#discussion_r35639533
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn
org.apache.maven.plugins:maven
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/626#discussion_r35627314
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn
org.apache.maven.plugins:maven
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/372#issuecomment-121889370
Hi @wido
I've been waiting for feedback from Pyr on a thread in the dev mailing list
with subject "4.6" if you want to look it up.
I will
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/531
Cleanup stale files in /tmp which is filling up during some runs
Output status of disk and memory on build host for some extra info on build
environment before start
This should fix
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/530#issuecomment-115413290
@bhaisaab not that w00ty.. its just on the downloadDeps.sh script.. its
seems to be reducing 100/200 secs, this delay was introduced by the fix script
itself
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/530#issuecomment-115384919
It seems the performance impact was much bigger from my network than from
Travis'
Still reduces run times a bit though :)
---
If your project is set u
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/530
Reduce script running time around 80%
This resolves the performance penalty introduced by adding the midonet repo
downloadDeps.sh is taking around 9/10 mins to run on travis, this should
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/523
Add git status output to debug git fetch failures
The purpose of this is to visualize the git status output after git fetch,
to identify possible problems that are stalling the build.
On
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/514
Extend wait before retry to states other than 'Starting'
https://github.com/apache/cloudstack/pull/493 implemented wait and retry
for SSVM state trying, but today there was as an
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-114054951
@karuturi done in a nicer way, as requested :)
FYI, the only thing that is needed to actually fix the ovm3 problem is the
changes to
plugins/hypervisors/ovm3
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917874
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
../../pom.xml
-
-org.apache.xmlrpc
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917814
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
../../pom.xml
-
-org.apache.xmlrpc
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917853
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
../../pom.xml
-
-org.apache.xmlrpc
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917768
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
../../pom.xml
-
-org.apache.xmlrpc
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917802
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
../../pom.xml
-
-org.apache.xmlrpc
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/505
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in Upgrade410to420.java
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/504
Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorUtilâ¦
â¦.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/503
Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorPrimâ¦
â¦aryDataStoreLifeCycle.java
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/502
Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/501
Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.â¦
â¦java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/500
Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.â¦
â¦java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/499
Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in Upgradâ¦
â¦e218to22.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/498
Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in DeployVMCmd.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113956319
@bhaisaab you can go ahead and merge now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113955383
Victory!
One of the problem nodes just compiled it successfully and ran until the
end without problems
Will now get started on cleaning up the PR and just
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113937925
Just as i said travis was stable, got a lot of failures haha :)
Upon looking into it, travis didn't fail, it is correctly reporting that i
killed ovm3 lo
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113935738
Hi Rohit,
Sorry for spamming you guys so hard this weekend eheh :)
I've found the problem, but it's still not properly fixed. Cause seems to
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/497
Attempt to resolve ovm3 jenkins failure
Resolve unsafe cast warnings reported by lint checker
Add some debug config to compiler plugin
You can merge this pull request into a Git
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113852244
I'd say this now downloads around 99% of project dependencies before build
starts
Mostly just maven-remote-resources-plugin stuff is still downloaded,
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113644292
It seems latest fix uncovered tests that were failing but actually
reporting success!
---
If your project is set up for it, you can reply to this email and have
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113614309
Ever since i first saw this failure I wondered... why is this considered a
success?!?
=== TestName: test_02_sys_template_ready | Status : EXCEPTION
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113610266
Mentioned issue fixed in https://github.com/apache/cloudstack/pull/493/
:D
---
If your project is set up for it, you can reply to this email and have your
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/493
Allow some time for the SSVM to start before throwing a failure
This fixes the old issue with intermittently failing marvin test on travis
Example output:
Marvin Init
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113585258
It seems like this test sometimes fails because the SSVM takes a while to
startup.. the test/integration/smoke/test_secondary_storage.py:159 asserts that
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113577142
Perfect, last travis failure was just what i was referring to in the last
comment, after_failure.sh printed full marvin logs, we can properly
troubleshoot that
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113532978
@DaanHoogland LGTM, altough travis has been very stable today :)
Lastest commit is also useful, since the after_failure.sh script was doing
nothing at all
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113487647
7 successes in a row is looking better :)
Will do a couple more minor changes to force some more runs.. will rebase
at the end when it feels like travis is
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113321916
Travis is still not looking very well :( will resume soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113284857
Travis failure on 2c0d07e was due to second phase not running after i moved
the script to tools/travis
xerxesImpl is downloaded on that phase
Issue is
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/482
This is a quick fix to attempt to resolve most of the travis failures
Most of the failures have been due to transient network failures, that are
causing dependency artifact downloads to fail
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/476#discussion_r32715161
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/477#issuecomment-113097972
Was already asleep by the time travis finished running hehe... removed
trailing space, waiting for travis again :)
---
If your project is set up for it, you can
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/478
Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦
â¦NG warnings in DatabaseConfig.java
You can merge this pull request into a Git repository by running:
$ git
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/473#discussion_r32663864
--- Diff: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java ---
@@ -645,8 +643,9 @@ public boolean remove(Long id
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/477
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in ConfigurationServerImpl.java
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/476
Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦
â¦NG warnings in ConfigurationManagerImpl.java
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/475
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in AsyncJobDaoImpl.java
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/474
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in PrimaryDataStoreDaoImpl.java
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/473
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in UserVmDaoImpl.java
detail field was vulnerable
You can merge this pull request into a Git
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32618952
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1094,13 +1092,6 @@ private String
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32617957
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1094,13 +1092,6 @@ private String
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32617440
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -32,6 +33,21 @@
public class StringUtils {
private static final char
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/464#discussion_r32506889
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,11 @@ public Answer forgetObject
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/464#discussion_r32506402
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,11 @@ public Answer forgetObject
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112344047
@DaanHoogland done!
https://github.com/apache/cloudstack/pull/464
I should have checked travis for this one, still my bad :(
---
If your project is set
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/464
Catch encoding exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack findbugs75
Alternatively you can review
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112338005
my bad there.. will surround in try/catch block and update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112232241
Here's an example of an instance where i also removed a
Charset.defaultCharset() that was placed in the reading of a socket, where
cloudstack controls both
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/461#discussion_r32472910
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -256,7 +256,7 @@ public Answer
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/462#discussion_r32472663
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -705,7 +705,7 @@ public ExecutionResult
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/460#discussion_r32469324
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,7 @@ public Answer forgetObject
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/463
Fix css syntax error in cloudstack3.css
Just a simple syntax fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/462
Fix findbugs encoding issue in VmwareResource.java
Key file should be UTF-8 encoded in VR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/461
Fix findbugs warning in VmwareStorageManagerImpl.java
Any encoding would do fine as it's just used to generate a UUID. Sticking
with UTF-8 for consistency
You can merge this pull re
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/460
Fix findbugs encoding issue in VmwareStorageProcessor.java
Any encoding would do fine as it's just used to generate a UUID. Sticking
with UTF-8 for consistency
You can merge this
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/459#issuecomment-112091994
Let's see what new issues all those new patterns will uncover ;)
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/457#issuecomment-112080925
@DaanHoogland it's a fluke, sry :)
Must have typed "wq1" instead of "wq!" on vi ... fixed and rebased
---
If your project is set up
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/399#issuecomment-111994620
perhaps due to other changes in base file? I've rebased with current
master, can you retry @bhaisaab ? :)
---
If your project is set up for it, you can rep
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/457
Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in Bâ¦
â¦aseCmd.java
Dateformat objects are not thread safe. Instance field is highly
recommended for these
You
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/456
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressManâ¦
â¦agerImpl.java
Assert isn't used in prod runtime
You can merge this pull request into a Git reposito
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/455
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVOâ¦
â¦.java
Assert isn't used in prod runtime
You can merge this pull request into a Git repository by ru
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/454
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderIâ¦
â¦mpl.java
Assert isn't used in prod runtime
You can merge this pull request into a Git reposito
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/453
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerâ¦
â¦Impl.java
Assert isn't used in prod runtime
You can merge this pull request into a Git reposito
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/452
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOfferâ¦
â¦ingVO.java
Assert isn't used in prod runtime
You can merge this pull request into a Git reposito
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/451
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java
Assert isn't used in prod runtime
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/450
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVOâ¦
â¦.java
Assert isn't used in prod runtime
You can merge this pull request into a Git repository by ru
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/449
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrcheâ¦
â¦strator.java
If answer is null, method will throw ConnectionException in line 3016 as
satisfied by
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/448
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVOâ¦
â¦.java
Assert isn't used in prod runtime, null is checked in method
You can merge this pull request i
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/447
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCeâ¦
â¦nterVO.java
Assert isn't used in prod runtime, null is checked in method
You can merge this pull re
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/446
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDisâ¦
â¦patcher.java
Assert isn't used in prod runtime, null is properly checked in method
You can merge
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/445
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachiâ¦
â¦neManagerImpl.java
Removed two unnecessary null checks as this piece of code will only run if
answer is
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/444
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerâ¦
â¦Impl.java
Assert isn't used in runtime, null is properly checked in method
You can merge this
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/443
Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦
â¦NG warnings in Upgrade410to420.java
There was no risk of sql injection here, nor any need to use
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/442
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in Upgrade30xBase.java
There was no risk of sql injection here, nor any need to use
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/441
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in Upgrade2214to30.java
There was no risk of sql injection here, nor any need to use
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/440
Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in NetworkServiceâ¦
â¦Impl.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/439
Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java
When overriding equals(), hashCode() must also be overriden do comply with
the directive that equal objects must have equal
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/438
Fix 2 findbugs warnings in ApiResponseHelper.java
ints were being boxed just to call .toString()
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/437
Fix findbugs warning in NetworkServiceImpl.java
Integer was being boxed just to call toString()
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/436
Fix findbugs warning in Script.java
Unnecessary boxing/unboxing of int value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/435
Fix findbugs warning in NetUtils.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/434
Fix findbugs warning in ProjectManagerImpl.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/433
Fix findbugs warning in NetworkUsageManagerImpl.java
Unnecessary boxing/unboxing of long value to create Date
You can merge this pull request into a Git repository by running:
$ git
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/432
Fix 2 findbugs warnings in NetworkServiceImpl.java
Unnecessary boxing/unboxing of int values
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/431
Fix findbugs warning in CloudZonesStartupProcessor.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/430
Fix findbugs warning in ApiDispatcher.java
Unnecessary boxing/unboxing of long value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/429
Fix 2 findbugs warnings in ElastistorUtil.java
Unnecessary boxing/unboxing of long value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/428
Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/427
Fix findbugs warning in PaloAltoResource.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/426
Fix findbugs warning in NetscalerResource.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https
1 - 100 of 236 matches
Mail list logo