Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon Jenkins and CI is passed, Can you please give LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
Jenkins got timed out. I am force pushing again to trigger jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1908
Looks good now. Not sure what's up with Jenkins though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1908
### ACS CI BVT Run
**Sumarry:**
Build Number 3
Hypervisor xenserver
NetworkType Advanced
Passed=623
Failed=290
Skipped=58
_Link to logs Folder
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@jayapalu can you change the PR base branch to 4.9?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon Can you please review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1908
Hi, that's great news.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon
I have today this PR after rebasing latest master. I did not observe the
add:true for the removed ip.
Here is output from the ips.json and ip addr show output.
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon The ip issue can be worked as separate ticket/PR. It is an
isolated issue, it is not having any dependency with this PR. So we will get
this PR in and create a separate ticket
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@jayapalu Quite possible, yes. It could be fixed by adding another
condition to the check that was added with #1907. It could also be "fixed" by
checkiing if `configured()` returns `True`
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon
I have seen the issue of ips.json having the "add:true" while I am testing
this PR. I tested this PR by manually removing the ip or setting add to false.
Also I tested with
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1908
We have been testing this PR internally for some time now, and we have seen
some strange `arping` issues. We have seen that `/etc/cloudstack/ips.json` on
the router has IPs on them that
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1908
I'm looking at the `DataBag` code, and it seems that it loads information
from the data located at `/etc/cloudstack/` and therefore 1907 should work fine
with this, ASSUMING that is smart
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1908
Question: would #1907 be relevant to this? That change relied on sending
all the IPs to the router, but under this change, we will be sending one at a
time.
---
If your project is set up
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1908
Thanks for adding the missing parts. Here is the PR that was open against
4.8 for this, which I guess can be closed now:
https://github.com/apache/cloudstack/pull/1623
I guess the
15 matches
Mail list logo
