Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-121829768
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-120846548
@runseb Sorry for delayed response, I was away for two weeks.
As said by Sanjeev, the tests were wrongly tagged. required_hardware =
"true" implies test can
if required_hardware=false means these tests can run on Simulator.
On Thu, Jul 2, 2015 at 3:06 PM, runseb wrote:
> Github user runseb commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/532#issuecomment-117977659
>
> @gauravaradhye if you answer my questions I ca
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-117977659
@gauravaradhye if you answer my questions I can give a LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-116534604
these tests used to be required_hardware=true, and now it's false. So when
are we running these tests ? Are they included in Travis runs, in which case we
are loosing
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-116523709
Need a second LGTM, anyone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-115609404
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/532#discussion_r8559
--- Diff: test/integration/component/test_ps_domain_limits.py ---
@@ -194,7 +194,7 @@ def setupAccounts(self):
return [FAIL, e, None
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/532#discussion_r8448
--- Diff: test/integration/component/test_ps_domain_limits.py ---
@@ -194,7 +194,7 @@ def setupAccounts(self):
return [FAIL, e, None]
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/532
CLOUDSTACK-8582: Skipping unsuitable test cases for simulator
Modifying tags for test cases which shouldn't be run on simulator (Test
cases requiring download of templates/ISOs and creatio
11 matches
Mail list logo
