Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-132091017
The PR #709 don't fix the issue for me. I can't add a SSH key pair without
revert the #615.
---
If your project is set up for it, you can reply to this
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-132097141
Sorry, I clean up my browser cache, now works with the #709 fix. Thanks
@borisroman
---
If your project is set up for it, you can reply to this email and
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-131911894
I wouldn't revert the commit either, we can probably fix this in the UI.
@borisroman could you look at this maybe with @kevindierkx ?
---
If your project is
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-131899397
Seems this PR breaks the addition of a public key on the Web UI.
The reponse is : Public key is invalid
(works successfully with Cloudmonkey
Not sure if that warrants a revert. It seems like something that should be
fixed in the UI
On Mon, Aug 17, 2015 at 7:34 PM, milamberspace g...@git.apache.org wrote:
Github user milamberspace commented on the pull request:
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-131960910
Looked into it. See PR #709
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123995367
ok.I thought thought this commit removed decoding and the api now expects a
decoded value as input.
I understand now. the issue is with double decoding we
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123991576
Hi @karuturi
I merged just 1min before your comment.
What change do you mean? The one @borisroman is trying to fix?
Please, see my
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/615
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123990422
encoding is done from javascript
https://github.com/apache/cloudstack/blob/master/ui/scripts/accounts.js#L1816
I think we should either update the apidoc to
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123990021
Okay, we got a LGTM from @kishankavala and 1 from me.
The parameters are being decoded in the
ApiServlet.processRequestInContext() method.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-124038730
@kishankavala the double encoding was already in before that commit
(968e71a). This commit refactered some code out of the method in which the
encoding
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123766531
Hi guys,
1. RegisterSSHKeyPairCmd.getPublicKey() doesn't do a decoding of the key.
That's just a simple getter method.
2. However, I don't think
Github user teulaert commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123818145
@wilderrodrigues reproducing is really easy, just try to register your
public key using the registerSSHKeyPair API call. In the database you will find
you key, but
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/614
CLOUDSTACK-8649: Fixed unnecessary double url decoding in
registerSSHKeyPair.
The method cmd.getPublicKey() already returns a decoded string. So when we
try to decode it again the plus +
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/614#issuecomment-123650029
Hi @borisroman ,
Should this go into 4.5 first? If so, why?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/614
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/615
CLOUDSTACK-8649: Fixed unnecessary double url decoding in
registerSSHKeyPair.
The method cmd.getPublicKey() already returns a decoded string. So when we
try to decode it again the plus +
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123863689
Hi Lennert,
The Command claases use annotations for the fields. The fields values are
set via reflection. I bet my iPhone the decoding is being done
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123699898
@DaanHoogland double URL decoding was added during registerSSHKeyPair
refactor. commit 968e71ad0e49088b5f2f022df29aec02b10a5ede
Can you please check if this
20 matches
Mail list logo
