Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-129423682
WRT master/4.6 4.5.2 was assumed frozen. There are other changes in
452to462 sql as well which may/maynot be bug fixes.
A separate PR needs to be done for 451to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128373260
Looks like some confusion is going on here; the changes need to go into:
setup/db/db/schema-451to452.sql that I had suggested earlier. If you do that,
then people w
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/657
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128337719
I will merge this to master and keep the bug open so that it can be fixed
in 4.5.2
---
If your project is set up for it, you can reply to this email and have your
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128306138
LGTM if 4.5.2 is released before 4.6.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128293895
I read it as this PR is good for master. If thats the case, can I get some
+1s please.
---
If your project is set up for it, you can reply to this email and have y
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128230517
Yes please move the necessary code to schema-451to452.sql on 4.5 branch;
we'll merge the same change on master as well
---
If your project is set up for it, you ca
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128227678
@remibergsma
Agreed. In this case fix will go into 4.5.2 and 4.6
Updated fixVersion accordingly
---
If your project is set up for it, you can reply to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128128323
@kishankavala Released versions will never be changed, only their ongoing
release branches, like the '4.5' branch. So, we won't touch 4.5.0 and 4.5.1.
What goes
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128126924
@DaanHoogland @karuturi @bhaisaab Yes, let's do 4.5.2 first and then all
focus on 4.6.0
---
If your project is set up for it, you can reply to this email and ha
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128023315
@DaanHoogland yes, there was a discussion with @remibergsma and @karuturi
on slack; I'll start something next week
---
If your project is set up for it, you can re
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-127916051
@bhaisaab If we do that we do commit ourselves to releasing 4.5.2 before
4.6.0 don't we?
---
If your project is set up for it, you can reply to this email and
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-127899688
@karuturi can you move this to 451to452 schema and then merge on both
4.5/master which will fix the issue for both future releases 4.5.2 and 4.6.0?
---
If your pro
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-127560212
@karuturi This issue exists in releases > 4.5.0
Shouldn't this be fixed in 4.5.0, 4.5.1 and merged forward as per the new
release process?
Or is the new
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-127555462
@karuturi @bhaisaab this must be fixed *before* 4.5.2 so it shouldn't be in
the 452to460 file. If we put it there we are saying the bug will be in an
unreleased
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-127548502
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/657
CLOUDSTACK-8696: Create Region fails with exception
'id' in the region table should not be an autoincrement unlike other
tables. This is because, region ids must be in sync across installs a
17 matches
Mail list logo
