GitHub user bvbharatk opened a pull request:
https://github.com/apache/cloudstack/pull/800
CLOUDSTACK-8798 Fixed the vrrp virtual ip config in case of rvr enablâ¦
Fixed the vrrp virtual ip config in case of rvr enabled isolated networks.
changed the CsRedundant.py to bring down
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/800#issuecomment-139486801
Hey @bvbharatk
Thanks, dude! I really loved the test report! :)
LGTM :+1:
Cheers,
Wilder
---
If your project is set up for
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/800#discussion_r39263080
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDatabag.py ---
@@ -130,7 +136,10 @@ def get_router_password(self):
This is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/800#issuecomment-139551429
cool
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/800#issuecomment-139532157
@bhaisaab , should we wait for a new commit from @bvbharatk on this PR
before merging it?
Cheers,
Wilder
---
If your project is set up for it,
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/800#issuecomment-139523586
Minor issues, otherwise code changes look alright
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/800#issuecomment-139539283
I will merge this, since it got 2 LGTM, and will change the if as suggested
by Rohit in my next PR that will touch the python files.
---
If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/800
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
