Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-143234582
This broke VPC default gateways, which was fixed in #738. Looking into a
solution now.
---
If your project is set up for it, you can reply to this email and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-140101031
@bvbharatk or @ke4qqq something went wrong with the auto-close (wasn't
merged properly) Could either of you close this PR please? Thanks!
---
If your project
Github user bvbharatk closed the pull request at:
https://github.com/apache/cloudstack/pull/784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-139990182
@wido you can ask @bvbharatk to close it or add the message
This closes #784
to a related PR commit (same functionality, I would suggest)
---
If
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-139915266
This one was merged, but it wasn't closed since something went wrong with
the commit to master.
@remibergsma, help? Any idea on how to close this PR?
---
If
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39248790
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,25 @@ def get_control_if(self):
return ip
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-139513737
After applying patch, was able to create VPC successfully.
LGTM.
Sub-process optimization is good to have. This PR will unblock the VPC
creation.
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39275218
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,25 @@ def get_control_if(self):
return ip
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-139137040
Okay, @bvbharat ... thanks for the update. :)
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39178692
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,25 @@ def get_control_if(self):
return ip
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39176487
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -105,8 +121,17 @@ def process(self):
ip = CsIP(dev,
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39176449
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,25 @@ def get_control_if(self):
return ip
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39242678
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -105,8 +121,17 @@ def process(self):
ip = CsIP(dev,
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-138818591
Hi @bvbharat ,
Any news on this PR?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39018553
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,17 @@ def get_control_if(self):
return ip
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-138885057
Hi @wilderrodrigues
will update once i am done testing against vpc networks.
---
If your project is set up for it, you can reply to this email and have
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39033655
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,17 @@ def get_control_if(self):
return ip
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-138450694
Hi @bvbharatk
couple of questions regarding your changes:
1. There was also an issue with VPC VRs, which was reported/fixed here ->
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r38897976
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -261,20 +261,9 @@ def set_master(self):
self.set_lock()
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r38914728
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,17 @@ def get_control_if(self):
return ip
GitHub user bvbharatk opened a pull request:
https://github.com/apache/cloudstack/pull/784
CLOUDSTACK-8799 fixed the defalut routes
CLOUDSTACK-8799 made changes to fix CsRedundant.py
You can merge this pull request into a Git repository by running:
$ git pull
21 matches
Mail list logo
